From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uLMMI85bxWNRXgAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 15:14:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qEUJIs5bxWM2+AAAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 15:14:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BEBD2A34F for ; Mon, 16 Jan 2023 15:14:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHQFQ-0006Oy-AB; Mon, 16 Jan 2023 09:14:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQFO-0006AX-Fx for guix-patches@gnu.org; Mon, 16 Jan 2023 09:14:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHQFO-0002ZA-5C for guix-patches@gnu.org; Mon, 16 Jan 2023 09:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHQFN-0005uH-JR for guix-patches@gnu.org; Mon, 16 Jan 2023 09:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59760] [PATCH] gnu: Add ncrack. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 59760@debbugs.gnu.org Received: via spool by 59760-submit@debbugs.gnu.org id=B59760.167387841222654 (code B ref 59760); Mon, 16 Jan 2023 14:14:01 +0000 Received: (at 59760) by debbugs.gnu.org; 16 Jan 2023 14:13:32 +0000 Received: from localhost ([127.0.0.1]:60954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQEu-0005tJ-7P for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:13:32 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:46831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQEs-0005t5-7b for 59760@debbugs.gnu.org; Mon, 16 Jan 2023 09:13:31 -0500 Received: by mail-qt1-f169.google.com with SMTP id x7so14534272qtv.13 for <59760@debbugs.gnu.org>; Mon, 16 Jan 2023 06:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yrpy33qlDoPpoB/NQvFky11v6Mqy0h8uTYD8HGCEK6k=; b=IXNkJZgbEmVhdKcvh6EhFU1FmMADOz0Dkvt4DJNr6s6rVyrgMjULGMkoilrFhDWbDK IE+QSxA1ESrt6lpWPK88K0e3bu7WVSh8epMFDW10Ufu1zq8sH0ypG2TM7+t9AmOcMJt1 E/cwLA75QjG+wz/NbRC06+twkCWzU9PeAf5CZLfQEJf9754Jx1U1cFJHiHw9tPbElajv MVyLVTCJ+SzzZ/H2OcJya5JXAJaymcQC5e+Y/kJaf1w0qli37mhFD9JOSgeXNw9HCC11 iaqmhzQM+i/KHAS4DgThARMIAaEd5Jqx4d1LIqmxQ1+EBUZyGpkJA05ia/u42KxU2j5m YnlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yrpy33qlDoPpoB/NQvFky11v6Mqy0h8uTYD8HGCEK6k=; b=5MTbpXxEFnKPYbZ2VWWxIBVL+QH3gOp8+JoMpGF/vqFNjBBO8lbq6yQhuArr+O1+EK uW6qXRfFHclVKAmkoHle2bP0rUhihEbY8WiGZ9wltsHxs1gcVc1GX4X8q2fxSbq7SAlh jy9SQp3Fvyo9FAn9sVO+Mdckz6JAQL+2Hnu0R27tARFPUJ1hAkaqrXNI1YtmaIoJaigy XvSvyg+dlIgqqXFNby9NzgwqNhp6Mg7N7mw911ngIy/S/ZVQkXOSIhjh4v8O29S09geo 9cjI7pPk4BqKaWb3Ju55a+rVvXxI8qE1V+N2Tu07IMaQdS3YXiRRMe05u8DKYYT5ivXB JEqQ== X-Gm-Message-State: AFqh2kpegLTfFsY77eSgrwkUpWum0lQZBDyVQ/UOElmsU2dF7TJNM3c6 irphdJRfSYwzVhVBF+yTdFTMn1G8+jc+kr4+ X-Google-Smtp-Source: AMrXdXuGNjE7tO1DJT1rD1Msrf/br/Pj5Q0cAnJyc7wKWhLZHoFSZBbsGnywNm6m49sw3GiVeEtLGw== X-Received: by 2002:ac8:4a04:0:b0:3b2:ae67:97f8 with SMTP id x4-20020ac84a04000000b003b2ae6797f8mr15553954qtq.44.1673878404324; Mon, 16 Jan 2023 06:13:24 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id k4-20020ac84744000000b003b630ea0ea1sm1635799qtp.19.2023.01.16.06.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:13:23 -0800 (PST) From: Maxim Cournoyer References: Date: Mon, 16 Jan 2023 09:13:22 -0500 In-Reply-To: (phodina@protonmail.com's message of "Fri, 02 Dec 2022 05:21:28 +0000") Message-ID: <878ri2bm9p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IXNkJZgb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673878478; a=rsa-sha256; cv=none; b=m3hYGzgdgbvWzli0W6q7nUq2oHu31md0jzi0QBhNOMxVfL4p8MPz+WsEnMdxAcAqOibPr8 m9RORD0mWbhWQi88iPlKHxEtjpBh1225bDJj71Za+p489gHCNAtuIwpxlghQGPdl91dBy/ oHbrNxFLFOOCOSYBOQCzeZoh8ReKm0P1UYG6qtLVCQ0gi/131l+SGHgjdRnK824EDgACLY LdK9Wwzv/RBiBWe9oLtrNlxzXRwTL5otqHU6rxlHmd11DoHtVH8sesFqL7zRM2mOAoz8SK 8BTIrl9nI/Cx8R6kwv46+4cJRtZ6qJ8vsXL9C3qtcLdK/ihaIrBlgTm41gldQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673878478; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Yrpy33qlDoPpoB/NQvFky11v6Mqy0h8uTYD8HGCEK6k=; b=ej3sDSJ/MRaZh/b7VaxbjkttxRbIM0JeQf2B5IGAgJGuWPsVE35p7JOb075LjEz7oZoJRK qgqN5F6givP2l/GaLsuZz+UbNJAIFNzMe07XJAwzZIZENapIFLwlPRarkM0p7XSPHEDKbG aGmXn1WKB1LcVVt090y8FWIxanmMMsGqrs9lkpZkwGhLXrhmJ57ZpPHZ4GhKBNSicxi81l aqh5d5xLiUn6MrfTxd2IvCq/3lxaeFA9x2lQtWfEwIrTL+AW2YetVA1nl0SILmBy0L8KPF LDTC/VjNUsA2tZsuPoPSKmwi7gjSfGV5KCmVNbbMkJtyPRM/rVvmvSAbVdUwsA== X-Migadu-Queue-Id: 1BEBD2A34F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=IXNkJZgb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -3.32 X-Spam-Score: -3.32 X-TUID: 2U6RCzJ5Od+a Hi Petr, phodina writes: > Hi, > > here's another penetration testing tool - ncrack. Slowly catching up to Kali :-) > > ---- > Petr > From cfcc719c2fc2e40fb2936269dc4bdbd28be5d71a Mon Sep 17 00:00:00 2001 > From: Petr Hodina > Date: Fri, 10 Jun 2022 10:26:13 +0200 > Subject: [PATCH] gnu: Add ncrack. Neat, thank you! [...] > * gnu/packages/patches/ncrack-fix-spelling-errors.patch: New file. > * gnu/packages/patches/ncrack-nullcheck.patch: New file. > * gnu/packages/patches/ncrack-unbundle-opensshlib.patch: New file. The patches above have unclear upstream status; could you annotate the files with the information? They should be submitted upstream for consideration. For upstream to consider your last patch though, you'd want to have the opensshlib patch configurable via a configure.ac check or option. It could for example check for a system-provided opensshlib and use this, else fall-back to the bundled library build that it currently does. > diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm > index 3f44d082fb..ce004c52f0 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -786,6 +786,35 @@ (define-public knockd > at the link-layer level.") > (license license:gpl2+))) > > +(define-public ncrack > + (package > + (name "ncrack") > + (version "0.7") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/nmap/ncrack/archive/refs/tags/" > + version ".tar.gz")) > + (patches (search-patches "ncrack-nullcheck.patch" > + "ncrack-fix-gcc-10-build.patch" > + "ncrack-fix-autotools-compat.patch" > + "ncrack-fix-spelling-errors.patch")) > + (sha256 > + (base32 > + "0jnif319rjykiphi211v1c2hblw1ql190dnbd030qjkwcz6p3ygk")))) > + (build-system gnu-build-system) > + (arguments > + (list #:tests? #f)) ;no test suite > + (native-inputs (list pkg-config)) > + (inputs (list openssl zlib)) > + (home-page "https://nmap.org/ncrack/man.html") > + (synopsis "Network authentication cracking tool") > + (description > + "@code{Ncrack} is a tool for network authentication cracking. It was To be more accurate, I'd use "The @command{ncrack} command is a tool for [...]". Otherwise, LGTM. -- Thanks, Maxim