From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6HOIAp1pxmNKEQEAbAwnHQ (envelope-from ) for ; Tue, 17 Jan 2023 10:25:49 +0100 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oOBjAp1pxmO4PwEAauVa8A (envelope-from ) for ; Tue, 17 Jan 2023 10:25:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id B94341A8E for ; Tue, 17 Jan 2023 10:25:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHiCS-0002Cv-BG; Tue, 17 Jan 2023 04:24:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHiCJ-0002At-57 for guix-patches@gnu.org; Tue, 17 Jan 2023 04:24:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHiCI-0000GH-Sl for guix-patches@gnu.org; Tue, 17 Jan 2023 04:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHiCI-0000FS-Ep for guix-patches@gnu.org; Tue, 17 Jan 2023 04:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60802] [PATCH v2 1/2] platforms: Raise an exception when no suitable platform is found. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Jan 2023 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Tobias Geerinckx-Rice , Josselin Poiret , 60802@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Christopher Baines , Ricardo Wurmus Received: via spool by 60802-submit@debbugs.gnu.org id=B60802.1673947399884 (code B ref 60802); Tue, 17 Jan 2023 09:24:02 +0000 Received: (at 60802) by debbugs.gnu.org; 17 Jan 2023 09:23:19 +0000 Received: from localhost ([127.0.0.1]:35674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHiBa-0000EC-WC for submit@debbugs.gnu.org; Tue, 17 Jan 2023 04:23:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHiBV-0000Dl-Bd for 60802@debbugs.gnu.org; Tue, 17 Jan 2023 04:23:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHiBP-00007c-Ey; Tue, 17 Jan 2023 04:23:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=KU/KLhRHBZz9Ozges6rzDnc/7/7s6ytGOTnzEyeGwog=; b=KEoHM25jlepV6ytk5Nl1 gLRtfaZXuFQ+IinDZHmcHoLLj+I4zYMWrWeg2TVzDX9IPDC7qzimfPlyaJS3joCFMIwz5yD7eFHkQ Pp+CXf2Rl2kQ8C+m2SYVoywSzCeH+V8UiluPtMjswCq8LSr1onzvYB/yf9ip1E0hLBD9w8uu7zYmq EzYXTAMtN8yBe19WzJHC7fI4lxK44cQmjma6FvDb9+z0Pp2J7B+pE2PfEqGTXqBaWC1xUdCi5R+N9 haMd0MnZTTziBNj5TFxXuBwYVfjNBQ5/nX+ZeJOSqlKu4kzd6AjFUO8OnZ8u7lPLFuRUtWRO9zQpc 8EKS6nwUtOqo+g==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHiBF-0001aE-Vg; Tue, 17 Jan 2023 04:22:58 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230114041903.7121-2-maxim.cournoyer@gmail.com> <87o7r19ocn.fsf@gnu.org> <87mt6i5q4q.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?UTF-8?Q?Niv=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 10:22:55 +0100 In-Reply-To: <87mt6i5q4q.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Jan 2023 12:46:29 -0500") Message-ID: <878ri1jz0w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673947548; a=rsa-sha256; cv=none; b=CK5thhoj146PMm4cc/Qo5ewbAG7zxVFeUBVAeiGgvsk44DGmoc0Ys16GcNsBf+IRt7ieLC v2UESGgeHlIqAkNAkAzg7oI/J5yJ/qfggvfsbM05heHKEyR7ukyva5Tw5OYFL80qcf18i1 j5WyldBe3FmTYR7J/rRulO7kxiaTZPOyL9iDABFI7QzeFvsaaEVEnTAlsREEcafA6LxoTV hR4/hN3iFgVxMdpDP4vupWmGRKwlhvy5+iCeOftnAilUbE3ZFgFKUYJr/aspgQ/yEWKULX XJhaxUW7oSzmHbiM7igl5wNJL+OQh8GEDpxvW9mEzDIjexK+NreyuRoSzyZ7xQ== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KEoHM25j; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673947548; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KU/KLhRHBZz9Ozges6rzDnc/7/7s6ytGOTnzEyeGwog=; b=oWEnD8YU7bU1vGt+bm1fCkoQC9cQlKMpb6uk2L8Tqt5oYSY84WK42pbSAspS3Ou+RcVfQ4 XVk7//ZRgejwKcdSGXnMUsA0ZvQ+7N/ZknvHFMxwYYcZaQvQckMA3XBm/k9RNBfqWRI3QZ VJREC8NqXpuam4Wn8hQKvkhikk28CH9T2FV6ko4uLXDzCGf4Fodvztk+OCywEmmakxoqk+ GZBfCKk6+XHR3EcJwxXo5IeOBquAcUDnB4PMJJPemkl9GBdfEYPa35hoL7h6py+0k0Kb2h sbT62B5ZO+V4doExdUTt28HLKER84vpSOm4Uo47YYICRrLoh6CXvE/VdEwn48w== X-Migadu-Spam-Score: -2.53 X-Spam-Score: -2.53 X-Migadu-Queue-Id: B94341A8E X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KEoHM25j; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: xuDl9QvBngyI Hi, Maxim Cournoyer skribis: >>> +++ b/gnu/packages/bootstrap.scm >>> @@ -315,7 +315,7 @@ (define* (glibc-dynamic-linker >>> (%current-system)))) >>> "Return the name of Glibc's dynamic linker for SYSTEM." >>> ;; See the 'SYSDEP_KNOWN_INTERPRETER_NAMES' cpp macro in libc. >>> - (let ((platform (lookup-platform-by-system system))) >>> + (let ((platform (false-if-exception (lookup-platform-by-system syste= m)))) >> >> Maybe we don=E2=80=99t need to protect here, because it=E2=80=99s a > > We cannot do this, otherwise the other cond clauses would never been > evaluated: Yes sorry, I realized later but hit =E2=80=9CSend=E2=80=9D before deleting = the sentence prototype. :-) >> So far the we use (srfi srfi-35) exclusively to define condition types; >> I think we should do the same here, for consistency. > > Could we instead start migrating away from srfi-35 to (ice-9 > exceptions), which is the new native way to use exceptions in Guile? Maybe, but I=E2=80=99m not convinced it=E2=80=99s worth it. > I think it'd be nicer to use it in the future, to avoid newcomers > being confusing about the 3 or 4 ways to manage exceptions in Guile That=E2=80=99s why I suggest sticking to one way in Guix, which is currently SRFI-34/35. > Migrating the whole code at once doesn't seem a good idea, so gradually > transitioning (such as using (ice-9 exceptions) for new code) appears a > good idea to me, if we agree on the direction! I=E2=80=99m not convinced it=E2=80=99s worth transitioning, and I=E2=80=99m= even less convinced about a gradual transition, as that would make it harder for newcomers to join, people wouldn=E2=80=99t be sure which style to use, etc. It=E2=80=99s a discussion worth having though, but I think we can have it separately. Thanks, Ludo=E2=80=99.