From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gO7tIPQC4mNBgAEAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 08:51:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iGrnIPQC4mNMWQAAauVa8A (envelope-from ) for ; Tue, 07 Feb 2023 08:51:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1673510F02 for ; Tue, 7 Feb 2023 08:51:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPIkq-00033S-Vq; Tue, 07 Feb 2023 02:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPIko-00033C-Ki for guix-patches@gnu.org; Tue, 07 Feb 2023 02:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPIko-0000oN-CE for guix-patches@gnu.org; Tue, 07 Feb 2023 02:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPIko-00068w-7j for guix-patches@gnu.org; Tue, 07 Feb 2023 02:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 07:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60899 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" Cc: 60899-done@debbugs.gnu.org, cox.katherine.e@gmail.com, 60899@debbugs.gnu.org X-Debbugs-Original-Cc: 60899-done@debbugs.gnu.org, Katherine Cox-Buday , guix-patches@gnu.org Received: via spool by 60899-done@debbugs.gnu.org id=D60899.167575622123547 (code D ref 60899); Tue, 07 Feb 2023 07:51:02 +0000 Received: (at 60899-done) by debbugs.gnu.org; 7 Feb 2023 07:50:21 +0000 Received: from localhost ([127.0.0.1]:50894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIk9-00067i-7n for submit@debbugs.gnu.org; Tue, 07 Feb 2023 02:50:21 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIk7-00067Z-1P for 60899-done@debbugs.gnu.org; Tue, 07 Feb 2023 02:50:19 -0500 Received: from localhost (unknown [IPv6:2a02:1808:280:b109:f055:17e:cfb4:2]) by mira.cbaines.net (Postfix) with ESMTPSA id 776CC27BBE9; Tue, 7 Feb 2023 07:50:17 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5f31f13d; Tue, 7 Feb 2023 07:50:16 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Tue, 07 Feb 2023 08:42:51 +0100 In-reply-to: Message-ID: <878rh9didm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675756276; a=rsa-sha256; cv=none; b=UwFa2S25qcB/0ek2ns2gGtysN5dxpsvUeXcMDjECTNNycbspIYAlOSoMIi8bSPIC5h64P1 HcUXqcpBFnG5omL9++qnfCHqYdc/ETd5dvHpxxXTLLW3PjL1QkY1atQ7WRBIb1CIFzX4AW SR+bK7mx89686hLGY9dzsh+D81tkh8XNWiPQeEu6iQZNGxsfCpKSVfsoqcyZTJ4LbYmCug yVMicBLUlDGMmOutQ1xcsfvYbY8u8HzDTG083xaed0PcSfsUpSKFfqXbKJehczd2wfx3D1 wF3iQhgNkR326bnPxYN0USrsuVKiDkNIPIfNZB3AuwSjixN+4he9V82T+JZBRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675756276; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=6306jHQ1GVgu6EZ8K2q3v0SD0pQUMBWaDBcS9ImhxGU=; b=hxfYOT+UXgQK5U4ns5R1i4bYi1aAFNCgI/+ULyNnnZInaJoQIOoPySLljmsFOOXTWgQXjU aPmjleq872KN4XrAQiHygd3F/ZOdB+3Pbf1x9YXnxHS2OtwUivRxE9nY0TfdqUL6Gdz68l iPe/Cm2T3Wp/uR2nHvt+eCq3QJZwsEI+gxD5+PI+s+OP5txqMTRMRybcUqGKQ6D36VrW1s FlheSp/fB+lXRtL9U30pQsqNd41WSfWrSL1OC+kplVzP4az6oFkHEhUgU8XkhiGBX+MCc3 /DRwwD9Sq64VtVXSJv2vxKlrlbnyPtrmCdvmxSwecx0VS97AeuvMkKhfSA4g5g== X-Migadu-Spam-Score: -3.69 X-Spam-Score: -3.69 X-Migadu-Queue-Id: 1673510F02 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: MZ/MCTdlhIew --=-=-= Content-Type: text/plain "(" writes: > [[PGP Signed Part:Undecided]] > On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote: >> I've made a few tweaks and pushed this to master as >> f3ab5888a0bc6446104ddbba41a413a86eb298e2. > > Nooo, my review was too slow :P I think reviewing changes/sending feedback after things have been merged is fine (and important). If more people get involved in reviewing things, this is probably something that'll happen more, so I think for now it's good to embrace it. Hopefully we can continue the discussion around these changes and perhaps further improve things with some additional patches. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPiArVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfnlg/7BLYjj1+bj2Y3TP4Kww7t4Ley4VpeQEjL jdElYggdSLiYNlc5QKuSrcWsaCLWHUdE2lDCQGZ20m5Wt8iyjwEaRcWw/S5TwFmk UDDg3zDHD2WIfW/Xm71ShNjCtAE28MNqE9/fUIXGaSdO1rxEBsnLIPpeSWtbwjPb P21p+6uoX8KwdO+PCC/jKUBoL2XraXD6RKJDyzJfKqv2qb6fOP0tyz4w8j57t8HO DGNwNAtuKNNHRvekCQyQrq2heuibrJiFy27yuf+926xicKnGpzWtF7r//lEvSeIj Msq5AJ9myq50Oq7sLBBwDt4C1r80YTYxIC/pdjeaWa8PclhtqiTJ9DQn+cjvHR0I bViD3pwoVOqIpMo+ppOdcU700YCBzkW3sfEbB2WDFmh55HcL6NJZbHaHyrLcFNiD dRUwcBDWaNE6P/sPQAHy4iYz8kaNAP1n1rKSDA7DXnYp3FTIk321YN0Y/mqntlld 5Df/LYaVFtxJnQ1tmRUTBsUKKvtZNy1E6+/AnvC4dPCL+WEybCPjqjkPRwbe3y24 veJ+gqDPJqGhTAp9ZHj3og+IoaCx3RT6ikDD8MNIgjwrLK5+bLBxsyePZjy4zNvF 2c3YWHHXL3T07iRQOYnoWYBN3mz0FoXABbPXcSBR+FV/sZwAt9WPvKstvAR7ROh+ 8Ie5UK+uCYA= =6aGL -----END PGP SIGNATURE----- --=-=-=--