From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WNn9Fn8FU2SSFAEASxT56A (envelope-from ) for ; Thu, 04 May 2023 03:08:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +BL9FX8FU2QyDgEAG6o9tA (envelope-from ) for ; Thu, 04 May 2023 03:08:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56AE811B0C for ; Thu, 4 May 2023 03:08:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puNS0-0007O8-K8; Wed, 03 May 2023 21:08:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puNRz-0007Nk-Au for guix-patches@gnu.org; Wed, 03 May 2023 21:08:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puNRz-0004hF-2x for guix-patches@gnu.org; Wed, 03 May 2023 21:08:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puNRy-0004vj-H5 for guix-patches@gnu.org; Wed, 03 May 2023 21:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63044] [PATCH] gnu: python-setuptools: Disable date checking in bdist_egg.py Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 01:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63044 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brian Cully Cc: 63044@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Lars-Dominik Braun , jgart Received: via spool by 63044-submit@debbugs.gnu.org id=B63044.168316246418929 (code B ref 63044); Thu, 04 May 2023 01:08:02 +0000 Received: (at 63044) by debbugs.gnu.org; 4 May 2023 01:07:44 +0000 Received: from localhost ([127.0.0.1]:48112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puNRg-0004vF-4y for submit@debbugs.gnu.org; Wed, 03 May 2023 21:07:44 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:58612 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puNRa-0004v3-T6 for 63044@debbugs.gnu.org; Wed, 03 May 2023 21:07:42 -0400 Received: from psyduck (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id CAC5496B4; Wed, 3 May 2023 21:07:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1683162458; bh=N90IiTpRSVqrYher0y0Xrh74D9kN0qMwaJ6gdbnCFto=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=tBHr/qLj5rqRSgXy+udc5+6n36mO9oLmm1xsbewZGAhgcjlRTBOT9bo+5BEtiv9vM ChKqTJK/nqO1G1oVvdJRy9wDjzRHBPeLoWq7cUpMYX7Io6+QC/M3YJ1gQGD+tBw9N1 r2GCj15LY7W31FUuC3ZOcy/Hnc8DAfl+bSHp7vVw= References: <87ildm3zf6.fsf@psyduck.jhoto.kublai.com> <87bkjd46wo.fsf@psyduck.jhoto.kublai.com> <87jzxtqf4m.fsf_-_@gnu.org> <87jzxskkpv.fsf@psyduck.jhoto.kublai.com> <87r0rxyydq.fsf@gnu.org> <87ild9oysd.fsf@psyduck.jhoto.kublai.com> User-agent: mu4e 1.10.2; emacs 28.2 Date: Wed, 03 May 2023 20:37:14 -0400 In-reply-to: <87ild9oysd.fsf@psyduck.jhoto.kublai.com> Message-ID: <878re4q4z3.fsf@psyduck.jhoto.kublai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Brian Cully X-ACL-Warn: , Brian Cully via Guix-patches From: Brian Cully via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683162494; a=rsa-sha256; cv=none; b=lsGYK2e6/WiMb8Hr+fI2iMZ70D/h5v+AhsfIgsVHIGOy31iWIq7cL0T4oE2JOi9bOnl4LB DsyDD5wa85LB0MrRXQrv6yA8Jlc8fo2aJvPpkXMBItPcbmN3RjdDUfHwSEFSa1fHoDnnqK 3Y0HzS7MKVKITGdO6uPyxnp4QkiTUMDLMf3HmWMDaILbU16DZ/JEaKHWaH+TplSPaXfggR ulzkxDX1bty1/0Zhb3HzpdZNx+EKRpTI0v1gQFlRDcjiwSdXLs1fMjacG52mP5Gnp/Fj/B RH3+7ITiNM8DN5nX19bZzo0xbSwYCebvbj8EP5VEfAMQ/nfOTE8SHMV2Rs2R0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b="tBHr/qLj"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683162494; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0ynCbsy1M88cKao7an6qariA9nke9icSqXrJX9eK13I=; b=cAm+Iq4JoMrlll0zaA2spiz95/m6+I1d2PbwQCC0kq9P7GKNf0Wr/xGZGULou85wR8M4Rn OsD7JDQZxAyfo7yAXBW4z+3RIGQcScyWzAUK9C4fMrsOunnWydhoOgQACqPcQrqqNzJLlP 7OXKnOKXAEruhE9auEVh7L69KxgZsvR/TFS678uUg5lKyb4sE+uiFt2/qLLQzHekLPo6sG RSE0E1dL74rjjEAGO6V0eGb4xRzdiZrh91JZvfLfbA8+l+0RNJckNY8683HHh1EG3ZNLvG Cb1Dv2EQsD5O0Y2Brkzx5gwW8IcaHro5sgn+jnrw660GloGw3PrDGf2f6ivRMA== X-Migadu-Spam-Score: -2.71 X-Spam-Score: -2.71 X-Migadu-Queue-Id: 56AE811B0C X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b="tBHr/qLj"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: 4HQw72r6EjMI Brian Cully writes: > Ludovic Court=C3=A8s writes: > >> The way to do that is to add (guix build python-build-system)=20 >> to >> #:imported-modules and #:modules in those packages, and then to=20 >> use >> =E2=80=98modify-phases=E2=80=99 to add that =E2=80=98ensure-no-mtimes-pr= e-1980=E2=80=99 phase=20 >> to >> those >> of =E2=80=98gnu-build-system=E2=80=99. >> >> How does that sound, Brian? > > That sounds reasonable to me. I'll update the ticket in a bit=20 > with > these changes. This turns out to be trickier than it first appears: For one thing, =E2=80=98ensure-no-mtimes-pre-1980=E2=80=99 isn't exported f= rom=20 (guix build python-build-system). I can use =E2=80=98@@=E2=80=99 to referen= ce it,=20 but that seems less-than-ideal. A larger problem is that =E2=80=98ensure-no-mtimes-pre-1980=E2=80=99 has a = bug: it=20 blindly tries to change the utime of files even if they're=20 symlinks, which raises an =E2=80=9Coperation not permitted=E2=80=9D=20 exception. It's easy enough to fix this, but since it changes=20 =E2=80=98python-build-system=E2=80=99, it causes a tremendous amount of=20 rebuilding. I'm not sure how to proceed. The bug with the build system should=20 certainly be fixed, but it'll be disruptive. Until then, at least=20 =E2=80=98criu=E2=80=99 will remain broken =E2=80=94 though =E2=80=98sssd=E2= =80=99 is now building=20 correctly with the new phase. This is the patch: --8<---------------cut here---------------start------------->8--- diff --git a/guix/build/python-build-system.scm=20 b/guix/build/python-build-system.scm index aa04664b25..1236ea62cd 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -270,7 +270,8 @@ (define* (ensure-no-mtimes-pre-1980 #:rest _) ;; timestamps before 1980. (let ((early-1980 315619200)) ; 1980-01-02 UTC (ftw "." (lambda (file stat flag) - (unless (<=3D early-1980 (stat:mtime stat)) + (unless (or (<=3D early-1980 (stat:mtime stat)) + (eq? (stat:type stat) 'symlink)) (utime file early-1980 early-1980)) #t)))) =20 --8<---------------cut here---------------end--------------->8--- -bjc