unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fabio Natali <me@fabionatali.com>
Cc: 63370@debbugs.gnu.org
Subject: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 18:15:38 +0200	[thread overview]
Message-ID: <878rdyyf2t.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <36ef72b8f78a52274eec6e300996ad4f387c2462.1683550987.git.me@fabionatali.com> (Fabio Natali's message of "Mon, 8 May 2023 14:05:20 +0100")

Hello,

Fabio Natali <me@fabionatali.com> writes:
>
> * gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Thank you.

> Signed-off-by: Fabio Natali <me@fabionatali.com>

In Guix, you don't sign your own commits.

> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el")

This is an issue, because the URI is not stable. Please use GitHub
repository instead: <https://github.com/emacsmirror/framemove>.

> +    (description "@code{emacs-framemove} is similar to the
> @code{windmove.el}

Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> Windmove.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2023-05-08 16:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 13:05 [bug#63370] [PATCH] gnu: Add emacs-framemove Fabio Natali
2023-05-08 16:15 ` Nicolas Goaziou [this message]
2023-05-08 19:15   ` Fabio Natali
2023-05-10  8:00     ` Fabio Natali
2023-05-08 19:07 ` Fabio Natali
2023-05-11 21:59   ` bug#63370: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rdyyf2t.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=63370@debbugs.gnu.org \
    --cc=me@fabionatali.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).