From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AJycNV7Fb2QFGAEASxT56A (envelope-from ) for ; Thu, 25 May 2023 22:30:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gEulNF7Fb2TpbQEAG6o9tA (envelope-from ) for ; Thu, 25 May 2023 22:30:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8FEC494A9 for ; Thu, 25 May 2023 22:30:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2Hb6-0000CL-2x; Thu, 25 May 2023 16:30:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2Hb0-0000C3-SM for guix-patches@gnu.org; Thu, 25 May 2023 16:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2Hb0-0000DZ-Jl for guix-patches@gnu.org; Thu, 25 May 2023 16:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2Hb0-0006J3-FE for guix-patches@gnu.org; Thu, 25 May 2023 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63714] [PATCH] gnu: Add emacs-x509 Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 May 2023 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63714 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Conner Cc: 63714@debbugs.gnu.org, David Conner Received: via spool by 63714-submit@debbugs.gnu.org id=B63714.168504658624197 (code B ref 63714); Thu, 25 May 2023 20:30:02 +0000 Received: (at 63714) by debbugs.gnu.org; 25 May 2023 20:29:46 +0000 Received: from localhost ([127.0.0.1]:48260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2Haj-0006IC-Rq for submit@debbugs.gnu.org; Thu, 25 May 2023 16:29:46 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2Hah-0006Ht-0t for 63714@debbugs.gnu.org; Thu, 25 May 2023 16:29:43 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 06EF0FF805; Thu, 25 May 2023 20:29:35 +0000 (UTC) From: Nicolas Goaziou References: <20230525100859.2049132-1-aionfork@gmail.com> Date: Thu, 25 May 2023 22:29:34 +0200 In-Reply-To: <20230525100859.2049132-1-aionfork@gmail.com> (David Conner's message of "Thu, 25 May 2023 06:08:59 -0400") Message-ID: <878rdcf93l.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685046622; a=rsa-sha256; cv=none; b=BSkK+9CBlFbeHAinl3o4yr4lbaBGADqADYvGb2buniiLSl22+ELkDsQHdnmrdYKGykDNGl bOFcdvCc8JPuU55uDk7Xkc4dBEiBSHdyDOeQtuymkHwJNLrfsyy3lbxwKqp+7lf0/+3x45 065y2q19+CXNrsbHVHvLdCjtyFwo71jsLk+IcsEO1Cwl3Nw9saXvedpfPRcE10JdLV3Q0P IOh3f+2W57YQv823Nze/B5Zcbho/rLHTqeascDyua555Slkm2YfEO1ZQlPUe65ZAfifryN EOdQ4uRgLJXekKTqLgoFqs2dEOtBIJNs/yC352q0KlBDZ/eItTWVoILQtGaspQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685046622; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=4J+UC8RQof8mmp4tWbPi63pVVgQtAjbfV01DmviCJlM=; b=mMNaANL+vKmQq6AuUFhIkeUeUzWD9zpQbjtXc2r+OyQ9F60XPJ2Of1mKbTrbfeZYm8CG1i Zlxfi4qo3LP6LshouKcpsdlBskujHbriJSqDb9WSN/wZzxNvl7UrFa9ybLObsmJOT+UBn/ /8rJgiUapoWnlMHcpdy+mEM72EfsuKmn/LuT3PUQ5amlRA8/ZMCNmmC2h+Zk7PopgtNoP9 7vgxdW41Aj/Dz48/GhvCMvYfNq2n0DdKJBNG34jIAdoaMXd4UKHZN5uet4QUpSxREjeu/g WEoKti1Do3YZOuw/cAOjNNUYFna44bAKlcGVEnUCalnpToyY4EO8ZVwrZ4q3pw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.27 X-Spam-Score: -3.27 X-Migadu-Queue-Id: 8FEC494A9 X-TUID: 1SFlIOOWnGSt Hello, David Conner writes: > From: David Conner > > * gnu/packages/emacs-xyz.scm (emacs-x509): New variable. Thank you. Some comments follow. > +(define-public emacs-x509-mode > + (package > + (name "emacs-x509-mode") > + (version "20230430.1518") Guix doesn't use versioning system from MELPA. Unfortunately, this package doesn't seem to set a Version keyword. So the version should be "0". > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/x509-mode-" > + version ".tar")) Please use GitHub as upstream. > + (arguments > + `(#:include (cons* "^keywords.txt" > + "^keyword\\+constant.txt" > + "^constants.txt" > + "^long-name.txt" > + %default-include))) What about something like: (list #:include (cons "\\.txt$" %default-include)) > + (description "Major mode for viewing certificates, CRLs, and other > +PKI-related files. Uses OpenSSL for viewing PEM and DER encoded PKI > +entities.") The description should consist of complete sentences. Could you send an updated patch? Also, could you run tests? Regards, -- Nicolas Goaziou