* [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir.
@ 2023-08-21 4:33 Hilton Chain via Guix-patches via
2023-08-22 12:47 ` bug#65413: Close: " Hilton Chain via Guix-patches via
2023-08-22 16:11 ` [bug#65413] " Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-21 4:33 UTC (permalink / raw)
To: 65413; +Cc: Hilton Chain, Ludovic Courtès
* gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
(shepherd support) for home service.
---
This patch fixes the following error:
Loading /gnu/store/...-shepherd.conf.
herd: error: exception caught while executing 'load' on service 'root':
Unbound variable: %user-log-dir
I wasn't fully sure to report the issue in #65119 since the error didn't occur
in a home container, sorry for my hesitation.
gnu/services/mcron.scm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index db8b539ff5..efb7465549 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -165,6 +165,9 @@ (define (mcron-shepherd-services config)
(ice-9 popen) ;for the 'schedule' action
(ice-9 rdelim)
(ice-9 match)
+ ,(if home-service?
+ '(shepherd support) ;for '%user-log-dir'
+ '())
,@%default-modules))
(start #~(make-forkexec-constructor
(list #$(file-append mcron "/bin/mcron")
base-commit: 7cad70566322262f6acdbbb965e867e34010eb55
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#65413: Close: [PATCH] services: mcron: Add module for %user-log-dir.
2023-08-21 4:33 [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir Hilton Chain via Guix-patches via
@ 2023-08-22 12:47 ` Hilton Chain via Guix-patches via
2023-08-22 15:21 ` [bug#65413] " Hilton Chain via Guix-patches via
2023-08-22 16:11 ` [bug#65413] " Ludovic Courtès
1 sibling, 1 reply; 4+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-22 12:47 UTC (permalink / raw)
To: 65413-done
On Mon, 21 Aug 2023 12:33:22 +0800,
Hilton Chain wrote:
>
> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---
Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#65413] Close: [PATCH] services: mcron: Add module for %user-log-dir.
2023-08-22 12:47 ` bug#65413: Close: " Hilton Chain via Guix-patches via
@ 2023-08-22 15:21 ` Hilton Chain via Guix-patches via
0 siblings, 0 replies; 4+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-22 15:21 UTC (permalink / raw)
To: 65413
On Tue, 22 Aug 2023 20:47:51 +0800,
Hilton Chain wrote:
>
> On Mon, 21 Aug 2023 12:33:22 +0800,
> Hilton Chain wrote:
> >
> > * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> > (shepherd support) for home service.
> > ---
>
> Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.
Fixup pushed as 0c4fb8f43f8aba2dcabe1bc97a8f6d8d41057704...
--8<---------------cut here---------------start------------->8---
1 file changed, 1 insertion(+), 3 deletions(-)
gnu/services/mcron.scm | 4 +---
modified gnu/services/mcron.scm
@@ -165,9 +165,7 @@ (define (mcron-shepherd-services config)
(ice-9 popen) ;for the 'schedule' action
(ice-9 rdelim)
(ice-9 match)
- ,(if home-service?
- '((shepherd support) #:select (%user-log-dir))
- '())
+ ((shepherd support) #:select (%user-log-dir))
,@%default-modules))
(start #~(make-forkexec-constructor
(list #$(file-append mcron "/bin/mcron")
--8<---------------cut here---------------end--------------->8---
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir.
2023-08-21 4:33 [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir Hilton Chain via Guix-patches via
2023-08-22 12:47 ` bug#65413: Close: " Hilton Chain via Guix-patches via
@ 2023-08-22 16:11 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2023-08-22 16:11 UTC (permalink / raw)
To: Hilton Chain; +Cc: 65413
Hilton Chain <hako@ultrarare.space> skribis:
> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---
>
> This patch fixes the following error:
> Loading /gnu/store/...-shepherd.conf.
> herd: error: exception caught while executing 'load' on service 'root':
> Unbound variable: %user-log-dir
>
> I wasn't fully sure to report the issue in #65119 since the error didn't occur
> in a home container, sorry for my hesitation.
I tested the changes in ‘guix home container’ and didn’t notice the
error; I wonder what’s going on, would be worth investigating.
Anyway, thanks for the quick fix!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-22 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-21 4:33 [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir Hilton Chain via Guix-patches via
2023-08-22 12:47 ` bug#65413: Close: " Hilton Chain via Guix-patches via
2023-08-22 15:21 ` [bug#65413] " Hilton Chain via Guix-patches via
2023-08-22 16:11 ` [bug#65413] " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).