unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Bruno Victal <mirai@makinata.eu>
Cc: gemmaro <gemmaro.dev@gmail.com>, 63854@debbugs.gnu.org
Subject: [bug#63854] [PATCH] gnu: po4a: Fix SGML tests.
Date: Wed, 06 Sep 2023 10:05:10 -0400	[thread overview]
Message-ID: <878r9j75yh.fsf_-_@gmail.com> (raw)
In-Reply-To: <e4e0b35c-00f9-5532-2a1d-84ad032a3e09@makinata.eu> (Bruno Victal's message of "Thu, 8 Jun 2023 19:46:37 +0100")

Hi,

Bruno Victal <mirai@makinata.eu> writes:

> Hi gemmaro,
>
> On 2023-06-04 13:28, gemmaro wrote:
>> * gnu/packages/xml.scm
>> (libxml2)[native-search-paths]: Add SGML_CATALOG_FILES.
>> (opensp)[native-search-paths]: Remove SGML_CATALOG_FILES.
>
> […]
>
>> @@ -1781,14 +1792,6 @@ (define-public opensp
>>                  (("^\tOSGMLNORM=`echo osgmlnorm\\|sed '\\$\\(transform\\)'`\\\\")
>>                   "\tOSGMLNORM=`echo osgmlnorm|sed '$(transform)'`")
>>                  (("^\t\\$\\(SHELL\\)\n") "")))))))
>> -    ;; $SGML_CATALOG_FILES lists 'catalog' or 'CATALOG' or '*.cat' files found
>> -    ;; under the 'sgml' sub-directory of any given package.
>> -    (native-search-paths (list (search-path-specification
>> -                                (variable "SGML_CATALOG_FILES")
>> -                                (separator ":")
>> -                                (files '("sgml"))
>> -                                (file-pattern "^catalog$|^CATALOG$|^.*\\.cat$")
>> -                                (file-type 'regular))))
>
> Interesting, looking at opensp it seems that it also makes use of the
> SGML_CATALOG_FILES environment variable so I don't think it shouldn't
> be removed though I don't know if it's valid for more than one package
> to share the same native-search-path.

The search paths are not currently 'merged', but if they are exactly
defined the same way (could by via a $SGML_CATALOG_FILES export
defininition (guix search-paths)) then it should work normally.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-09-06 14:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 17:52 [bug#63854] [PATCH] gnu: po4a: Fix SGML tests gemmaro
2023-06-03 22:12 ` Bruno Victal
2023-06-04 12:28 ` [bug#63854] [PATCH core-updates v2 0/2] " gemmaro
2023-06-04 12:28   ` [bug#63854] [PATCH core-updates v2 1/2] gnu: libxml2: Add SGML_CATALOG_FILES to native-search-path gemmaro
2023-06-08 18:46     ` Bruno Victal
2023-09-06 14:05       ` Maxim Cournoyer [this message]
2023-09-06 14:28         ` [bug#63854] [PATCH] gnu: po4a: Fix SGML tests Bruno Victal
2023-09-06 18:44           ` Maxim Cournoyer
2023-06-04 12:28   ` [bug#63854] [PATCH core-updates v2 2/2] " gemmaro
2023-06-19 23:47 ` [bug#63854] [PATCH core-updates v3 0/2] " gemmaro
2023-06-19 23:47   ` [bug#63854] [PATCH core-updates v3 1/2] gnu: libxml2: Add SGML_CATALOG_FILES to native-search-path gemmaro
2023-06-19 23:47   ` [bug#63854] [PATCH core-updates v3 2/2] gnu: po4a: Fix SGML tests gemmaro
2023-07-22 14:56 ` [bug#63854] [PATCH core-updates v4 0/2] gnu: po4a: Enable SGML format gemmaro
2023-07-22 14:56   ` [bug#63854] [PATCH core-updates v4 1/2] gnu: libxml2: Add SGML_CATALOG_FILES to native-search-path gemmaro
2023-07-22 14:56   ` [bug#63854] [PATCH core-updates v4 2/2] gnu: po4a: Enable SGML format gemmaro
2023-10-09 22:20 ` [bug#63854] [PATCH v5] " Bruno Victal
2023-10-11  1:52   ` bug#63854: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r9j75yh.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=63854@debbugs.gnu.org \
    --cc=gemmaro.dev@gmail.com \
    --cc=mirai@makinata.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).