From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sFDMAPlxPmUIAQAA9RJhRA:P1 (envelope-from ) for ; Sun, 29 Oct 2023 15:53:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sFDMAPlxPmUIAQAA9RJhRA (envelope-from ) for ; Sun, 29 Oct 2023 15:53:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B549D17FBC for ; Sun, 29 Oct 2023 15:53:44 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=CfrWHWVG; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698591225; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YWA+3zPEQYB0O/EFdMRACGf4Gm5f2ViHb5imEqtBrRY=; b=IJQvF5UwPAMkE5FBRAYswVO5NzD6vHiV3UoN80nkPm27bPqzEAAQ9AIeYwD1oLqSl/sM6j mDyGASODuwP0jwr5Z7Dzq+REz8UMaADn5HuZP6bFA7/Q9BHns2/np6QPXtpfcWh2UGoMxt N/FoX6ZBh3I03LRxyoa065VgRBCoMxD1+RfVkFgu+WkjT5gA5EZk6XJC8vl6pNNBbzv9yG 9vkSNL1hMtVgQ39e8WlqYNoj3T9TxhHKG7ZkaC/FALYSJ+DU38QX3j0EAUnGpXMaYkrbeI mQOKO8H8zQNSZ3TVrHkAiowNEkk8BnXcqQXEaDy+Gp9upJdvuAgFk7UYB8Ddzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=CfrWHWVG; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698591225; a=rsa-sha256; cv=none; b=cg/B6X+hTGaEXvG3/Bqai0pMfZXxP5UVETag4uwQDqHj7hLYg6QXwxgiKtpBV0NTrcQTw2 ZRp/yoO7vlXd8jkJKTILp3fznUq1qyffaswsIsoSaJwKY7MNOUXWPwF7sPMXoeV6Oyi4Dk TsKMfGoCFK8f/+ENmtuJb/BK1jQXQr+PqRF6bFCjV828OQWb+sDYw9k9zlsSabCNxAm6JT V2STNVAA7RZnvNhCfHghCRaUIrp3NVl3e0PLXlitDZuGQuYLD30uRjU4TSsKgft+L4VISf 2uPubdnyacufimMvtoifyGDB9yei/OxZp+QLT2upX/khswg1Yc6LSQEf9F9rLA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qx7AU-0001dE-OF; Sun, 29 Oct 2023 10:53:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx7AQ-00016u-EF for guix-patches@gnu.org; Sun, 29 Oct 2023 10:53:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qx7AP-0005lL-SL for guix-patches@gnu.org; Sun, 29 Oct 2023 10:53:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qx7Aw-00088g-E8 for guix-patches@gnu.org; Sun, 29 Oct 2023 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Oct 2023 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169859118331215 (code B ref 66436); Sun, 29 Oct 2023 14:54:02 +0000 Received: (at 66436) by debbugs.gnu.org; 29 Oct 2023 14:53:03 +0000 Received: from localhost ([127.0.0.1]:43142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx79z-00087P-25 for submit@debbugs.gnu.org; Sun, 29 Oct 2023 10:53:03 -0400 Received: from jpoiret.xyz ([206.189.101.64]:43748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx79w-00086z-Ti for 66436@debbugs.gnu.org; Sun, 29 Oct 2023 10:53:01 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3175D184D5F; Sun, 29 Oct 2023 14:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1698591146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YWA+3zPEQYB0O/EFdMRACGf4Gm5f2ViHb5imEqtBrRY=; b=CfrWHWVGPDraonDSqwsOF6zFxonoMQfNWgk2pbgMdECPTwIDl6kHniXaXVsMTpzr5QN5O7 MvfxczFJt7dIbpDHnMMQ1W3jyU2vYsdtloEuzrid3nOYiJWFm3KZY5dewIlbjPMevKvpgS nxqOacIP6r9upJ7J1I2dAsRc2FLbhiM8jsEaXIO0IvUoT6rLuRSbG6yKqGQDhSwDdBYumr yDvcEuTVX5pjHewzUIZgdFSxoyh1oZ6HMVJ1oyVCfm8ds2bdIVlBeSQ3aZG+CRywwczS/b a5qCjsDP2V71bqoJCbuSXwFaJUq8EuvzlB1K3T1hnvbDg1wENKAZYhXBgfvwoA== In-Reply-To: <87fs2azmvv.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87jzroyzuk.fsf@jpoiret.xyz> <87fs2azmvv.fsf@gmail.com> Date: Sun, 29 Oct 2023 15:52:21 +0100 Message-ID: <878r7l4h22.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.20 X-Spam-Score: -8.20 X-Migadu-Queue-Id: B549D17FBC X-Migadu-Scanner: mx13.migadu.com X-TUID: pkkmyCkj0eEd --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > Do you use such a tool when applying patches working with Guix review? Yes, it's very useful. > I'm not too fond of adding tool-specific bits to the otherwise > tool-agnostic section above, but perhaps we could add a note or > something. You can view this as a tool-agnostic but clear way way of formally saying "I've reviewed this". Otherwise, it's not entirely clear when someone has reviewed a patch series IMO. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmU+caUQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcailN7C/9JkUFR8VDrWk5Fn+o4wmiRpJUBHVl1Zj7D NoB2OvcgUXm7z3tXWHcwKJUPdXzScQiwt6FfolomAtbxWwqrdYLCn4LwWkGuadxc U0yiMFydcREFCvlynkuYpXbCN/+gkKVWrFU6YY+QKFanxxiq5Tk4mF9oivrooQ0H mSQTDzgWkC/PmtLrTvTqkUpfxf9JRwpdl0vqxkPwbVr3W+5ltmlnraA4oWqLKtsU v3mSM3X8VK0A+MeGKjlg4pZ0VFirPkSo9WDSOei1uymOE5ukantDEVjDXjlmuJ2q K7TOGixajvRvL6+vXYSdC8VOXSRmwE2xqxmhguduH4FQtRQf1lvZY1VaNEpwmpwQ 4mKajByo7frie2IJ+8o6hdYsSFgW93mpNBoXuPlIFEBp5YYFMPmwL4gTbKzQ/FnD +8nFJBrjwunLmZrku35YB2+csUp7bhSmEZxGdvYdQz9xdwjVIw9L5aAmKlzxpXtV Od7Hzs5AQue5JrnXhHLxRS8HRS9WWj0= =u3NA -----END PGP SIGNATURE----- --=-=-=--