unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christine Lemmer-Webber <cwebber@dustycloud.org>
To: 68112@debbugs.gnu.org
Subject: [bug#68112] Update openimageio and Blender [1/2]
Date: Fri, 29 Dec 2023 11:24:15 -0500	[thread overview]
Message-ID: <878r5d2cr0.fsf@dustycloud.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 730 bytes --]


Two patches.  We need a newer version of openimageio to update to the
newest Blender LTS version.  However the newer version of openimageio
doesn't work with our old version of openshadinglanguage... for now,
I've just preserved an older version of openimageio for
openshadinglanguage to use.

It would be ideal to update openshadinglanguage and add that as an input
to Blender too since that would open up custom shading nodes for our
Blender users, but alas, I ran into trouble upgrading
openshadinglanguage and don't have time to do that right now.
I suggest we get in the Blender update and if someone wants to take a
crack at upgrading OSL and adding to Blender too they can do that as a
future patch series.

 - Christine


[-- Attachment #1.2: 0001-gnu-openimageio-Update-to-2.5.6.0.patch --]
[-- Type: text/x-patch, Size: 3602 bytes --]

From e3f1d5554676dc40bd4e76b6b01554472aa8a939 Mon Sep 17 00:00:00 2001
Message-ID: <e3f1d5554676dc40bd4e76b6b01554472aa8a939.1703867045.git.cwebber@dustycloud.org>
From: Christine Lemmer-Webber <cwebber@dustycloud.org>
Date: Fri, 29 Dec 2023 11:07:20 -0500
Subject: [PATCH 1/2] gnu: openimageio: Update to 2.5.6.0.

For the sake of supporting the older version of openshadinglanguage
we have, we also introduce openimageio-2.2 which preserves the
older version

* gnu/packages/graphics.scm (openimageio): Update to 2.5.6.0.
(openimageio-2.2): New variable, inherits from openimageio
and provides old version of 2.2.21.0.
(openshadinglanguage): Switch input to using openimageio-2.2.

Change-Id: I6e9b9563a367f86d2159ac0079c69ce38207fd14
Signed-off-by: Christine Lemmer-Webber <cwebber@dustycloud.org>
---
 gnu/packages/graphics.scm | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 9bc81a3a81..edbdc74dc8 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -37,6 +37,7 @@
 ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
 ;;; Copyright © 2023 Eric Bavier <bavier@posteo.net>
 ;;; Copyright © 2023 Artyom V. Poptsov <poptsov.artyom@gmail.com>
+;;; Copyright © 2023 Christine Lemmer-Webber <cwebber@dustycloud.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -759,7 +760,7 @@ (define-public openshadinglanguage
      (list boost
            imath
            openexr-2
-           openimageio
+           openimageio-2.2
            pugixml
            qtbase-5
            zlib))
@@ -1313,16 +1314,16 @@ (define-public openexr-2
 (define-public openimageio
   (package
     (name "openimageio")
-    (version "2.2.21.0")
+    (version "2.5.6.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/OpenImageIO/oiio")
-                    (commit (string-append "Release-" version))))
+                    (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0aicxbshzv1g9d8d08vsj1a9klaycxaifvvp565qjv70wyma2vkr"))))
+                "14hxydp55cqp5v1kqjpqz7ifv4j9h92hgycqql8hi7n3s4vzjc6j"))))
     (build-system cmake-build-system)
     ;; FIXME: To run all tests successfully, test image sets from multiple
     ;; third party sources have to be present.  For details see
@@ -1354,6 +1355,23 @@ (define-public openimageio
 on formats and functionality used in professional, large-scale animation and
 visual effects work for film.")
     (home-page "https://www.openimageio.org")
+    (license license:asl2.0)))
+
+;; This is here to support our older version of openimageio.
+;; Once openimageio is upgraded, this can be removed.
+(define-public openimageio-2.2
+  (package
+    (inherit openimageio)
+    (version "2.2.21.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/OpenImageIO/oiio")
+                    (commit (string-append "Release-" version))))
+              (file-name (git-file-name "openimageio" version))
+              (sha256
+               (base32
+                "0aicxbshzv1g9d8d08vsj1a9klaycxaifvvp565qjv70wyma2vkr"))))
     (license license:bsd-3)))
 
 (define-public openscenegraph

base-commit: 4d8b93e865ba71d2baa606d11529c3ecb5f14aea
-- 
2.41.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

             reply	other threads:[~2023-12-29 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-29 16:24 Christine Lemmer-Webber [this message]
2023-12-29 16:33 ` [bug#68112] Update openimageio and Blender [1/2] Christine Lemmer-Webber
2024-04-06 16:10 ` bug#68112: " Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r5d2cr0.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=68112@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).