From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id wKM/ORbhD2Y71wAA62LTzQ:P1 (envelope-from ) for ; Fri, 05 Apr 2024 13:31:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id wKM/ORbhD2Y71wAA62LTzQ (envelope-from ) for ; Fri, 05 Apr 2024 13:31:35 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712316694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=rp5PL4rYlO16NooGNq7Ia3SVtti4Y0s/fMKw+u+OMNY=; b=hepRXmTBCkbcpD0no8x10/ljmuU6U6sL4FXT3rSCz4V4FjegY6vmTsdp/1xCW5iH7DB9rE tIQ+F7bobb7WYYnLU5arGZSA4tZok65N6H3ydEJafMADxCvsadrxdxoGK0uo+sENcNVBRn yPpRP5AWuDCtwREvr7FOawOGvvUDZ4x72TpoG5J3vuAhG7FUGAkrM2D5q7+OMAklv0QgCP 7DsurRI+yiWhscGv1H5fTK+85zXU2+SJkF5vOMjnemYYMpmLrWF5r5sTUBadCjdH3Ozirv AtFh/+XDS38KD7953dfO8WbavQbahv6Yl3K3MujMkjLNzZhbxpwEzhPggMhTog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712316694; a=rsa-sha256; cv=none; b=c3Z0ikgdi2GNyC2CU2WPf8UdX7A7TSsxq0ym5qp+kCigU6ygELp6Y66lTEBBnsJDieCvVm Xr6JtaGzBfGDwUMhGmT24bPYuVKCsllIyrY2t3CW81Widhfq8n3tzvNuTGP7pj9zbs6g6q wKYtOcMph5+J6jvE2GWKDw/27krTIpVs0kq9F75BVuYktESfk0jjXKJLNZgZwjMF2Li63p pNBnaVMlSwU7KC4AjCeLhNjHFAyBHHnXKZVC424Dkj/FaynKgQm4/Jj8FxAa1BOw23/YMY suEJDa7u4O83K+/7RauRtzdpVYTNetf5+amOcbYjOdeNf1r2LY0fyJYawNmIUA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0A388E26 for ; Fri, 05 Apr 2024 13:31:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rshmp-0000RS-7o; Fri, 05 Apr 2024 07:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rshmk-0000QS-4K for guix-patches@gnu.org; Fri, 05 Apr 2024 07:31:08 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rshma-0003Jp-Po for guix-patches@gnu.org; Fri, 05 Apr 2024 07:31:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rshmg-0000Cu-3x for guix-patches@gnu.org; Fri, 05 Apr 2024 07:31:02 -0400 Subject: bug#65938: [PATCH v2] gnu: Add edbrowse. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 05 Apr 2024 11:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65938 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christina O'Donnell Cc: 65938-done@debbugs.gnu.org, "B. Wilson" , Steve George Mail-Followup-To: 65938@debbugs.gnu.org, mail@cbaines.net, elaexuotee@wilsonb.com Received: via spool by 65938-done@debbugs.gnu.org id=D65938.171231662427561 (code D ref 65938); Fri, 05 Apr 2024 11:31:01 +0000 Received: (at 65938-done) by debbugs.gnu.org; 5 Apr 2024 11:30:24 +0000 Received: from localhost ([127.0.0.1]:35288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rshm3-00079k-1N for submit@debbugs.gnu.org; Fri, 05 Apr 2024 07:30:23 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:40737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rshm0-0006zl-De for 65938-done@debbugs.gnu.org; Fri, 05 Apr 2024 07:30:21 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 7A15527BBE2; Fri, 5 Apr 2024 12:30:13 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 70d4e5df; Fri, 5 Apr 2024 11:30:13 +0000 (UTC) From: Christopher Baines In-Reply-To: <7e2e19e6c2953905b2ed021f7702b770a78a2143.1712138351.git.cdo@mutix.org> (Christina O'Donnell's message of "Wed, 3 Apr 2024 10:59:11 +0100") References: <20230914064256.16485-1-elaexuotee@wilsonb.com> <7e2e19e6c2953905b2ed021f7702b770a78a2143.1712138351.git.cdo@mutix.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Fri, 05 Apr 2024 12:30:10 +0100 Message-ID: <878r1shwsd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.46 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.46 X-Migadu-Queue-Id: B0A388E26 X-TUID: Vxvj6c40gHs3 --=-=-= Content-Type: text/plain Christina O'Donnell writes: > From: "Christina O'Donnell" > > * gnu/packages/web-browsers.scm (edbrowse): New variable. > --- > gnu/packages/web-browsers.scm | 59 +++++++++++++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > Dear B. Wilson, > > Thank you for this patch that you submitted in September. Sorry it's > been a while since you sent this in, Guix is a bit short of developers > and reviewers at the moment. > > I'm a new contributor trying to help with the backlog of patches, so > you can take my points with a grain of salt. > > This package is good. It applies, builds and runs. The formatting is > more or less right. > > I have no idea how to use or test edbrowse but it runs at least and > passes `guix lint`. > > I've made the following changes: > > - I've reformatted the code to the guix style. > - I've updated from 3.8.7 to 3.8.9. > - I've removed the EBDEBUG make flag as this is a release build. > - I've changed QUICKJS_DIR to QUICKJS_LIB as this was changed > between 3.8.7 and 3.8.9. > - I've opted for passing '#:tests #f' instead of deleting 'check. > - I've set the doc path to /share/doc/ instead of /doc/. > > Aside from these points, I think this patch is ready to be pushed. Thanks both, I've pushed this now to master as 869fa14b786e81f5eb832bc7fd8250248b12651b. I made a few more changes: - Using a gexp for the arguments (this is the newer style). - Reset the author and added Christina as a co-author in the commit message - Moved the patching to a phase rather than a snippet, as I think this is simpler Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYP4MJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeAuRAAlusJ0plbzLruMURbaKfbReEEdyZiiNx6 8TA44yRv4fazNBn0c5xKOS1Sz3UjcVIc1u5Ie2ETl30I9OjpELK8K9B0iZ/Q7U71 OKMpI32qTHqkkQ8WBOfRLnmMGhkydr2lJz6DgmkzEL2GYmLyeIAHD/kB8IUti43p E9/MOdD4NMOCzxIT+SNCljZxYELHFzs5w6xPhmiMzVi0JvQzqI4/y9znhnAJOFsm OkL1fzCgrgjcOeBQjLrodDKZOce0tQ4P4XDSHKz8uSM3HTBhJMvar8D5hPlgshpr V7knAgoW7RbRxJqlcd+Rn4zx4BP7w+Vw/cRvg/oM675DXYt2KqPva+1YZ0WC7JjJ msg0lY0k8kysaVOR6fWpgbkXD50N4e1ELrrE2rV5Md2ohV4z2c9CgdKGiZeG6aeb 1ZDoeatnpuq5BWz6EuptEUa0Qrzs/alC0OniFv0uSpkwaVufnGV9d/FMKwEzJQMr qa0BFk9V92V3VZ3cNZHI00WcjoCiIbB71vSgPmzW/ugPjfzgUL0nOAX703ZxVbYF xdC8wU1XXW0W8FCMgBWF5/9xtiUzOekeElGMIxRpknLwOS0qTZ6+Rz3C+aULGH56 OufqdOk0EoFrihaTMcCPjTokfi4rVZWB+LFH8lwti+kD/+JflXsx219d0LsYa/fw r09oSw4VVps= =UsBr -----END PGP SIGNATURE----- --=-=-=--