unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: "Suhail Singh" <suhailsingh247@gmail.com>
Cc: 69896-done@debbugs.gnu.org,
	Dale Mellor <guix-devel-0brg6a@rdmp.org>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: bug#69896: [PATCH v4] gnu: Add emacs-noman.
Date: Mon, 15 Apr 2024 12:15:46 +0200	[thread overview]
Message-ID: <878r1flynh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <c5500a726749e4bdfda0d3d809a3ef9314073b97.1712879109.git.suhail@bayesians.ca> (Suhail Singh's message of "Thu, 11 Apr 2024 19:49:49 -0400")

Hello,

"Suhail Singh" <suhailsingh247@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-noman): New variable.

Applied, thank you.

> +(define-public emacs-noman
> +  (package
> +    (name "emacs-noman")
> +    (home-page "https://github.com/andykuszyk/noman.el")
> +    (version "0.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url home-page)

Nitpick: I admit I am not a huge fan of the "home-page hack", because it
introduces a non-obvious relationship between source and home-page. So
I took the liberty of following standard practices here.

Regards,
-- 
Nicolas Goaziou






      reply	other threads:[~2024-04-15 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 12:23 [bug#69896] [PATCH] gnu: Add emacs-noman Suhail Singh
2024-04-08 15:36 ` [bug#69896] Difficult to use this package Dale Mellor
2024-04-09  6:11   ` Suhail Singh
2024-04-11  1:43 ` [bug#69896] [PATCH v2] gnu: Add emacs-noman Suhail Singh
2024-04-11 19:16 ` [bug#69896] [PATCH v3] " Dale Mellor
2024-04-11 23:56   ` Suhail Singh
2024-04-11 23:49 ` [bug#69896] [PATCH v4] " Suhail Singh
2024-04-15 10:15   ` Nicolas Goaziou via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r1flynh.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=69896-done@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=guix-devel-0brg6a@rdmp.org \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=suhailsingh247@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).