unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#70680] [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests.
@ 2024-04-30 17:54 Katherine Cox-Buday
  2024-05-14 10:50 ` bug#70680: " Sharlatan Hellseher
  0 siblings, 1 reply; 2+ messages in thread
From: Katherine Cox-Buday @ 2024-04-30 17:54 UTC (permalink / raw)
  To: 70680; +Cc: Katherine Cox-Buday

---
 gnu/packages/golang.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 4ce6f5ea6b..99d83dd104 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -12,7 +12,7 @@
 ;;; Copyright © 2018 Tomáš Čech <sleep_walker@gnu.org>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
 ;;; Copyright © 2018 Pierre Neidhardt <mail@ambrevar.xyz>
-;;; Copyright © 2018, 2019, 2020, 2023 Katherine Cox-Buday <cox.katherine.e@gmail.com>
+;;; Copyright © 2018, 2019, 2020, 2023, 2024 Katherine Cox-Buday <cox.katherine.e@gmail.com>
 ;;; Copyright © 2019 Giovanni Biscuolo <g@xelera.eu>
 ;;; Copyright © 2019, 2020 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2019, 2020, 2021 Arun Isaac <arunisaac@systemreboot.net>
@@ -971,7 +971,13 @@ (define-public go-1.22
                 ;; to perl input in sourcecode generators and test scripts
                 (substitute* (find-files "src" "\\.pl$")
                   (("^#!.*")
-                   "#!/usr/bin/env perl\n"))))))))
+                   "#!/usr/bin/env perl\n"))))
+            (add-after 'unpack 'remove-flakey-thread-sanitizer-tests
+              (lambda _
+                ;; These tests have been identified as flakey:
+                ;; https://github.com/golang/go/issues/66427
+                (substitute* "src/cmd/cgo/internal/testsanitizers/tsan_test.go"
+                  ((".*tsan1[34].*") ""))))))))
     (native-inputs
      ;; Go 1.22 and later requires Go 1.20 (min. 1.20.6, which we don't have)
      ;; as the bootstrap toolchain.

base-commit: 8dab3df9529387ec1459d5483ac9664969c52e78
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#70680: [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests.
  2024-04-30 17:54 [bug#70680] [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests Katherine Cox-Buday
@ 2024-05-14 10:50 ` Sharlatan Hellseher
  0 siblings, 0 replies; 2+ messages in thread
From: Sharlatan Hellseher @ 2024-05-14 10:50 UTC (permalink / raw)
  To: 70680-done

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]


Pushed as 6fab2d5b318fb0a8a0887f6ce0ac3e342a8c23ef to go-team.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-14 10:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 17:54 [bug#70680] [PATCH 1/1] * gnu/packages/golang.scm (go-1.22): Disable flakey tests Katherine Cox-Buday
2024-05-14 10:50 ` bug#70680: " Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).