unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: Wilko Meyer <w@wmeyer.eu>, 70869@debbugs.gnu.org
Cc: Wilko Meyer <w@wmeyer.eu>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#70869] [PATCH] gnu: Add emacs-casual-dired.
Date: Thu, 30 May 2024 23:35:10 +0200	[thread overview]
Message-ID: <878qzrc7ap.fsf@ngraves.fr> (raw)
In-Reply-To: <35b2207e2fd04676a2cc94e53571f6184a76e89d.1715385956.git.w@wmeyer.eu>

Hi Wilko,

guix lint complains about two warnings :

> gnu/packages/emacs-xyz.scm:32831:5: emacs-casual-dired@20240509.108: the
> source file name should contain the package name

Here you have to add
       (file-name (git-file-name name version))
after the uri field for it to stop complaining.

> gnu/packages/emacs-xyz.scm:32831:5: emacs-casual-dired@20240509.108:
> permanent redirect from https://github.com/kickingvegas/casual-dired.git
> to https://github.com/kickingvegas/casual-dired

Here you can remove the .git suffix at the end of the url.

Moreover, there are releases on the github page available as tags, we
should probably rely on these rather than the melpa version you
provided, unless we have good reasons to do otherwise.

Can you make these changes and resend a patch? Thanks!

-- 
Best regards,
Nicolas Graves




  reply	other threads:[~2024-05-30 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11  0:05 [bug#70869] [PATCH] gnu: Add emacs-casual-dired Wilko Meyer
2024-05-30 21:35 ` Nicolas Graves via Guix-patches via [this message]
2024-06-06 19:22 ` [bug#70869] [PATCH v2] " Wilko Meyer
2024-06-13 20:48   ` bug#70869: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qzrc7ap.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=70869@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=ngraves@ngraves.fr \
    --cc=w@wmeyer.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).