From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6LBJMVWijGYzDwAAe85BDQ:P1 (envelope-from ) for ; Tue, 09 Jul 2024 02:37:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6LBJMVWijGYzDwAAe85BDQ (envelope-from ) for ; Tue, 09 Jul 2024 04:37:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CAK3OKkl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720492629; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IYyiYXQX8nAHVkzBbjRW0G8ZZC2H7UE1BpZsTMJDIkM=; b=A2tm/ZMh1EsZ2RMVHk16xzvYDUsea6bfkim4R67zJ53bEumk8OTUfazIeYHa3m3k0ro1+7 RfYr+1V1Q4MWBoztvKfHPWtkx/YcPyldUS5oViFR/cT044CSROY+62Zu7PVLTWzwgxAVd5 CIHXmyTKQXmBSqIKVm+jZrTzWCLwrGIGIzua75KtSW/cwwZzXy/kcOgcKXO10doq1bZwlQ AzAP36Jf2LIXq6SLvuThBsx0ZIgxNuKjqe8zofhqg3U2j5AK4tKmv83L1Zec/7wfASmjaS RQBx4tSBI5a6jRuxDvgK0Wcs/EXjBwEz7Gw8DuBKvwSNSjsBOOrs977dqh23cg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720492629; a=rsa-sha256; cv=none; b=hBjT6YpsK1jhb9EmtbbYsQNfjXrNDz5d8uE3mj0RXNZ2B3oR3ggydv7cYUt/wHiUGLNWMg Xb3m+S//HuBjDKkfTi1IzdqVqIVW1c4wgxzrcEtVGLe4rC3JQKZX1pZlNuCm3/7tFOTb4P yGfJh16B03KY4WjeOqfdD/tW9lQ3nWR/K+jUAawpHoVsbK84OPeUH6s0sPn0qEi/YvjYAF jZ1fXv+0J/bOlY4s8UgFuWZ3LXHf7Q9joMzVhQPU0RttmgJOVuWMyq+dljPeKWuQWa874r +r5auCm3adpJpR2Aq68b6ul8sJntx614GbRwl3g4FguYh6S74dVWuotVSqyFmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CAK3OKkl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 890F5D734 for ; Tue, 09 Jul 2024 04:37:09 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR0j1-0003E2-9I; Mon, 08 Jul 2024 22:37:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR0iv-0003D6-Iv for guix-patches@gnu.org; Mon, 08 Jul 2024 22:36:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sR0iv-00022E-Av for guix-patches@gnu.org; Mon, 08 Jul 2024 22:36:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sR0j0-0002oX-GV for guix-patches@gnu.org; Mon, 08 Jul 2024 22:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH 5/5] gnu: telegram-desktop: Update to 5.2.3. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jul 2024 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: Liliana Marie Prikler , 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172049259610782 (code B ref 71897); Tue, 09 Jul 2024 02:37:02 +0000 Received: (at 71897) by debbugs.gnu.org; 9 Jul 2024 02:36:36 +0000 Received: from localhost ([127.0.0.1]:51759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR0ia-0002nq-97 for submit@debbugs.gnu.org; Mon, 08 Jul 2024 22:36:36 -0400 Received: from mail-vk1-f175.google.com ([209.85.221.175]:60798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sR0iX-0002nZ-R7 for 71897@debbugs.gnu.org; Mon, 08 Jul 2024 22:36:34 -0400 Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4f2e1093abeso1759532e0c.1 for <71897@debbugs.gnu.org>; Mon, 08 Jul 2024 19:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720492523; x=1721097323; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IYyiYXQX8nAHVkzBbjRW0G8ZZC2H7UE1BpZsTMJDIkM=; b=CAK3OKkln0nEGGMKzhVqNg1ndbBZvaxW+JkGZHThrH7l3I4sSX5RUsOyyTNwqcpOVL AROzCODkGVXbmLAIedRkgG+KsafaGtKVo0zeORrKCoLhmDReBzEjcxoUEOoXZaqh7Tg/ W5e6mkWfHVRNp6BWOryHnijZqNoBzxtafkNToD+dvbsOtnaG+wuHidj8dzjKEqXq8UWc 6LNjukPvL9LOjEOBggu2Nget4XaN4gV5MSd4NNY1BdhdnRhthObWITwLNT+Q/BzH0lfA kzRcd27/4qhFV7oUVDp4MHVSsBlS/mJVcmSd5ZrTiSV1ov5ZwAgWX9SrUx4CsW/9+ZKQ f7zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720492523; x=1721097323; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IYyiYXQX8nAHVkzBbjRW0G8ZZC2H7UE1BpZsTMJDIkM=; b=PMsN4B8RmrAKR6ASIATY6vjuLgQ70u/Vv2/mkL/Jf0BAVmkdOV5aam5/Sp05vSkT/Z 8K2jHAr/BOEeKdOTD5WwwOeqvMCBLm2I/UmeKBRAg4IEv4UtENhywC4FiAFaXN0ZOKAs B9xLi+byVQc8pZNimgv+GBvasicRmsBTDwiBjt284svMbw2enXgFZ6W1jppY7It9+GSS iyGa4xaYrpkONJzLwvco9JnrWk+QqZIu86lycLpadb0ZIpPm7V+dAekDJwIcg9Vdu61y 8lpX8W5gwER8DmF6+IuQEHYgfVbr6LrEpQIUHixeTYT8ICgo00O1zD68FTsy6krQhrD0 fFFQ== X-Gm-Message-State: AOJu0YxSLxeckhgocIKUt/+MaLkLmqLAqH0yE6MeX61hOYrfVJQYaLTP w7Z6vPtDmrA4tbCLr7EXzHUb63jijX6DLUOu7sDODTymZ8TZ61D0 X-Google-Smtp-Source: AGHT+IH/LK7mywQoL65JKdd9clS8JDSxRwVZnyLaMWY9dUibsgzAS8VnaHOhhAnqOaWf1Z8mS3uSWw== X-Received: by 2002:a05:6122:910:b0:4f2:ebd9:8e12 with SMTP id 71dfb90a1353d-4f33f24fa48mr1725088e0c.5.1720492522793; Mon, 08 Jul 2024 19:35:22 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79f19087260sm50483085a.73.2024.07.08.19.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 19:35:22 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (dan's message of "Sun, 7 Jul 2024 23:00:24 +0800") References: <3743fa793bf867b8112b2883815b573f955c12ce.1720364199.git.i@dan.games> Date: Mon, 08 Jul 2024 22:35:21 -0400 Message-ID: <878qybxpg6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.29 X-Spam-Score: -2.29 X-Migadu-Queue-Id: 890F5D734 X-Migadu-Scanner: mx11.migadu.com X-TUID: WX2DThH1D/ao Hello! dan writes: > * gnu/packages/patches/telegram-desktop-unbundle-cppgir.patch: New file. > * gnu/packages/patches/telegram-desktop-unbundle-gsl.patch: New file. > * gnu/local.mk (dist_patch_DATA): register them. Nitpick: "Register", capitalized. > * gnu/packages/telegram.scm: > (libyuv-for-telegram-desktop, cmake-helpers-for-telegram-desktop, > codegen-for-telegram-desktop, lib-base-for-telegram-desktop, > lib-crl-for-telegram-desktop, lib-lottie-for-telegram-desktop, > lib-qr-for-telegram-desktop, lib-storage-for-telegram-desktop, > lib-tl-for-telegram-desktop, lib-webrtc-for-telegram-desktop, > tgcalls-for-telegram-desktop, webrtc-for-telegram-desktop): Bump to submodule > checkout. > (cmake-helpers-for-telegram-desktop)[origin]: Add patches to unbundle gsl and > cppgir. > (libprisma-for-telegram-desktop): Use %telegram-version. > (telegram-desktop): Update to 5.2.3. > [#:phases]: Add libprisma-for-telegram-desktop. > : New phase. > : New phase. > [native-inputs]: Add xdg-desktop-portal. Nitpick: GNU ChangeLog doesn't uses hanging indents. > [inputs]: Add boost, cppgir-for-telegram-desktop, expected-lite and > gobject-introspection. [...] > diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm [...] > -(define %telegram-version "4.8.1") > +(define %telegram-version "5.2.3") [...] > (search-patches > ;; https://github.com/telegramdesktop/tdesktop/pull/24126 > @@ -522,7 +530,20 @@ (define-public telegram-desktop > ("Telegram/lib_webrtc" #$lib-webrtc-for-telegram-desktop) > ("Telegram/lib_webview" #$lib-webview-for-telegram-desktop) > ("Telegram/ThirdParty/cld3" #$cld3-for-telegram-desktop) > + ("Telegram/ThirdParty/libprisma" #$libprisma-for-telegram-desktop) > ("Telegram/ThirdParty/tgcalls" #$tgcalls-for-telegram-desktop))))) > + (add-after 'unpack-additional-sources 'patch-gir-ignore-paths > + (lambda _ > + (substitute* "cmake/external/glib/generate_cppgir.cmake" > + (("\\$\\{cmake_helpers_loc\\}/external/glib/cppgir/data") > + (string-append #$(this-package-input "cppgir") "/share/cppgir"))))) > + (add-after 'unpack-additional-sources 'use-system-xdg-desktop-portal > + (lambda _ > + (substitute* (list "Telegram/CMakeLists.txt" > + "Telegram/lib_base/CMakeLists.txt") > + (("\\$\\{third_party_loc\\}/xdg-desktop-portal/data") > + (string-append #$(this-package-native-input "xdg-desktop-portal") > + "/share/dbus-1/interfaces"))))) > (add-after 'install 'glib-or-gtk-compile-schemas > (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) > (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap > @@ -531,17 +552,22 @@ (define-public telegram-desktop > (list `(,glib "bin") > `(,gtk+ "bin") > pkg-config > - python-wrapper)) > + python-wrapper > + xdg-desktop-portal)) > (inputs > (list abseil-cpp-cxxstd17 > alsa-lib > + boost > c++-gsl > crc32c > + cppgir-for-telegram-desktop Nitpick: should be listed alphabetically before the crc32c input. > + expected-lite > fcitx-qt5 > fcitx5-qt > ffmpeg > glib > glibmm-2.76 > + gobject-introspection > gtk+ > hime > hunspell Otherwise LGTM! Feel free to adjust the little things above in a v5. -- Thanks, Maxim