[bug#72398] [PATCH v2] services: Add readymedia-service-type.

[Fabio Natali via Guix-patches via <guix-patches@gnu.org>]

Hi Arun, Bruno,

On 2024-08-28, 23:51 +0100, Arun Isaac <arunisaac@systemreboot.net> wrote:
> You're right about this problem. It's been discussed here as well:
> https://issues.guix.gnu.org/67288 But, like I mention there, I am
> worried that adding configurable user and group fields to every
> service isn't very composable. Ideally, we'd want to have a separate
> "add-user-to-group" service that can modify configured users to have
> more groups. Such a solution may be more composable. WDYT?

As far as I understand, a separate `add-user-to-group' service seems
like a good general way of addressing this - although outside the scope
of this patch. As a stopgap solution, I'd be glad to add a
`supplementary-groups' field a la #67288 - do you think that might work
in this context? Or we could keep the service as it is (v5) until a
`add-user-to-group' service is in place?

> Another solution could be to add a "mappings" field that specifies
> additional directories to map into the container. I do this in some
> services in
> guix-forge. https://guix-forge.systemreboot.net/manual/dev/en/#item27237

Hm, I'm sure I'm missing something here, but isn't this what the patch
does already with the "media-directories" field?

--8<---------------cut here---------------start------------->8---
(readymedia (least-authority-wrapper
             (file-append
              (readymedia-configuration-readymedia config)
              "/sbin/minidlnad")
             #:name "minidlna"
             #:mappings
             (cons*
                    ...
                    (map
                     (lambda (e)
                       (file-system-mapping
                        (source (readymedia-media-directory-path e))
                        (target source)
                        (writable? #f)))
                     media-directories))
             #:namespaces (delq 'net %namespaces))))
             ...
--8<---------------cut here---------------end--------------->8---

Thanks, cheers, F.