unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alec Barreto <mrh57@posteo.net>
To: 72452 <72452@debbugs.gnu.org>, Nicolas Graves <ngraves@ngraves.fr>
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#72452] [PATCH v5] gnu: Add guile-swayer.
Date: Sat, 14 Sep 2024 18:23:17 +0000	[thread overview]
Message-ID: <878qvup016.fsf@posteo.net> (raw)
In-Reply-To: <87v7yyteq6.fsf@ngraves.fr> (Nicolas Graves's message of "Sat, 14 Sep 2024 17:52:17 +0200")

Nicolas Graves <ngraves@ngraves.fr> writes:

> If you want to pick a specific commit, you can do something like this
>
>   (let ((commit [commit])
>         (version "0.2.0")
>         (revision "0"))
>     (package
>       (name [name])
>       (version (git-version version revision commit))
>       (source (origin
>                 (method git-fetch)
>                 (uri (git-reference
>                        (url [url])
>                        (commit commit)))
>                 (file-name (git-file-name name version))
>                 (sha256
>                  (base32
>                   ""))))
>
>
> This makes it easier to upgrade to another given commit if necessary.

Thanks!
Funnily v0.3.0 was just released right after your message.
However it introduces a new (minor) issue.

There is a =manifest.scm= file in the project root which was for
building the program with guix since it wasn't (isn't) yet upstream. 
But now with the new 0.3.0 version the =guile-build-system= tries to
compile the =manifest.scm= as part of the program, causing build
failure.

The project itself could create a =make= file and the package definiton
could be switched to =gnu-build-system=.

Alternatively, since the manifest is arguably obsolete if this package
becomes upstreamed, the manifest can simply be removed.

We can wait for one of those situations, or just package it now in the
manner you suggested and pin the commit to where the package builds
(but still updating to  v0.3.0?)

Best,
Alec




  reply	other threads:[~2024-09-14 18:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 20:31 [bug#72452] [PATCH] add guile-swayer package mrh
2024-09-07 16:15 ` Nicolas Graves via Guix-patches via
2024-09-07 18:17   ` mrh57
2024-09-07 18:28 ` [bug#72452] [PATCH v2] gnu: add guile-swayer mrh
2024-09-09  4:46 ` [bug#72452] [PATCH] add guile-swayer package Nicolas Graves via Guix-patches via
2024-09-09 16:21   ` mrh57
2024-09-10  8:14     ` Nicolas Graves via Guix-patches via
2024-09-09 16:24 ` [bug#72452] [PATCH v3] gnu: add guile-swayer Alec Barreto
2024-09-10 12:08 ` [bug#72452] [PATCH v4] " Alec Barreto
2024-09-10 12:13 ` [bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package mrh57
2024-09-11 15:10   ` Nicolas Graves via Guix-patches via
2024-09-11 22:25     ` Alec Barreto
2024-09-10 17:23 ` [bug#72452] QA review for 72452 Nicolas Graves via Guix-patches via
2024-09-11 22:27 ` [bug#72452] [PATCH v5] gnu: Add guile-swayer Alec Barreto
2024-09-12 17:12   ` Ludovic Courtès
2024-09-13 12:03     ` Alec Barreto
2024-09-14 14:18       ` Alec Barreto
2024-09-14 15:52         ` Nicolas Graves via Guix-patches via
2024-09-14 18:23           ` Alec Barreto [this message]
2024-09-16 19:49             ` Nicolas Graves via Guix-patches via
2024-09-17  0:51               ` Alec Barreto
2024-09-17  0:54 ` [bug#72452] [PATCH v6] " Alec Barreto
2024-09-19 10:47   ` bug#72452: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qvup016.fsf@posteo.net \
    --to=mrh57@posteo.net \
    --cc=72452@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).