* [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
@ 2024-10-01 17:20 Cayetano Santos via Guix-patches via
2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via
2024-10-15 8:10 ` [bug#73583] [PATCH v1] " Cayetano Santos via Guix-patches via
0 siblings, 2 replies; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2024-10-01 17:20 UTC (permalink / raw)
To: 73583; +Cc: Cayetano Santos
* gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.
---
gnu/packages/emacs-xyz.scm | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e9ecbea48..6c4739e8c0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26160,11 +26160,11 @@ (define-public emacs-discover-my-major
(license license:gpl3+)))
(define-public emacs-org-ref
- (let ((commit "bb375f366f883e5b60e3bb625f2acd026811fb55")
+ (let ((commit "732a20bd236fd02db4a651da29f87f87f458a54a")
(revision "0"))
(package
(name "emacs-org-ref")
- (version (git-version "3.0" revision commit))
+ (version (git-version "3.1" revision commit))
(source
(origin
(method git-fetch)
@@ -26174,29 +26174,27 @@ (define-public emacs-org-ref
(file-name (git-file-name name version))
(sha256
(base32
- "01wxcyzdrx6ysv9rjd64fr7kkvm4fjr03ib4mmpchraxxm8g8z43"))))
+ "1kbjxz56fvln6drd2wqdxrpgwjshzpdbyaq7dz0gn285z93y1knk"))))
(build-system emacs-build-system)
(arguments
(list
#:include #~(cons* "org-ref.org" "org-ref.bib" %default-include)
#:exclude #~(list
- ;; github.com/jkitchin/org-ref/issues/1085
- "openalex.el"
;; author doesn't recommend using it
"org-ref-pdf.el")))
(propagated-inputs
- (list emacs-avy
- emacs-citeproc-el
- emacs-dash
- emacs-f
- emacs-helm
- emacs-helm-bibtex
- emacs-htmlize
- emacs-hydra
- emacs-ivy
- emacs-ox-pandoc
- emacs-parsebib
- emacs-s))
+ (list
+ emacs-dash
+ emacs-s
+ emacs-f
+ emacs-htmlize
+ emacs-hydra
+ emacs-avy
+ emacs-parsebib
+ emacs-helm-bibtex
+ emacs-citeproc-el
+ emacs-ox-pandoc
+ emacs-request))
(home-page "https://github.com/jkitchin/org-ref")
(synopsis "Citations, cross-references and bibliographies in Org mode")
(description
base-commit: 71fef00c95b22a1d917abdb28de5aa217b023e31
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
2024-10-01 17:20 [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b Cayetano Santos via Guix-patches via
@ 2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via
2024-10-15 8:16 ` Cayetano Santos via Guix-patches via
2024-10-15 8:10 ` [bug#73583] [PATCH v1] " Cayetano Santos via Guix-patches via
1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-10-15 6:41 UTC (permalink / raw)
To: 73583; +Cc: csantosb
Hello,
Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.
Thank you. Some comments follow.
> #:exclude #~(list
> - ;; github.com/jkitchin/org-ref/issues/1085
> - "openalex.el"
Why are you removing these lines? There is no mention about it in your
commit message.
> ;; author doesn't recommend using it
> "org-ref-pdf.el")))
> (propagated-inputs
> - (list emacs-avy
> - emacs-citeproc-el
> - emacs-dash
> - emacs-f
> - emacs-helm
> - emacs-helm-bibtex
> - emacs-htmlize
> - emacs-hydra
> - emacs-ivy
> - emacs-ox-pandoc
> - emacs-parsebib
> - emacs-s))
> + (list
> + emacs-dash
> + emacs-s
> + emacs-f
> + emacs-htmlize
> + emacs-hydra
> + emacs-avy
> + emacs-parsebib
> + emacs-helm-bibtex
> + emacs-citeproc-el
> + emacs-ox-pandoc
> + emacs-request))
I don't understand the purpose of this change either. You're breaking
alphabetic order and use a dubious indentation.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#73583] [PATCH v1] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
2024-10-01 17:20 [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b Cayetano Santos via Guix-patches via
2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via
@ 2024-10-15 8:10 ` Cayetano Santos via Guix-patches via
1 sibling, 0 replies; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2024-10-15 8:10 UTC (permalink / raw)
To: 73583; +Cc: Cayetano Santos
* gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.
Change-Id: I04f4cb9ffacaaf25a3e844c8e1d1b194e41d90a9
---
Update to 3.1-0.732a20b.
The reason to exclude openalex.el from this package doesn't hold anymore, see github.com/jkitchin/org-ref/issues/1085.
Emacs-helm is already pulled from emacs-helm-bibtex, no need to do it here.
Emacs-request is a new hard dependency. Emacs-ivy is not.
gnu/packages/emacs-xyz.scm | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e9ecbea48..ed1618fd4d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26160,11 +26160,11 @@ (define-public emacs-discover-my-major
(license license:gpl3+)))
(define-public emacs-org-ref
- (let ((commit "bb375f366f883e5b60e3bb625f2acd026811fb55")
+ (let ((commit "732a20bd236fd02db4a651da29f87f87f458a54a")
(revision "0"))
(package
(name "emacs-org-ref")
- (version (git-version "3.0" revision commit))
+ (version (git-version "3.1" revision commit))
(source
(origin
(method git-fetch)
@@ -26174,14 +26174,12 @@ (define-public emacs-org-ref
(file-name (git-file-name name version))
(sha256
(base32
- "01wxcyzdrx6ysv9rjd64fr7kkvm4fjr03ib4mmpchraxxm8g8z43"))))
+ "1kbjxz56fvln6drd2wqdxrpgwjshzpdbyaq7dz0gn285z93y1knk"))))
(build-system emacs-build-system)
(arguments
(list
#:include #~(cons* "org-ref.org" "org-ref.bib" %default-include)
#:exclude #~(list
- ;; github.com/jkitchin/org-ref/issues/1085
- "openalex.el"
;; author doesn't recommend using it
"org-ref-pdf.el")))
(propagated-inputs
@@ -26189,14 +26187,12 @@ (define-public emacs-org-ref
emacs-citeproc-el
emacs-dash
emacs-f
- emacs-helm
emacs-helm-bibtex
emacs-htmlize
emacs-hydra
- emacs-ivy
emacs-ox-pandoc
emacs-parsebib
+ emacs-request
emacs-s))
(home-page "https://github.com/jkitchin/org-ref")
(synopsis "Citations, cross-references and bibliographies in Org mode")
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via
@ 2024-10-15 8:16 ` Cayetano Santos via Guix-patches via
0 siblings, 0 replies; 4+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2024-10-15 8:16 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 73583
>mar. 15 oct. 2024 at 08:41, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Why are you removing these lines? There is no mention about it in your
> commit message.
The reason to exclude this file doesn’t hold anymore, see
github.com/jkitchin/org-ref/issues/1085.
> I don't understand the purpose of this change either. You're breaking
> alphabetic order and use a dubious indentation.
Sorry for that. I submitted a v1 patch with corrections and text.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-15 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 17:20 [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b Cayetano Santos via Guix-patches via
2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via
2024-10-15 8:16 ` Cayetano Santos via Guix-patches via
2024-10-15 8:10 ` [bug#73583] [PATCH v1] " Cayetano Santos via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).