From: "Ludovic Courtès" <ludo@gnu.org>
To: Florian Pelz <pelzflorian@pelzflorian.de>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
74190@debbugs.gnu.org, Josselin Poiret <dev@jpoiret.xyz>
Subject: [bug#74190] [PATCH 2/3] install: Change the territory when we have learned it.
Date: Sun, 17 Nov 2024 18:08:59 +0100 [thread overview]
Message-ID: <878qthkct0.fsf@gnu.org> (raw)
In-Reply-To: <1e50d2858a80c891f3b7fa377e5b876c475f9e92.1730645617.git.pelzflorian@pelzflorian.de> (Florian Pelz's message of "Sun, 3 Nov 2024 16:25:42 +0100")
Florian Pelz <pelzflorian@pelzflorian.de> skribis:
> Typically, the LANGUAGE has already been set in the run-language-page
> step. But for languages like pt, we must know the territory.
>
> gnu/installer/newt/locale.scm (run-territory-page): Switch to
^
Missing bullet (star).
> the territory before returning it.
Instead of “Switch to…”, I’d write “Call ‘setenv’ for the ‘LANGUAGE’
variable.”
> (define (run-territory-page territories territory->text)
> - (let ((title (G_ "Locale location")))
> + (define result
> (run-listbox-selection-page
> - #:title title
> + #:title (G_ "Locale location")
> #:info-text (G_ "Choose a territory for this language.")
> #:listbox-items territories
> #:listbox-item->text territory->text
> #:button-text (G_ "Back")
> #:button-callback-procedure
> (lambda _
> - (abort-to-prompt 'installer-step 'abort)))))
> + (abort-to-prompt 'installer-step 'abort))))
> +
> + ;; Some languages, such as pt, cannot be installed early in the
> + ;; run-language-page step. Install them now, when we know the territory.
> + (setenv "LANGUAGE" (string-append (getenv "LANGUAGE") "_" result))
Does that have an effect though: isn’t the Info reader already running
at this point?
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-11-17 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 15:14 [bug#74190] [PATCH 0/3] install: Enable pt_BR translation Florian Pelz
2024-11-03 15:25 ` [bug#74190] [PATCH 1/3] install: Open info manuals that have region codes Florian Pelz
2024-11-17 17:06 ` Ludovic Courtès
2024-11-03 15:25 ` [bug#74190] [PATCH 2/3] install: Change the territory when we have learned it Florian Pelz
2024-11-17 17:08 ` Ludovic Courtès [this message]
2024-11-03 15:25 ` [bug#74190] [PATCH 3/3] gnu: info-reader: Inherit from texinfo-7 Florian Pelz
2024-11-17 17:10 ` Ludovic Courtès
2024-11-03 20:37 ` [bug#74190] [PATCH 0/3] install: Enable pt_BR translation Krascovict Petrov
2024-11-04 7:52 ` pelzflorian (Florian Pelz)
2024-11-04 22:08 ` Krascovict Petrov
2024-11-05 8:59 ` pelzflorian (Florian Pelz)
2024-11-17 23:47 ` [bug#74190] [PATCH v2 0/3] install: Enable pt_BR locale Florian Pelz
2024-11-17 23:48 ` [bug#74190] [PATCH v2 1/3] install: Open info manuals that have region codes Florian Pelz
2024-11-17 23:48 ` [bug#74190] [PATCH v2 2/3] install: Change the territory when we have learned it Florian Pelz
2024-11-18 10:26 ` pelzflorian (Florian Pelz)
2024-11-20 12:07 ` Ludovic Courtès
2024-11-17 23:49 ` [bug#74190] [PATCH v2 3/3] gnu: info-reader: Inherit from texinfo-7 Florian Pelz
2024-11-20 12:08 ` [bug#74190] [PATCH v2 0/3] install: Enable pt_BR locale Ludovic Courtès
2024-11-20 17:27 ` bug#74190: " pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qthkct0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=74190@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=othacehe@gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).