unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news
@ 2024-12-09 20:25 Vagrant Cascadian
  2024-12-24 14:41 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Vagrant Cascadian @ 2024-12-09 20:25 UTC (permalink / raw)
  To: 74755; +Cc: vagrant


[-- Attachment #1.1: Type: text/plain, Size: 187 bytes --]

Running check-channel-news before authenticating the repository could
result in running unauthenticated code; the attached patch switches the
order they are run in.

live well,
  vagrant

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-etc-git-pre-push-Run-guix-git-authenticate-before-ch.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]

From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Mon, 9 Dec 2024 12:21:30 -0800
Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before
 check-channel-news.

Running check-channel-news first could potentially be untrusted code, so
authenticate first.

* etc/git/pre-push: Run guix git authenticate before check-channel-news.
---
 etc/git/pre-push | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 325b23854b..752310d854 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -33,8 +33,8 @@ do
 		case "$2" in
 		    *.gnu.org*)
 			set -e
-			make check-channel-news
 			exec guix git authenticate
+			make check-channel-news
 			exit 127
 			;;
 		    *)

base-commit: da3c8a963f83c044568d99921480259eaa26a923
-- 
2.39.5


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-24 15:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 20:25 [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news Vagrant Cascadian
2024-12-24 14:41 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).