From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Ahriman <ahriman@fedora.email>, 57497@debbugs.gnu.org
Subject: [bug#57497] [PATCH] gnu: Add blueprint-compiler
Date: Wed, 31 Aug 2022 16:42:30 +0200 [thread overview]
Message-ID: <878c1ee207437937208735200d75371ca2022ee9.camel@gmail.com> (raw)
In-Reply-To: <20220831032115.3838-1-ahriman@fedora.email>
Hi Ahriman,
Am Mittwoch, dem 31.08.2022 um 04:21 +0100 schrieb Ahriman:
> ---
> gnu/packages/blueprint-compiler.scm | 35
Missing a ChangeLog. Also, you don't need an extra file, insert it
into gnome.scm after glade.
> +++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 gnu/packages/blueprint-compiler.scm
>
> diff --git a/gnu/packages/blueprint-compiler.scm
> b/gnu/packages/blueprint-compiler.scm
> new file mode 100644
> index 0000000000..299f0b3635
> --- /dev/null
> +++ b/gnu/packages/blueprint-compiler.scm
> @@ -0,0 +1,35 @@
> +(define-module (gnu packages blueprint-compiler)
> + #:use-module (guix packages)
> + #:use-module (guix licenses)
> + #:use-module (guix download)
> + #:use-module (gnu packages python)
> + #:use-module (gnu packages glib)
> + #:use-module (guix build-system meson))
> +
> +(define-public blueprint-compiler
> + (package
> + (name "blueprint-compiler")
> + (version "0.2.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> +
> "https://gitlab.gnome.org/jwestman/blueprint-compiler/-/archive/v"
> + version
> + "/blueprint-compiler-v"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> +
> "10qd9bax2n83n0pmmsbb55rjdsm7g5pvj2lxh460dl78jm649rfl"))))
git-fetch exists, use it.
> + (build-system meson-build-system)
> + (arguments `(#:tests? #f))
Tests are not meant to be ignored.
> + (native-inputs (list gobject-introspection))
> + (inputs (list python))
I'm pretty sure you're missing inputs. On my local stash, I have at
least glib, gtk, and python-pygobject, but even with those I have yet
to get the tests running.
> + (synopsis "Markup language compiler for GTK user interface files")
I'd suggest shortening this to "Template markup language"
> + (description
> + "This package provides the compiler for the blueprint markup
> language for
> +GTK user interfaces")
"Blueprint is a markup language for GTK user interfaces.
Internally, it compiles to GTKBuilder XML."
> + (home-page
> "https://gitlab.gnome.org/jwestman/blueprint-compiler")
> + (license gpl3+)))
Are you sure it's not LGPL?
> +blueprint-compiler
You don't need trailing variables.
Cheers
next prev parent reply other threads:[~2022-08-31 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 3:21 [bug#57497] [PATCH] gnu: Add blueprint-compiler Ahriman via Guix-patches via
2022-08-31 14:42 ` Liliana Marie Prikler [this message]
2022-08-31 18:18 ` Ahriman via Guix-patches via
2022-09-06 14:46 ` bug#57497: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878c1ee207437937208735200d75371ca2022ee9.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=57497@debbugs.gnu.org \
--cc=ahriman@fedora.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).