From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cssj7-0008Hi-UY
	for guix-patches@gnu.org; Tue, 28 Mar 2017 11:08:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cssj4-0006wc-44
	for guix-patches@gnu.org; Tue, 28 Mar 2017 11:08:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51275)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cssj4-0006wW-0p
	for guix-patches@gnu.org; Tue, 28 Mar 2017 11:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cssj3-0002iv-S1
	for guix-patches@gnu.org; Tue, 28 Mar 2017 11:08:01 -0400
Subject: bug#26265: [PATCH 1/1] packages: Add optional `for-ui` param to
	`package-full-name`.
Resent-Message-ID: <handler.26265.B26265.149071363410409@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170326122555.22366-1-alex@pompo.co>
	<20170326122555.22366-2-alex@pompo.co>
Date: Tue, 28 Mar 2017 17:06:51 +0200
In-Reply-To: <20170326122555.22366-2-alex@pompo.co> (Alex Sassmannshausen's
	message of "Sun, 26 Mar 2017 14:25:55 +0200")
Message-ID: <877f3930fo.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
Cc: 26265@debbugs.gnu.org, Alex Sassmannshausen <alex@pompo.co>

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> * guix/packages.scm (package-full-name): Add optional parameter `for-ui`.
> * guix/scripts/refresh.scm (list-dependents): Use it.
> * tests/packages.scm: Add tests for `package-full-name`.

[...]

> +(define* (package-full-name package #:optional for-ui)
> +  "Return the full name of PACKAGE--i.e., `NAME-VERSION'.  If FOR-UI? is=
 #t,
> +return the full name of PACKAGE using \"@\" as the NAME, VERSION separat=
or."

I=E2=80=99d replace =E2=80=98for-ui=E2=80=99 with:

  #:optional (separator "@")

I think it=E2=80=99s less ambiguous.

That also means that we=E2=80=99d need to change *non*-UI call sites, inste=
ad of
changing UI call sites.  Hopefully there are few of them, but as
discussed in the other message, it takes manual analysis to determine
which use requires a hyphen and which one does not.

Thanks,
Ludo=E2=80=99.