unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26676-done@debbugs.gnu.org
Subject: bug#26676: [PATCH] gnu: Add xerces-c.
Date: Fri, 28 Apr 2017 17:48:15 +0200	[thread overview]
Message-ID: <877f24y1mo.fsf@elephly.net> (raw)
In-Reply-To: <87h91ac730.fsf@fastmail.com>


Marius Bakke <mbakke@fastmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/xml.scm (xerces-c): New variable.
>
> [...]
>
>> +(define-public xerces-c
>> +  (package
>> +    (name "xerces-c")
>> +    (version "3.1.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://apache/xerces/c/3/sources/"
>> +                                  "xerces-c-" version ".tar.xz"))
>> +              (sha256
>> +               (base32
>> +                "0hb29c0smqlpxj0zdm09s983z5jx37szlliccnvgh0qq91wwqwwr"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:configure-flags (list "--disable-sse2")))
>
> SSE2 is part of the AMD64 specification[0], so enabling it for x86_64
> would be slightly nicer. Other than that looks good!
>
> [0] https://en.wikipedia.org/wiki/SSE2#CPU_support

Ah, you’re right.  I pushed it with a fix with commit 162a4a032^.
Thanks for the review!

--
Ricardo

  GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
  https://elephly.net

      reply	other threads:[~2017-04-28 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  6:52 bug#26676: [PATCH] gnu: Add xerces-c Ricardo Wurmus
2017-04-27 13:29 ` Marius Bakke
2017-04-28 15:48   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f24y1mo.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=26676-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).