From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8QBv-0000ad-DN for guix-patches@gnu.org; Wed, 10 May 2017 07:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8QBu-00031E-Ad for guix-patches@gnu.org; Wed, 10 May 2017 07:54:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8QBu-00030x-72 for guix-patches@gnu.org; Wed, 10 May 2017 07:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8QBt-0005j1-TM for guix-patches@gnu.org; Wed, 10 May 2017 07:54:01 -0400 Subject: bug#26805: [PATCH] gs-fonts: add missing podule imports Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170506154035.23664-1-slyfox@inbox.ru> <87pofi8h6p.fsf@gnu.org> <20170509213630.7c81b553@sf> Date: Wed, 10 May 2017 13:53:41 +0200 In-Reply-To: <20170509213630.7c81b553@sf> (Sergei Trofimovich's message of "Tue, 9 May 2017 21:36:30 +0100") Message-ID: <877f1pvsfu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Sergei Trofimovich Cc: 26805@debbugs.gnu.org Sergei Trofimovich skribis: > On Tue, 09 May 2017 12:20:46 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Hello! >>=20 >> Sergei Trofimovich skribis: >>=20 >> > On code-updates branch 'gs-fonts' build fails as: >> > >> > ice-9/psyntax.scm:1534:32: In procedure expand-macro: >> > ice-9/psyntax.scm:1534:32: Syntax error: >> > ...-gs-fonts-8.11-guile-builder:1:2300: source expression failed to ma= tch >> > any pattern in form (%modify-phases phases* (delete (quote configure))) >> > builder for `/gnu/store/...-gs-fonts-8.11.drv' failed with exit code 1= =20=20 >>=20 >> Any idea when this problem appeared? That=E2=80=99s on core-updates, ri= ght? > > Yes, core-updates. It was caused by guile-2.0->guile-2.2 switch. > >> > + #:modules ((guix build gnu-build-system) >> > + (guix build utils) >> > + (srfi srfi-1))=20=20 >>=20 >> The first two modules are here by default (see =E2=80=98%default-modules= =E2=80=99 in >> (guix build-system gnu)), so I wonder why adding (srfi srfi-1) would >> help here. >>=20 >> Thoughts? > > In http://lists.gnu.org/archive/html/guix-devel/2017-05/msg00010.html > thread Andy explains syntax-rules changed the rules on how syntax-match > is done in guile-2.2: now things are matched by binding, not by name. Oooooh, right, terrible. > That means evaluation of -guile-builder needs to keep things in scope at > :) > > The breakage is quite widespread. Danny applied 3 patches already to fix > similar problems. I have at least 5 more packages fixed (or "fixed"?) in a > similar way and more to go. What about adding (srfi srfi-1) to =E2=80=98%default-modules=E2=80=99 in (g= uix build-system gnu)? It=E2=80=99s generally useful anyway. (Alternately, we could rename SRFI-1=E2=80=99s =E2=80=98delete=E2=80=99 in = (guix build utils), so we=E2=80=99d still be matching a literal, but we=E2=80=99d have problems= in places that use both (guix build utils) and (srfi srfi-1).) Ludo=E2=80=99.