From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcdA9-0003Fh-8l for guix-patches@gnu.org; Tue, 01 Aug 2017 15:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcdA6-0004hE-6S for guix-patches@gnu.org; Tue, 01 Aug 2017 15:49:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcdA6-0004gu-2k for guix-patches@gnu.org; Tue, 01 Aug 2017 15:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcdA5-0001EK-JW for guix-patches@gnu.org; Tue, 01 Aug 2017 15:49:01 -0400 Subject: [bug#27876] [PATCH] cuirass: add Hydra compatible HTTP API. Resent-Message-ID: References: <20170730100759.17734-1-m.othacehe@gmail.com> <87ini84ptn.fsf@gnu.org> From: Mathieu Othacehe In-reply-to: <87ini84ptn.fsf@gnu.org> Date: Tue, 01 Aug 2017 21:48:09 +0200 Message-ID: <877eynnk7a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27876@debbugs.gnu.org Hi Ludo ! I'll submit a v2 soon, here are some answers to your remarks. > That said, there’s only one place where we work, which is where we spawn > the ‘evaluate’ command. It may be that spawning it with ‘open-pipe’ > from (ice-9 popen) would sidestep the problem because ‘open-pipe’ is > specifically written to permit this. The open-pipe solution seems fine indeed ! > I think it would be nice to have a couple of tests for the HTTP API. > There are helpers in tests/publish.scm and (guix tests http) that could > probably be borrowed here. WDYT? Sure, I'll add some new tests on the new API. > Anyway, awesome work! It’s a really important gap that you’re filling > here. Thank you ;) > In the future it would be nice to have an API to add jobsets, trigger an > evaluation, things like that. That’s probably more difficult though > because we’ll need an authentication mechanism. > > Also we should consider Fiberizing the whole thing eventually, so that > Cuirass can actually perform all its activities concurrently. Yes my planning is the following : 1. Fiberizing the whole thing to make it scalable. 2. Add build start/stop detection : I think the ideal would be wip-ui branch to get merged before, so that I can use the same mechanism to parse build output :) 3. Add authentification, and the other API you're describing. Still plenty of work !! Mathieu