From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpDk3-0003Hb-WD
	for guix-patches@gnu.org; Tue, 05 Sep 2017 09:18:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpDju-0004I4-Kr
	for guix-patches@gnu.org; Tue, 05 Sep 2017 09:18:11 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:41898)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dpDju-0004I0-HG
	for guix-patches@gnu.org; Tue, 05 Sep 2017 09:18:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpDju-0008LH-B8
	for guix-patches@gnu.org; Tue, 05 Sep 2017 09:18:02 -0400
Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to
	make-iso9660-image.
Resent-Message-ID: <handler.28288.B28288.150461747032049@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170830071714.75f88e47@cbaines.net>
	<20170903105041.2925-1-mail@cbaines.net>
Date: Tue, 05 Sep 2017 15:17:32 +0200
In-Reply-To: <20170903105041.2925-1-mail@cbaines.net> (Christopher Baines's
	message of "Sun, 3 Sep 2017 11:50:37 +0100")
Message-ID: <877exds2s3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28288@debbugs.gnu.org

Hi!

Christopher Baines <mail@cbaines.net> skribis:

> This mimics the functionality in the root-partition-initializer used in
> creating the QEMU image. This helps when trying to run guix system init f=
rom
> the generated ISO image.
>
> * gnu/build/vm.scm (make-iso9660-image): Add support for registering clos=
ures.

[...]

> +    (when register-closures?
> +      (display "registering closures...\n")
> +      (for-each (lambda (closure)
> +                  (register-closure
> +                   "/tmp/root"
> +                   (string-append "/xchg/" closure)
> +                   #:deduplicate? #f))
> +                closures))

Was there any specific reason for #:deduplicate? #f here?

Otherwise LGTM!

Ludo=E2=80=99.