[bug#28423] gnu: Add imb-openmpi.

[ludo@gnu.org (Ludovic Courtès)]

Heya,

Dave Love <fx@gnu.org> skribis:

> From eed7aaac597248505d0ad0609810f7af5caac720 Mon Sep 17 00:00:00 2001
> From: Dave Love <fx@gnu.org>
> Date: Sat, 9 Sep 2017 11:10:29 +0100
> Subject: [PATCH] gnu: Add imb-openmpi.
>
> * mpi.scm (gnu, imb): New function.
>   (imb-openmpi): New package.

[...]

> +    (inputs
> +     `((,(package-name mpi) ,mpi)))

Rather:

  `(("mpi" ,mpi))

> +         (replace 'build
> +           (lambda* _
> +             (let ((mpi-home (dirname (dirname (which "mpicc")))))

I'd suggest:

  (lambda* (#:key inputs #:allow-other-keys)
    (let ((mpi (assoc-ref inputs "mpi")))
      ...))

> +               (zero?
> +                ;; Not safe for parallel build
> +                (system
> +                 (format #f "make -C imb/src -f make_mpich SHELL=sh MPI_HOME=~a"
> +                         mpi-home))))))

Rather use ‘system*’ to avoid going through the shell.

> +                 (system
> +                  (string-append
> +                   "cd imb/src && install -m755 IMB-IO IMB-EXT IMB-MPI1 IMB-NBC IMB-RMA "
> +                   bin)))
> +                (zero?
> +                 (system
> +                  (string-append
> +                   "cd imb && cp -r license " doc))))))))))

Likewise, use ‘copy-file’ and ‘copy-recursively’ rather than shelling
out.

> +    (synopsis (format #f "Intel MPI Benchmarks, ~a version" (package-name mpi)))
> +    (description (format #f "\
> +A set of MPI performance measurements for point-to-point and global
> +communication, and file, operations for a range of message sizes.
> +The generated benchmark data fully characterize:
> +@itemize
> +@item
> +Performance of a cluster system, including node performance, network latency,
> +and throughput;
> +@item
> +Efficiency of the MPI implementation.
> +@end itemize
> +This is the ~a version." (package-name mpi)))

Please avoid constructing synopsis/description strings as this prevents
i18n.

My suggestion would be to either leave them unchanged, which should be
good enough anyway, or to just modify the synopsis but then arrange to
have the whole string translated.

Could you send an updated patch?

Thanks,
Ludo’.