From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxJfe-0002an-Im for guix-patches@gnu.org; Wed, 27 Sep 2017 17:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxJfa-0005jg-GF for guix-patches@gnu.org; Wed, 27 Sep 2017 17:15:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55038) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxJfa-0005jZ-61 for guix-patches@gnu.org; Wed, 27 Sep 2017 17:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxJfZ-0002dQ-Um for guix-patches@gnu.org; Wed, 27 Sep 2017 17:15:01 -0400 Subject: [bug#28000] [PATCH] gnu: octave: Build with texinfo. Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Wed, 27 Sep 2017 23:14:50 +0200 Message-ID: <877ewjalo5.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 28000@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > Indeed, I was waiting for a response to this patch, and am seeing your > reply only now, after almost 2 months! It looks like I'm having trouble > with my DNS configuration. :-( > > >>> texinfo is required for the built-in documentation. >>> >>> * gnu/packages/maths.scm (octave)[inputs]: Add texinfo. >>> [native-inputs]: Remove texinfo. >> >>If I read this right, Octave references texinfo at runtime, so it's >>moved to inputs for correctness? The commit message is a bit confusing, >>since it already has texinfo available :-) > > Currently, there is a comment above the octave package definition saying > that users should install texinfo manually in their profile. My patch > allows the user to not have to do that. This is the meaning I was trying > to convey with the commit message. What other commit message would you > suggest? I think the comment may be referring to some of the command-line utilities from Texinfo, e.g. for PDF exports. There are no new texinfo references in "octave" after this patch: --8<---------------cut here---------------start------------->8--- $ grep -R /gnu/store/gfsiaw6rn29ii8cpjnix05a7r588k9yv-texinfo-6.3 $(./pre-inst-env guix build octave) Binary file /gnu/store/pkg54952yx7dgv4cwjiwpfq5l9lyv90y-octave-4.2.1/lib/octave/4.2.1/liboctinterp.so.4.0.0 matches Binary file /gnu/store/pkg54952yx7dgv4cwjiwpfq5l9lyv90y-octave-4.2.1/lib/octave/4.2.1/liboctinterp.so.4 matches Binary file /gnu/store/pkg54952yx7dgv4cwjiwpfq5l9lyv90y-octave-4.2.1/lib/octave/4.2.1/liboctinterp.so matches Binary file /gnu/store/pkg54952yx7dgv4cwjiwpfq5l9lyv90y-octave-4.2.1/bin/mkoctfile matches Binary file /gnu/store/pkg54952yx7dgv4cwjiwpfq5l9lyv90y-octave-4.2.1/bin/mkoctfile-4.2.1 matches --8<---------------cut here---------------end--------------->8--- However, native-inputs should not be referenced at all, so the patch LGTM apart from the comment update. Or maybe it's simply outdated? Side note: Why is it referring to a different texinfo than the one from `guix build texinfo`. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlnMFMoACgkQoqBt8qM6 VPpIgwgAm2Qpdok3B2cGE5a9Et/zsBYPH8/nRMlwdhPG7y1MqIIBFHtjDS177Bza GHL2sYwQvnQ/u8A79MsUfVkRMVgfsi4RjCjUm4kxNRPeRc6X38xw3gVLNzRGb0Wp A0OHYaIKSp8ZwFqIWzDvCyF3JQYwra+7JAKf6nyePeDidOVh0HkFjcrN9FWzk33p 31i32KnPXGMD1ipA0NuIJn48C1oyRWjURnS9J4cq1WmJyxQVLx9V/7vzkNUxhIsD jgEYPaWRgm8yB8SoFD5ctE7uViKc+dTcjkKOS0edagpp8uNK9P3lejZt+E96ddvp 87N8nyylPcdQXS+6Tddsxxj0FuSwrw== =tBmC -----END PGP SIGNATURE----- --=-=-=--