unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 29468-done@debbugs.gnu.org
Subject: bug#29468: [PATCH 2/2] gnu: Patch udisks to directly reference cryptsetup and parted.
Date: Mon, 27 Nov 2017 19:47:31 +0000	[thread overview]
Message-ID: <877eubijvw.fsf@cbaines.net> (raw)
In-Reply-To: <87r2sjlsno.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]


Ludovic Courtès writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> This fixes some functionality in gnome-disks, which uses udisks. Adding
>> cryptsetup enables creating partitions using LUKS, and adding parted enables
>> editing the partition tables through the disks application.
>>
>> * gnu/packages/freedesktop.scm (udisks)[inputs]: Add cryptsetup and parted.
>>   (arguments): Rename set-mount-file-name phase, and add cryptsetup and
>>   parted.
>
> I think the explanation above should be a comment, but otherwise LGTM.
>
> Thanks for fixing it!

No problem, I've added a couple of comments and pushed.

Thanks for reviewing :)

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2017-11-27 19:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27  8:38 [bug#29468] [PATCH 0/2] Fix some functionality in gnome-disks Christopher Baines
2017-11-27  8:48 ` [bug#29468] [PATCH 1/2] services: desktop: Create /var/run/udisks2 for the udisks service Christopher Baines
2017-11-27  8:48   ` [bug#29468] [PATCH 2/2] gnu: Patch udisks to directly reference cryptsetup and parted Christopher Baines
2017-11-27 14:09     ` Ludovic Courtès
2017-11-27 19:47       ` Christopher Baines [this message]
2017-11-27 14:08   ` [bug#29468] [PATCH 1/2] services: desktop: Create /var/run/udisks2 for the udisks service Ludovic Courtès
2017-11-27 19:29     ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eubijvw.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=29468-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).