* [bug#30698] [PATCH 0/2] Add Emacs packages for HCL and Terraform.
@ 2018-03-04 16:46 Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Christopher Baines
0 siblings, 1 reply; 7+ messages in thread
From: Christopher Baines @ 2018-03-04 16:46 UTC (permalink / raw)
To: 30698
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
Christopher Baines (2):
gnu: Add emacs-hcl-mode.
gnu: Add emacs-terraform-mode.
gnu/packages/emacs.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.
2018-03-04 16:46 [bug#30698] [PATCH 0/2] Add Emacs packages for HCL and Terraform Christopher Baines
@ 2018-03-04 16:50 ` Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode Christopher Baines
2018-03-04 20:22 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Alex Kost
0 siblings, 2 replies; 7+ messages in thread
From: Christopher Baines @ 2018-03-04 16:50 UTC (permalink / raw)
To: 30698
* gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
---
gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 69950cc6d..0e46c71f1 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7313,3 +7313,26 @@ Features:
(description "@code{epipe} provides an utility to use your editor in
the pipeline, featuring the support for running @code{emacsclient}.")
(license license:gpl3+)))
+
+(define-public emacs-hcl-mode
+ (package
+ (name "emacs-hcl-mode")
+ (version "0.03")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/syohex/emacs-hcl-mode/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/syohex/emacs-hcl-mode")
+ (synopsis "Major mode for the Hashicorp Configuration Language")
+ (description
+ "@code{emacs-hcl-mode} provides an Emacs major mode for working with
+@acronym{HCL, Hashicorp Configuration Language}. It provides syntax
+highlighting and indentation support. ")
+ (license license:gpl3+)))
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.
2018-03-04 16:50 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Christopher Baines
@ 2018-03-04 16:50 ` Christopher Baines
2018-03-04 20:21 ` Alex Kost
2018-03-04 20:22 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Alex Kost
1 sibling, 1 reply; 7+ messages in thread
From: Christopher Baines @ 2018-03-04 16:50 UTC (permalink / raw)
To: 30698
---
gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0e46c71f1..da31f7a13 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
@acronym{HCL, Hashicorp Configuration Language}. It provides syntax
highlighting and indentation support. ")
(license license:gpl3+)))
+
+(define-public emacs-terraform-mode
+ (package
+ (name "emacs-terraform-mode")
+ (version "0.06")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/syohex/emacs-terraform-mode/archive/"
+ version ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-hcl-mode" ,emacs-hcl-mode)))
+ (home-page "https://github.com/syohex/emacs-terraform-mode")
+ (synopsis "Major mode for Terraform")
+ (description
+ "@code{emacs-terraform-mode} provides a major mode for working with
+Terraform. Most of the functionality is inherited from @code{hcl-mode}.")
+ (license license:gpl3+)))
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.
2018-03-04 16:50 ` [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode Christopher Baines
@ 2018-03-04 20:21 ` Alex Kost
2018-03-05 7:44 ` Christopher Baines
0 siblings, 1 reply; 7+ messages in thread
From: Alex Kost @ 2018-03-04 20:21 UTC (permalink / raw)
To: Christopher Baines; +Cc: 30698
Christopher Baines (2018-03-04 16:50 +0000) wrote:
> ---
> gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 0e46c71f1..da31f7a13 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
> @acronym{HCL, Hashicorp Configuration Language}. It provides syntax
> highlighting and indentation support. ")
> (license license:gpl3+)))
> +
> +(define-public emacs-terraform-mode
> + (package
> + (name "emacs-terraform-mode")
> + (version "0.06")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/syohex/emacs-terraform-mode/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-hcl-mode" ,emacs-hcl-mode)))
> + (home-page "https://github.com/syohex/emacs-terraform-mode")
> + (synopsis "Major mode for Terraform")
> + (description
> + "@code{emacs-terraform-mode} provides a major mode for working with
> +Terraform. Most of the functionality is inherited from @code{hcl-mode}.")
Maybe it would be good to clarify what Terraform is in the description,
for example:
"... working with @uref{https://www.terraform.io/, Terraform}
configuration files."
> + (license license:gpl3+)))
--
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread* [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.
2018-03-04 20:21 ` Alex Kost
@ 2018-03-05 7:44 ` Christopher Baines
0 siblings, 0 replies; 7+ messages in thread
From: Christopher Baines @ 2018-03-05 7:44 UTC (permalink / raw)
To: Alex Kost; +Cc: 30698
[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]
Alex Kost <alezost@gmail.com> writes:
> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> ---
>> gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 0e46c71f1..da31f7a13 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
>> @acronym{HCL, Hashicorp Configuration Language}. It provides syntax
>> highlighting and indentation support. ")
>> (license license:gpl3+)))
>> +
>> +(define-public emacs-terraform-mode
>> + (package
>> + (name "emacs-terraform-mode")
>> + (version "0.06")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/syohex/emacs-terraform-mode/archive/"
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-hcl-mode" ,emacs-hcl-mode)))
>> + (home-page "https://github.com/syohex/emacs-terraform-mode")
>> + (synopsis "Major mode for Terraform")
>> + (description
>> + "@code{emacs-terraform-mode} provides a major mode for working with
>> +Terraform. Most of the functionality is inherited from @code{hcl-mode}.")
>
> Maybe it would be good to clarify what Terraform is in the description,
> for example:
>
> "... working with @uref{https://www.terraform.io/, Terraform}
> configuration files."
Sure, that sounds good, thanks for taking a look :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.
2018-03-04 16:50 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode Christopher Baines
@ 2018-03-04 20:22 ` Alex Kost
2018-03-05 7:50 ` bug#30698: " Christopher Baines
1 sibling, 1 reply; 7+ messages in thread
From: Alex Kost @ 2018-03-04 20:22 UTC (permalink / raw)
To: Christopher Baines; +Cc: 30698
Christopher Baines (2018-03-04 16:50 +0000) wrote:
> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
> ---
> gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 69950cc6d..0e46c71f1 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7313,3 +7313,26 @@ Features:
> (description "@code{epipe} provides an utility to use your editor in
> the pipeline, featuring the support for running @code{emacsclient}.")
> (license license:gpl3+)))
> +
> +(define-public emacs-hcl-mode
> + (package
> + (name "emacs-hcl-mode")
> + (version "0.03")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/syohex/emacs-hcl-mode/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/syohex/emacs-hcl-mode")
> + (synopsis "Major mode for the Hashicorp Configuration Language")
> + (description
> + "@code{emacs-hcl-mode} provides an Emacs major mode for working with
> +@acronym{HCL, Hashicorp Configuration Language}. It provides syntax
> +highlighting and indentation support. ")
^ extra space
otherwise, looks good to me, thank you!
> + (license license:gpl3+)))
--
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#30698: [PATCH 1/2] gnu: Add emacs-hcl-mode.
2018-03-04 20:22 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Alex Kost
@ 2018-03-05 7:50 ` Christopher Baines
0 siblings, 0 replies; 7+ messages in thread
From: Christopher Baines @ 2018-03-05 7:50 UTC (permalink / raw)
To: Alex Kost; +Cc: 30698-done
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
Alex Kost <alezost@gmail.com> writes:
> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
>> ---
>> gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 69950cc6d..0e46c71f1 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7313,3 +7313,26 @@ Features:
>> (description "@code{epipe} provides an utility to use your editor in
>> the pipeline, featuring the support for running @code{emacsclient}.")
>> (license license:gpl3+)))
>> +
>> +(define-public emacs-hcl-mode
>> + (package
>> + (name "emacs-hcl-mode")
>> + (version "0.03")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/syohex/emacs-hcl-mode/archive/"
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/syohex/emacs-hcl-mode")
>> + (synopsis "Major mode for the Hashicorp Configuration Language")
>> + (description
>> + "@code{emacs-hcl-mode} provides an Emacs major mode for working with
>> +@acronym{HCL, Hashicorp Configuration Language}. It provides syntax
>> +highlighting and indentation support. ")
> ^ extra space
> otherwise, looks good to me, thank you!
Great, I've removed the space, and pushed both of these patches. Thanks
for your review :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-05 7:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-04 16:46 [bug#30698] [PATCH 0/2] Add Emacs packages for HCL and Terraform Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode Christopher Baines
2018-03-04 20:21 ` Alex Kost
2018-03-05 7:44 ` Christopher Baines
2018-03-04 20:22 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Alex Kost
2018-03-05 7:50 ` bug#30698: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).