From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43815)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fANAP-0004cE-Dt
	for guix-patches@gnu.org; Sun, 22 Apr 2018 18:09:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fANAM-0006sX-70
	for guix-patches@gnu.org; Sun, 22 Apr 2018 18:09:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56521)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fANAM-0006sG-1C
	for guix-patches@gnu.org; Sun, 22 Apr 2018 18:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fANAL-0000hQ-PW
	for guix-patches@gnu.org; Sun, 22 Apr 2018 18:09:01 -0400
Subject: [bug#31237] [PATCH] gnu: Add runc.
Resent-Message-ID: <handler.31237.B31237.15244349092649@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180422125844.15227-1-iyzsong@member.fsf.org>
Date: Mon, 23 Apr 2018 00:08:25 +0200
In-Reply-To: <20180422125844.15227-1-iyzsong@member.fsf.org>
	("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s
	message of "Sun, 22 Apr 2018 20:58:44 +0800")
Message-ID: <877eoygahy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Cc: 31237@debbugs.gnu.org

Hello,

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:

> * gnu/packages/virtualization.scm (runc): New variable.

Nice!

> +(define-public runc
> +  (package
> +    (name "runc")
> +    (version "1.0.0-rc5")

If the actual release is going to be out soon, I=E2=80=99d be in favor of
waiting for it; an RC doesn=E2=80=99t sound great.  WDYT?

> +    (build-system gnu-build-system)

Would =E2=80=98go-build-system=E2=80=99 work better?  Or is it something of=
 a hybrid
(apparently it has makefiles)?

> +    (arguments
> +     '(#:tests? #f                      ; FIXME: 20/139 tests fail.

Have you looked a bit into them, just to see if it=E2=80=99s one of the usu=
al
things (/bin/sh, networking, etc.) or if it=E2=80=99s more involved?

> +               (invoke "make"))))

Perhaps honor (parallel-job-count).

> +    (synopsis "Open container initiative runtime")
> +    (home-page "https://www.opencontainers.org/")
> +    (description
> +     "@command{runc} is a command line client for running applications
> +packaged according to the Open Container Initiative (OCI) format and is a
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
An @uref would be nice.  :-)

Thanks!

Ludo=E2=80=99.