From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLmSh-0001If-Re
	for guix-patches@gnu.org; Thu, 24 May 2018 05:23:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLmSc-0006Y0-S3
	for guix-patches@gnu.org; Thu, 24 May 2018 05:23:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38074)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fLmSc-0006Xu-HH
	for guix-patches@gnu.org; Thu, 24 May 2018 05:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fLmSc-0000BD-8A
	for guix-patches@gnu.org; Thu, 24 May 2018 05:23:02 -0400
Subject: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead
	of bootstrap binary.
Resent-Message-ID: <handler.31570.B31570.1527153778666@debbugs.gnu.org>
References: <871se2jnya.fsf@gmail.com>
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
In-Reply-To: <871se2jnya.fsf@gmail.com>
Date: Thu, 24 May 2018 11:22:22 +0200
Message-ID: <877entcss1.fsf@mdc-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alex Vong <alexvong1995@gmail.com>
Cc: 31570@debbugs.gnu.org


Hi Alex,

> This patch set will cause javacc to bootstrap from javacc-4 instead of
> the bundled bootstrap jar. The next step would be to figure out how to
> bootstrap javacc-4 by hand, which would be challenging I think...

Thanks for this.

The patches look fine to me.

>         (modify-phases %standard-phases
> -         (add-after 'unpack 'delete-bundled-libs
> +         (add-after 'unpack 'delete-bundled-jars
>             (lambda _
> -             (delete-file-recursively "lib") #t))
> -         (replace 'install (install-jars "target")))))))
> +             (delete-file-recursively "bootstrap")
> +             (delete-file-recursively "lib")
> +             #t))

Can we delete these things in a snippet instead?

(I vaguely remember that we didn’t use snippets for jars because
patch-and-repack wouldn’t support the jar format, but I don’t know if
that’s still the case.)

-- 
Ricardo