unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Alex Vong <alexvong1995@gmail.com>
Cc: 31570@debbugs.gnu.org
Subject: [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary.
Date: Thu, 24 May 2018 11:22:22 +0200	[thread overview]
Message-ID: <877entcss1.fsf@mdc-berlin.de> (raw)
In-Reply-To: <871se2jnya.fsf@gmail.com>


Hi Alex,

> This patch set will cause javacc to bootstrap from javacc-4 instead of
> the bundled bootstrap jar. The next step would be to figure out how to
> bootstrap javacc-4 by hand, which would be challenging I think...

Thanks for this.

The patches look fine to me.

>         (modify-phases %standard-phases
> -         (add-after 'unpack 'delete-bundled-libs
> +         (add-after 'unpack 'delete-bundled-jars
>             (lambda _
> -             (delete-file-recursively "lib") #t))
> -         (replace 'install (install-jars "target")))))))
> +             (delete-file-recursively "bootstrap")
> +             (delete-file-recursively "lib")
> +             #t))

Can we delete these things in a snippet instead?

(I vaguely remember that we didn’t use snippets for jars because
patch-and-repack wouldn’t support the jar format, but I don’t know if
that’s still the case.)

-- 
Ricardo

  parent reply	other threads:[~2018-05-24  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 17:12 [bug#31570] [PATCH 0/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary Alex Vong
2018-05-23 17:16 ` [bug#31570] [PATCH 1/2] gnu: javacc: 'javacc' now inherits from 'javacc-4' Alex Vong
2018-05-23 17:17 ` [bug#31570] [PATCH 2/2] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary Alex Vong
2018-05-24  9:22 ` Ricardo Wurmus [this message]
2018-05-24 19:55   ` [bug#31570] [PATCH 0/2] " Alex Vong
2018-05-25  0:19     ` Alex Vong
2018-05-25  0:21 ` [bug#31570] [PATCH 1/3] gnu: javacc: 'javacc' now inherits from 'javacc-4' Alex Vong
2018-05-25  0:22 ` [bug#31570] [PATCH 2/3] gnu: javacc: Use snippet to delete bundled jars Alex Vong
2018-05-25  0:23 ` [bug#31570] [PATCH 3/3] gnu: javacc: Bootstrap from javacc-4 instead of bootstrap binary Alex Vong
2018-07-03 12:44 ` [bug#31570] [PATCH 0/2] " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877entcss1.fsf@mdc-berlin.de \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=31570@debbugs.gnu.org \
    --cc=alexvong1995@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).