From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXXS7-00075B-H7 for guix-patches@gnu.org; Mon, 25 Jun 2018 15:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXXS2-0007Bz-SM for guix-patches@gnu.org; Mon, 25 Jun 2018 15:47:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55595) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXXS2-0007BI-MF for guix-patches@gnu.org; Mon, 25 Jun 2018 15:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXXS2-0005dy-EJ for guix-patches@gnu.org; Mon, 25 Jun 2018 15:47:02 -0400 Subject: [bug#31957] [PATCH] gnu: Add python-libusb1. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87r2kwne89.fsf@aikidev.net> References: <87r2kwne89.fsf@aikidev.net> Date: Mon, 25 Jun 2018 21:46:27 +0200 Message-ID: <877emmejjg.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian , 31957@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vagrant Cascadian writes: > Add new package definition for python-libusb1, needed to upgrade > python-trezor to newer versions. Thanks! I have some minor nitpicks: [...] > * gnu/packages/libusb.scm (python-libusb1): New variable. Can you also add yourself to the copyright header in this file? [...] =20=20 > +(define-public python-libusb1 > + (package > + (name "python-libusb1") > + (version "1.6.4") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "libusb1" version)) > + (sha256 > + (base32 > + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc")))) > + (build-system python-build-system) > + (arguments > + `(#:modules ((srfi srfi-1) > + (srfi srfi-26) Is srfi-26 actually used here? > + (guix build utils) > + (guix build python-build-system)) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-libusb-reference > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "usb1/libusb1.py" > + (("libusb_path =3D ctypes.util.find_library\\(base_name\\= )") > + (string-append > + "libusb_path =3D \"" > + (find (negate symbolic-link?) > + (find-files (assoc-ref inputs "libusb") > + "^libusb.*\\.so\\..*")) > + "\""))) > + #t))))) > + (inputs `(("libusb" ,libusb))) > + (home-page > + "http://github.com/vpelletier/python-libusb1") This line break is unnecessary :-) > + (synopsis "Pure-python wrapper for libusb-1.0") > + (description > + "Pure-python wrapper for libusb-1.0") This description is rather thin. Can you try to make it into one or more full sentences? > + (license lgpl2.1+))) I noticed the source contains GPL2 in COPYING, and LGPL2.1 as "COPYING.LESSER". Can you make sure we don't install the former? Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsxRpMACgkQoqBt8qM6 VPq26Af/d8rDUNL9Qti+/nr3NhdOe+07zOjyZXftfl/86wv+Jz7//A1nH0NXGRyG DycWyhpJaIO6DoTHnuFrIbYvMU+5OGcz9scTg3Pk2WWgoGpYmiNT12dqVbNrd3Ks KVoNbySmKv2xn3YHascEdYldlKbRxfUCWPebxiJVHo0wLuz73V7HK0bzxEjJaI/w y4LyGPctv6w9B1p/f3Pj9EJtS4eEELTJwfD5oNFXA/4hZGpjtrFEjB2+F8ZDfpD4 lazy8ShUJgNbhAVxzQfxUJZHaExI9FMcd+LmcsdkilKhjTg5khrFsyVX77lsg/yB oQPstSEHSfEUZJelDlwG+6BNSLmdhg== =H7mK -----END PGP SIGNATURE----- --=-=-=--