From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 32192@debbugs.gnu.org
Subject: [bug#32192] [PATCH 0/7] Remove duplicated packages.
Date: Thu, 19 Jul 2018 11:23:31 +0200 [thread overview]
Message-ID: <877elry3xo.fsf@gnu.org> (raw)
In-Reply-To: <20180717210733.GC12949@jasmine.lan> (Leo Famulari's message of "Tue, 17 Jul 2018 17:07:33 -0400")
Hello,
Leo Famulari <leo@famulari.name> skribis:
> On Tue, Jul 17, 2018 at 09:27:45PM +0100, Christopher Baines wrote:
>> The following patches attempt to remove the duplicates, favouring the
>> original package definition.
>
> I sent one comment, otherwise the patches LGTM.
>
>> Is there any way of guarding against adding these, or more accurately
>> checking for duplicate definitions?
>
> I don't know. Hopefully someone else has some ideas.
It’s terrible to see there were so many duplicate packages.
The package lookup machinery detects and warns about same-named packages
when you do things like:
(define-public var1
(package (name "something") …))
(define-public var2
(package (name "something") …))
The problem here is that duplicates were in the same module and using
the same variable name, such that the second definition would shadow the
first one, and so Guix only sees one package.
I think we should add a warning in the compiler for this situation.
Ludo’.
next prev parent reply other threads:[~2018-07-19 9:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 20:27 [bug#32192] [PATCH 0/7] Remove duplicated packages Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 1/7] gnu: Remove duplicated emacs-csv-mode Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 2/7] gnu: Remove duplicated emacs-load-relative Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 3/7] gnu: Remove duplicated r-psych package Christopher Baines
2018-07-17 21:05 ` Leo Famulari
2018-07-29 17:03 ` Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 4/7] gnu: Remove duplicated ghc-th-lift-instances Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 5/7] gnu: Remove duplicated ghc-time-locale-compat Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 6/7] gnu: Remove duplicated perl-extutils-depends Christopher Baines
2018-07-17 20:41 ` [bug#32192] [PATCH 7/7] gnu: Remove duplicated python-pafy Christopher Baines
2018-07-17 21:07 ` [bug#32192] [PATCH 0/7] Remove duplicated packages Leo Famulari
2018-07-19 9:23 ` Ludovic Courtès [this message]
2018-07-24 10:11 ` Ludovic Courtès
2018-07-24 19:19 ` Christopher Baines
2018-07-29 17:04 ` bug#32192: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877elry3xo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32192@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).