From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fygZg-0007pA-Dg for guix-patches@gnu.org; Sat, 08 Sep 2018 12:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fygZc-0007FM-5s for guix-patches@gnu.org; Sat, 08 Sep 2018 12:59:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fygZa-0007CS-Oy for guix-patches@gnu.org; Sat, 08 Sep 2018 12:59:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fygZZ-0007rI-UD for guix-patches@gnu.org; Sat, 08 Sep 2018 12:59:02 -0400 Subject: [bug#32634] RFC: Process build output Resent-Message-ID: References: <877ek1z3gg.fsf@elephly.net> <20180908161143.aonygx4iqnj2zury@abyayala> From: Tobias Geerinckx-Rice In-reply-to: <20180908161143.aonygx4iqnj2zury@abyayala> Date: Sat, 08 Sep 2018 18:58:35 +0200 Message-ID: <877ejwc4ec.fsf@tobias.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nils Gillmann Cc: Ricardo Wurmus , 32634@debbugs.gnu.org ng0, Nils Gillmann wrote: > Hi, > > Ricardo Wurmus transcribed 2.1K bytes: >> Hi Guix, >>=20 >> this patch set is a first draft to stylize (potentially=20 >> confusing) build >> output when using =E2=80=9Cguix package=E2=80=9D and =E2=80=9Cguix build= =E2=80=9D. >>=20 >> This is done by adding a soft port that matches on lines in the=20 >> build >> output and colorizes them (unless INSIDE_EMACS or NO_COLOR are=20 >> set, or >> when output is redirected). For =E2=80=9Cguix package=E2=80=9D the defa= ult=20 >> behaviour is > > So far I have one comment: > > Would it make sense to use 'GUIX_UI_NO_COLOR' instead? This=20 > makes it > clear what it is for (use clear function names), and it does not > impose using "no colors" in other terminal applications if you > permanently export it. > >> to also hide all build output that does not announce progress=20 >> (unless >> =E2=80=9C--verbose=E2=80=9D is passed) and to let a spinner show progres= s=20 >> instead. For >> =E2=80=9Cguix build=E2=80=9D all build output is still printed. >>=20 >> Honestly, I=E2=80=99m not really happy with the results, but I think=20 >> it=E2=80=99s enough >> to start a discussion about where this should lead. >>=20 >> One thing I don=E2=80=99t like is that I had to set the=20 >> =E2=80=9Cprint-build-trace?=E2=80=9D >> default option to be able to display what build is currently=20 >> happening. >> Unfortunately, for small derivations this leads to output like=20 >> this: >>=20 >> --8<---------------cut=20 >> here---------------start------------->8--- >> Building=20 >> /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv -=20 >> x86_64-linux >> Built /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv >> Building=20 >> /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv -=20 >> x86_64-linux >> Built=20 >> /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv >> Building=20 >> /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv -=20 >> x86_64-linux >> Built /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv >> Building=20 >> /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv=20 >> - x86_64-linux >> Built=20 >> /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv >> --8<---------------cut=20 >> here---------------end--------------->8--- >>=20 >> I would prefer: >>=20 >> Building=20 >> /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv=20 >> =E2=80=A6 DONE >>=20 >> or similar. >>=20 >> I don=E2=80=99t know about whether the colours are any good; I think=20 >> the bold >> green is hard to read on a bright terminal, while the black is=20 >> hard to >> read on a dark terminal. >>=20 >> Lastly: the spinner. It=E2=80=99s a bit boring, I think. >>=20 >> What do you think? Is this a step in the right direction? >>=20 >> -- >> Ricardo >>=20 >>=20 >>=20 >>=20 --=20 Kind regards, T G-R