unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Gabriel Hondet <gabrielhondet@gmail.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 33986@debbugs.gnu.org
Subject: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 17:36:56 +0100	[thread overview]
Message-ID: <877efj83iv.fsf@gmail.com> (raw)
In-Reply-To: <6B48181E-452B-4D22-80B1-DAECAE104B48@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]


On Sat 05 Jan 2019 at 14:22 Julien Lepiller wrote:

> We already have them, but I think they are only for ocaml-4.02.

Indeed they exist but only for ocaml-4.02, I hope doing new patches for
the current version was the right thing to do.

> In the meantime, could you add a comment to explain why you disabled tests whenever you did? It could be as short as "; no tests". Also, do you know what happened with the versionning?

Regarding the test, I only disabled them if they don't exist.  I have
added comments to clarify that.  Regarding the versioning number
(113.33.xx in 2016 to 0.9.0 in 2017...), I have no idea what happened.

Here is the first patch, the others are following.

* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
---
 gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e4f17133d..a23f6a724 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional syntax for tuples and variants.
 yojson package.  The program @code{atdgen} can be used to derive OCaml-JSON
 serializers and deserializers from type definitions.")
     (license license:bsd-3)))
+
+(define-public ocaml-sexplib0
+  (package
+    (name "ocaml-sexplib0")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/sexplib0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Library containing the definition of S-expressions and some
+base converters")
+    (description "Part of Jane Street's Core library The Core suite of
+libraries is an industrial strength alternative to OCaml's standard library
+that was developed by Jane Street, the largest industrial user of OCaml.")
+(license license:expat)))
-- 
2.20.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-01-05 16:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  7:18 [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0 Gabriel Hondet
2019-01-03  7:26 ` [bug#33986] [PATCH 2/9] gnu: Add ocaml-parsexp Gabriel Hondet
2019-01-03  7:45 ` [bug#33986] [PATCH 3/9] gnu: Add ocaml-sexplib Gabriel Hondet
2019-01-03  8:43 ` [bug#33986] [PATCH 4/9] gnu: Add ocaml-base Gabriel Hondet
2019-01-03  9:13 ` [bug#33986] [PATCH 5/9] gnu: Add ocaml-compiler-libs Gabriel Hondet
2019-01-03  9:40 ` [bug#33986] [PATCH 6/9] gnu: Add ocaml-migrate-parsetree Gabriel Hondet
2019-01-03  9:48 ` [bug#33986] [PATCH 7/9] gnu: Add ocaml-stdio Gabriel Hondet
2019-01-03  9:59 ` [bug#33986] [PATCH 8/9] gnu: Add ocaml-ppx-derivers Gabriel Hondet
2019-01-04  9:09 ` [bug#33986] [PATCH 9/9] gnu: Add ocaml-ppxlib Gabriel Hondet
2019-01-05 13:22 ` [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0 Julien Lepiller
2019-01-05 16:36   ` Gabriel Hondet [this message]
2019-01-05 16:38   ` [bug#33986] [PATCH 5/9] " Gabriel Hondet
2019-01-05 16:39   ` [bug#33986] [PATCH 7/9] " Gabriel Hondet
2019-01-05 16:44   ` [bug#33986] [PATCH 8/9] gnu: Add ocaml-ppx-derivers Gabriel Hondet
2019-01-16 19:11 ` bug#33986: [PATCH 1/9] gnu: Add ocaml-sexplib0 Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877efj83iv.fsf@gmail.com \
    --to=gabrielhondet@gmail.com \
    --cc=33986@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).