From: Arne Babenhauserheide <arne_bab@web.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34128@debbugs.gnu.org
Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support
Date: Wed, 23 Jan 2019 00:10:41 +0100 [thread overview]
Message-ID: <877eew70ge.fsf@web.de> (raw)
In-Reply-To: <87lg3cjrdh.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
Hi Ludovic,
> Thanks for the patch!
Thank you for your review!
> I wonder why this hadn’t been done before;
> Nicolas, Alex, Pierre, thoughts?
There is an older bug with xwidgets support which had problems because
it depended on an old version of webkitgtk (I only found it after I sent
the patch). Maybe that stopped others from submitting.
Ludovic Courtès <ludo@gnu.org> writes:
> The patch LGTM, minor stylistic issues:
> …
> Please indent rather along these lines (like in the rest of the file):
>
> (define-public emacs-xwidgets
> (package
> (inherit emacs)
> (name …) …))
>
> Likewise, for consistency, use unquote-splicing rather than ‘append’:
>
> (inputs `(("webkitgtk" ,webkitgtk)
> ;; …
> ,@(package-inputs emacs)))
>
> Could you send an updated patch?
Is inline here OK? If yes:
From ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab@web.de>
Date: Fri, 18 Jan 2019 23:29:14 +0100
Subject: [PATCH] add emacs built with xwidgets-support
* gnu/packages/emacs.scm (emacs-xwidgets): new variable
---
gnu/packages/emacs.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a488289f1..7e8dcadf9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -59,6 +59,7 @@
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages texinfo)
#:use-module (gnu packages tls)
+ #:use-module (gnu packages webkit)
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
#:use-module (guix utils)
@@ -210,6 +211,22 @@ languages.")
(native-inputs
`(("pkg-config" ,pkg-config)))))
+(define-public emacs-xwidgets
+ (package
+ (inherit emacs)
+ (name "emacs-xwidgets")
+ (synopsis "The extensible, customizable, self-documenting text
+editor (with xwidgets support)")
+ (build-system gnu-build-system)
+ (arguments
+ `(#:configure-flags
+ '("--with-xwidgets")
+ ,@(package-arguments emacs)))
+ (inputs
+ `(("webkitgtk" ,webkitgtk)
+ ("libxcomposite" ,libxcomposite)
+ ,@(package-inputs emacs)))))
+
(define-public emacs-no-x
(package (inherit emacs)
(name "emacs-no-x")
--
2.19.2
Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1076 bytes --]
next prev parent reply other threads:[~2019-01-22 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 22:29 [bug#34128] [PATCH] add emacs built with xwidgets-support Arne Babenhauserheide
2019-01-22 21:48 ` Ludovic Courtès
2019-01-22 23:10 ` Arne Babenhauserheide [this message]
2019-01-23 8:19 ` Ricardo Wurmus
2019-01-23 9:37 ` Arne Babenhauserheide
2019-01-23 9:53 ` Ludovic Courtès
2019-01-23 11:41 ` Ricardo Wurmus
2019-01-23 22:29 ` bug#34128: " Ludovic Courtès
2019-01-24 19:06 ` [bug#34128] " Arne Babenhauserheide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eew70ge.fsf@web.de \
--to=arne_bab@web.de \
--cc=34128@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).