unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: 34204@debbugs.gnu.org
Subject: [bug#34204] [PATCH 1/3] gnu: python-tornado: Update to 5.1.1.
Date: Sat, 26 Jan 2019 14:34:14 +0100	[thread overview]
Message-ID: <877eerv8yx.fsf@elephly.net> (raw)
In-Reply-To: <20190126002849.7707-1-mthl@gnu.org>


Hi Mathieu,

> * gnu/packages/python-web.scm (python-tornado): Update to 5.1.1.

Thanks for the patch!

>  (define-public python-tornado
>    (package
>      (name "python-tornado")
> -    (version "4.5.1")
> +    (version "5.1.1")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "tornado" version))
>         (sha256
> -        (base32 "1zbkgcdfq81k298awrm8p0xwbwwn2p3nbizdglzfbkskhai082fv"))))
> +        (base32 "02clqk2116jbnq8lnaqmdw3p52nqrd9ib59r4xz2ll43fpcmhlaf"))))
>      (build-system python-build-system)
>      (arguments
>       '(;; FIXME: Two tests error out with:

The arguments field says:

    (arguments
     '(;; FIXME: Two tests error out with:
       ;; AssertionError: b'Error in atexit._run_exitfuncs:\nFileNotF[44 chars]ry\n' != b''
       ;; #:phases
       ;; (modify-phases %standard-phases
       ;;   (replace 'check
       ;;     (lambda _
       ;;       ;; 'setup.py test' hits an AssertionError on BSD-specific
       ;;       ;; "tornado/platform/kqueue.py". This is the supported method:
       ;;       (invoke- "python" "-m" "tornado.test")
       ;;       #t)))
       #:tests? #f))

Is this still the case or can we enable the tests?

A number of important packages depend on python-tornado, such as
python-matplotlib, jupyter, and python-scikit-image.  Since this is a
major version bump I wonder if you have tried building some of these
related packages to make sure they don’t fail.

(We can of course respond to breakage once we discover it when building
the new evaluations, but it would be nicer if we could have some
reassurance.)

-- 
Ricardo

  parent reply	other threads:[~2019-01-26 14:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26  0:25 [bug#34204] [PATCH 0/3] Mkdocs and its dependencies Mathieu Lirzin
2019-01-26  0:28 ` [bug#34204] [PATCH 1/3] gnu: python-tornado: Update to 5.1.1 Mathieu Lirzin
2019-01-26  0:28   ` [bug#34204] [PATCH 2/3] gnu: Add Python LiveReload Mathieu Lirzin
2019-01-26 13:35     ` Ricardo Wurmus
2019-01-26  0:28   ` [bug#34204] [PATCH 3/3] gnu: Add Mkdocs Mathieu Lirzin
2019-01-26 13:37     ` Ricardo Wurmus
2019-01-26 15:24       ` Mathieu Lirzin
2019-01-26 13:34   ` Ricardo Wurmus [this message]
2019-01-26 14:29     ` [bug#34204] [PATCH 1/3] gnu: python-tornado: Update to 5.1.1 Mathieu Lirzin
2021-07-13 13:39 ` bug#34204: [PATCH 0/3] Mkdocs and its dependencies Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eerv8yx.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34204@debbugs.gnu.org \
    --cc=mthl@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).