From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:36135)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvraw-0008C2-Ui
	for guix-patches@gnu.org; Mon, 18 Feb 2019 17:41:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvraw-0007e8-6S
	for guix-patches@gnu.org; Mon, 18 Feb 2019 17:41:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:54085)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gvraw-0007d8-16
	for guix-patches@gnu.org; Mon, 18 Feb 2019 17:41:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvrav-0002e1-Ti
	for guix-patches@gnu.org; Mon, 18 Feb 2019 17:41:01 -0500
Subject: [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster.
Resent-Message-ID: <handler.34514.B34514.155052966010150@debbugs.gnu.org>
References: <87sgwm44a9.fsf@cbaines.net>
	<20190217192314.5666-1-mail@cbaines.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190217192314.5666-1-mail@cbaines.net>
Date: Mon, 18 Feb 2019 23:40:53 +0100
Message-ID: <877edwwwi2.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34514@debbugs.gnu.org


Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/ruby.scm (ruby-hamster): New variable.
[=E2=80=A6]
> +       (add-after 'unpack 'remove-unnecessary-dependencies
> +         (lambda _
> +           ;; pry is a debugging tool, and is unnecessary when running t=
he
> +           ;; tests
> +           (substitute* "spec/lib/hamster/vector/insert_spec.rb"
> +             (("require 'pry'") ""))
> +           (substitute* "spec/spec_helper.rb"
> +             (("require \"pry\"") "")

We have a ruby-pry package.  Wouldn=E2=80=99t it be nicer to add it instead=
 of
patching the sources?

> +             ;; CodeClimate is an online service, and is unnecessary for
> +             ;; running the tests
> +             (("require \"codeclimate-test-reporter\"") "")
> +             (("CodeClimate.*\n") ""))

Okay.

--=20
Ricardo