From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:40388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwWwX-0002o3-3F
	for guix-patches@gnu.org; Wed, 20 Feb 2019 13:50:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwWwW-0003jL-6z
	for guix-patches@gnu.org; Wed, 20 Feb 2019 13:50:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57691)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gwWwT-0003iD-P2
	for guix-patches@gnu.org; Wed, 20 Feb 2019 13:50:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwWwT-00015O-MQ
	for guix-patches@gnu.org; Wed, 20 Feb 2019 13:50:01 -0500
Subject: [bug#34538] [PATCH] gnu: Add r-sloop.
Resent-Message-ID: <handler.34538.B34538.15506885744132@debbugs.gnu.org>
References: <875ztg8zas.fsf@posteo.net> <87ftsitnij.fsf@elephly.net>
From: Brett Gilio <brettg@posteo.net>
In-reply-to: <87ftsitnij.fsf@elephly.net>
Date: Wed, 20 Feb 2019 12:49:21 -0600
Message-ID: <877eduqor2.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34538@debbugs.gnu.org


Ricardo Wurmus writes:

> Hi Brett,
>
>> * gnu/packages/cran.scm (r-sloop): New variable.
> [=E2=80=A6]
>> +
>> +(define-public r-sloop
>> +  (package
>> +  (name "r-sloop")
>> +  (version "1.0.1")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (cran-uri "sloop" version))
>> +      (sha256
>> +        (base32
>> +          "00fk5fr5zsk2qxc1kfhmshhjxgnamm3401089sx8m2l529zd6r8j"))))
>> +  (build-system r-build-system)
>> +  (propagated-inputs
>> +    `(("r-codetools" ,r-codetools)
>> +      ("r-crayon" ,r-crayon)
>> +      ("r-purrr" ,r-purrr)
>> +      ("r-rlang" ,r-rlang)
>> +      ("r-tibble" ,r-tibble)))
>> +  (home-page "https://github.com/r-lib/sloop")
>> +  (synopsis "Helpers for 'OOP' in R")
>> +  (description
>> +    "This package provides a collection of helper functions designed to=
 help you to better understand object oriented programming in R, particular=
ly using 'S3'.")
>> +  (license license:gpl3)))
>
> There are a couple of problems here:
>
> - The indentation is wrong throughout.
> - Please don=E2=80=99t use =E2=80=9C'=E2=80=9D in the synopsis and descri=
ption.
> - Please spell out =E2=80=9COOP=E2=80=9D in the synopsis
> - Please break the long description up into several lines.  =E2=80=9Cguix=
 lint=E2=80=9D
>   will warn you about this, so please use it.
>
> Could you please send a new patch to 34538@debbugs.gnu.org?
>
> Thanks!

Hi Ricardo,

Yes. I must have missed linting this one, my apologies. Stand-by for a
new patch.