unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35281@debbugs.gnu.org
Subject: [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies and enable docker-proxy.
Date: Mon, 15 Apr 2019 18:14:25 -0400	[thread overview]
Message-ID: <877ebuncfy.fsf@gmail.com> (raw)
In-Reply-To: <20190415082226.03761fcc@scratchpost.org> (Danny Milosavljevic's message of "Mon, 15 Apr 2019 08:22:26 +0200")

Hi Danny!

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> On Sun, 14 Apr 2019 19:02:53 -0400
> Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> +         ;; The tests fail with the error:
>> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
>> +         ;; has arg n.configOnly of wrong type bool.
>> +         #:tests? #f))
>> +      (home-page "https://github.com/docker/libnetwork/")
>
> It might make sense to report that bug upstream--they're helpful people.
>
> Otherwise LGTM!

Thanks for bringing my attention to that part; I've tried re-enabling
the tests but it seems to fail because of unmet dependencies now --
which makes sense since I'm not adding any inputs.  I've removed the
tests? #f argument and detailed in the top comment that this is simply
used as a template and doesn't even build.

Thanks for the review!

Maxim

  reply	other threads:[~2019-04-15 22:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 23:02 [bug#35281] [PATCH] gnu: docker: Add a couple go dependencies and enable docker-proxy Maxim Cournoyer
2019-04-15  6:22 ` Danny Milosavljevic
2019-04-15 22:14   ` Maxim Cournoyer [this message]
2019-05-06  0:26     ` bug#35281: " T460s laptop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ebuncfy.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=35281@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).