unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Brian Woodcox <bw@inskydata.com>
Cc: 36033@debbugs.gnu.org
Subject: [bug#36033] Add Smalltalk Pharo VM
Date: Sat, 01 Jun 2019 15:23:02 +0200	[thread overview]
Message-ID: <877ea5fnih.fsf@gnu.org> (raw)
In-Reply-To: <BA4D78A3-087B-4FAD-8318-0C64EED37C3B@inskydata.com> (Brian Woodcox's message of "Fri, 31 May 2019 13:46:50 -0600")

Hello,

Thanks for working on this, and congrats on your first package, which is
not an easy one!  :-)

Some preliminary comments:

Brian Woodcox <bw@inskydata.com> skribis:

> From 49683e04e51cd904571008fa7979a3f58ae0134c Mon Sep 17 00:00:00 2001
> From: "Brian C. Woodcox" <bw@InSkyData.com>
> Date: Fri, 31 May 2019 13:14:54 -0600
> Subject: [PATCH] Add pharo-vm package

[...]

> +(define %url "https://github.com/OpenSmalltalk/opensmalltalk-vm.git")

My understanding (but I’m no expert) is that this is a VM that can run
Pharo bytecode, but it’s not “the” Pharo VM.  Is it correct?

> +(define-public pharo-vm
> +  (package
> +    (name "pharo-vm")

Consequently, it looks like this should be called ‘opensmalltalk-vm’,
no?

> +    (arguments
> +     `(#:tests? #f ;; no tests available

Or maybe there’s a special command to run them?

> +               ;; add symlinks
> +               (symlink (string-append (assoc-ref %build-inputs "libgit2") "/lib/libgit2.so")
> +                        (string-append out "/lib/pharo/" pharo-version "/libgit2.so"))
> +               (symlink (string-append (assoc-ref %build-inputs "libssh2") "/lib/libssh2.so")
> +                        (string-append out "/lib/pharo/" pharo-version "/libssh2.so"))
> +               (symlink (string-append (assoc-ref %build-inputs "openssl") "/lib/libssl.so")
> +                        (string-append out "/lib/pharo/" pharo-version "/libssl.so"))
> +               (symlink (string-append (assoc-ref %build-inputs "freetype")"/lib/libfreetype.so.6")
> +                        (string-append out "/lib/pharo/" pharo-version "/libfreetype.so.6")))

Those symlinks look somewhat inelegant to me.  :-)

Could we instead arrange so that the VM searches for those files in
their right place?  Often that involves substituting things like
“libfoo.so” in the code with the corresponding absolute file name (see
for example how this is done for Racket.)

Last question: does this Git checkout contain binaries, such as
Smalltalk images?  IOW, is this being built entirely from source, or is
it bootstrap from opaque binaries?  (I know that Pharo itself is or used
to be bootstrap from very old Smalltalk images and that work was ongoing
to get rid of them and have a nicer bootstrapping story.)

Thank you,
Ludo’.

  parent reply	other threads:[~2019-06-01 13:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 19:46 [bug#36033] Add Smalltalk Pharo VM Brian Woodcox
2019-05-31 23:30 ` Brian Woodcox
2019-05-31 23:33 ` Brian Woodcox
2019-06-01 13:23 ` Ludovic Courtès [this message]
2019-06-01 15:08   ` Brian Woodcox
2019-06-13  8:46     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ea5fnih.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=36033@debbugs.gnu.org \
    --cc=bw@inskydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).