From: Brett Gilio <brettg@posteo.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: bluekeys@bluekeys.eu, 38103@debbugs.gnu.org
Subject: [bug#38103] Dracula emacs theme
Date: Mon, 09 Dec 2019 22:50:17 -0600 [thread overview]
Message-ID: <877e34n5rq.fsf@posteo.net> (raw)
In-Reply-To: <87o8xjlca6.fsf@devup.no> (Marius Bakke's message of "Sun, 10 Nov 2019 21:14:09 +0100")
Marius Bakke <mbakke@fastmail.com> writes:
> bluekeys@bluekeys.eu writes:
>
>> Hi,
>>
>> Second attempt to attach the patch.
>
> Looks good!
>
> [...]
>
>> +(define-public emacs-dracula-theme
>> + (package
>> + (name "emacs-dracula-theme")
>> + (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/dracula/emacs.git")
>> + (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))
>
> Could add a (let (commit ...)) binding for the commit hash so we don't
> have to repeat it twice? See the surrounding packages for examples.
>
> Please also add a 'file-name' field here.
>
>> + (sha256
>> + (base32
>> + "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://draculatheme.com/emacs")
>> + (synopsis "A dark theme for emacs")
>
> Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.
>
>> + (description
>> + "A dark theme for emacs and 50+ apps")
>
> Can you expand a bit on the "50+ apps" part? Perhaps something along
> the lines of "Dracula is a dark color theme implemented for more than 50
> different applications. This package provides the Emacs theme."
>
> Can you send an updated patch? Thanks, and welcome! :-)
>
Hi Marius and bluekeys!
I just wanted to bump this so we can get it pushed. If you would like
some help, bluekeys please do not hesitate to ask us either here or on
the #guix Freenode IRC.
Also, when you send your revised patch do include yourself in the
copyright section of the header! You deserve that designation for your
contribution.
Thanks!
--
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/
next prev parent reply other threads:[~2019-12-10 4:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 14:13 [bug#38103] Dracula emacs theme bluekeys
2019-11-07 15:55 ` Mathieu Othacehe
2019-11-09 16:29 ` bluekeys
2019-11-10 20:14 ` Marius Bakke
2019-12-10 4:50 ` Brett Gilio [this message]
2020-06-02 5:19 ` bug#38103: " Michael Rohleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e34n5rq.fsf@posteo.net \
--to=brettg@posteo.net \
--cc=38103@debbugs.gnu.org \
--cc=bluekeys@bluekeys.eu \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).