unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 39873@debbugs.gnu.org
Subject: [bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get.
Date: Sun, 08 Mar 2020 23:58:51 +0000	[thread overview]
Message-ID: <877dzue6v8.fsf@cbaines.net> (raw)
In-Reply-To: <87wo7veulg.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> scribes:
>
>> * guix/scripts/substitute.scm (http-multiple-get): Add close-port call.
>> ---
>>  guix/scripts/substitute.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
>> index a88cb5bcfe..e3f5837a8e 100755
>> --- a/guix/scripts/substitute.scm
>> +++ b/guix/scripts/substitute.scm
>> @@ -544,6 +544,7 @@ initial connection on which HTTP requests are sent."
>>            (()
>>             (match (drop requests processed)
>>               (()
>> +              (close-port p)
>
> LGTM!
>
> Did you notice a file descriptor leak somewhere?

No, I was looking in to some wierd TLS related errors I had when using
http-multiple-get to query Curiass from the Guix Data Service, and I
noticed that maybe the port wasn't being closed when it should be.

I still haven't done a lot of testing, but I think some of these changes
have helped (although probably not this one).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2020-03-09  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 21:02 [bug#39873] [PATCH 0/3] http-multiple-get enhancements Christopher Baines
2020-03-02 21:07 ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Christopher Baines
2020-03-02 21:07   ` [bug#39873] [PATCH 2/3] substitute: Make http-multiple-get batch size configurable Christopher Baines
2020-03-07 21:13     ` Ludovic Courtès
2020-03-02 21:07   ` [bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get Christopher Baines
2020-03-07 21:14     ` Ludovic Courtès
2020-03-08 23:58       ` Christopher Baines [this message]
2020-03-07 21:12   ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Ludovic Courtès
2020-03-09  0:07     ` Christopher Baines
2020-04-26 18:40 ` bug#39873: [PATCH 0/3] http-multiple-get enhancements Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dzue6v8.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=39873@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).