From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41618)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jB2O7-0000jx-BJ
 for guix-patches@gnu.org; Sun, 08 Mar 2020 16:19:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jB2O6-00063O-Gf
 for guix-patches@gnu.org; Sun, 08 Mar 2020 16:19:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43341)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jB2O6-00063K-DZ
 for guix-patches@gnu.org; Sun, 08 Mar 2020 16:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jB2O6-0004SS-AR
 for guix-patches@gnu.org; Sun, 08 Mar 2020 16:19:02 -0400
Subject: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib.
Resent-Message-ID: <handler.39932.B39932.158369870117089@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200305191424.12134-1-kuba@kadziolka.net>
 <20200305192204.14973-1-kuba@kadziolka.net>
Date: Sun, 08 Mar 2020 21:18:12 +0100
In-Reply-To: <20200305192204.14973-1-kuba@kadziolka.net> ("Jakub
 \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\=
 message of "Thu, 5 Mar 2020 20:22:02 +0100")
Message-ID: <877dzua9dn.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Cc: 39932@debbugs.gnu.org

Hello,

Jakub K=C4=85dzio=C5=82ka <kuba@kadziolka.net> skribis:

> * gnu/packages/python-xyz.scm (python-distlib): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'build 'no-/bin/sh
> +           (lambda _
> +             (substitute* '("distlib/scripts.py" "tests/test_scripts.py")
> +               (("/bin/sh") (which "sh")))))
> +         (add-before 'check 'prepare-test-env
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             ;; NOTE: Any value works, the variable just has to be prese=
nt.
> +             (setenv "SKIP_ONLINE" "1"))))))

Please return #t from both phases, as is conventional.

Apart from that, all 3 patches LGTM!

Thanks,
Ludo=E2=80=99.