[bug#40021] gnu: Add mm-common.

[bug#40021] gnu: Add mm-common.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

Hello Guix!

Please find the attached patch to add 'mm-common' package to guix.

Regards,
Raghav "RG" Gururajan.

[-- Attachment #2: mm-common.patch --]
[-- Type: application/octet-stream, Size: 1814 bytes --]

From 16fbd81c36e57dbd9a4ccf464e812eb701cca59c Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 10 Mar 2020 18:56:24 -0400
Subject: [PATCH 2/2] gnu: Add mm-common.

* gnu/packages/gnome.scm (mm-common): New variable.
---
 gnu/packages/gnome.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6434c96dcc..77658049dd 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,33 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public mm-common
+  (package
+   (name "mm-common")
+   (version "1.0.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "1m4w33da9f4rx2d6kdj3ix3kl0gn16ml82v2mdn4hljr3q29nzdr"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t))
+   (native-inputs
+    `(("gettext" ,gettext-minimal)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("python" ,python)))
+   (synopsis "Module of GNOME C++ bindings")
+   (description "The mm-common module provides the build infrastructure and utilities
+shared among the GNOME C++ binding libraries.  Release archives of mm-common include
+the Doxygen tag file for the GNU C++ Library reference documentation.")
+   (home-page "https://gitlab.gnome.org/GNOME/mm-common")
+   (license license:gpl2+)))
+
 (define-public phodav
   (package
    (name "phodav")
-- 
2.25.1

[bug#40021] gnu: Add mm-common.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hi RG,

On Tue, 10 Mar 2020 23:01:00 +0000
"Raghav Gururajan" <raghavgururajan@disroot.org> wrote:

> Please find the attached patch to add 'mm-common' package to guix.

I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
the result using diffoscope there's no functional difference.

Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
doesn't do anything.

This package contains unpatched references to perl, git, ln and other
programs, which means that those programs are looked up in $PATH and
most probably will not be found.

It also contains patched references to python.

That's not consistent.

Please research what the package is supposed to do.  If perl, git and
ln are internally required modules, let's patch them.

If they are external "composing" modules, let's leave them as-is.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40021] gnu: Add mm-common.

[Raghav Gururajan]

Hi Danny!

Thanks for the information. I will get back to you regarding the modules.

I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.

Resolving gcc.gnu.org (gcc.gnu.org)... failed: Name or service not known.
wget: unable to resolve host address ?gcc.gnu.org?

Regards,
RG.

[bug#40021] gnu: Add mm-common.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hi Danny!
>
> Thanks for the information. I will get back to you regarding the modules.
>
> I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.
>
> Resolving gcc.gnu.org (gcc.gnu.org)... failed: Name or service not known.
> wget: unable to resolve host address ?gcc.gnu.org?

It is not possible to enable network access inside the build container.
If it were, build processes would no longer be deterministic, and we
would lose a lot of reproducibility guarantees!

You'll need to supply whatever external resources the package needs as
"native-inputs", and then tell the build system how to access those
inputs instead of downloading them from the network.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#40021] gnu: Add mm-common.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi Raghav,

On Thu, 19 Mar 2020 06:34:29 +0000
"Raghav Gururajan" <raghavgururajan@disroot.org> wrote:

> I also noticed that I didn't enable a build option that downloads gcc tag files. Can you help me with how to provide network access inside build container/process? The wget is unable to resolve domain name.

It is very dangerous to use wget for stuff like that.  For example the usual cryptographic signature check is skipped--which means that anyone could replace it by a bad version and nobody would notice.

I would advise to instead add it as "origin" in "native-inputs" and copy it manually.
That way its sha256 sum will be checked.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40021] gnu: Add mm-common.

[Raghav Gururajan]

Hi Danny!

> It is very dangerous to use wget for stuff like that. For example the usual cryptographic signature
> check is skipped--which means that anyone could replace it by a bad version and nobody would
> notice.

Ah yes, you are right.

> I would advise to instead add it as "origin" in "native-inputs" and copy it manually.
> That way its sha256 sum will be checked.

That's a good idea. Could you help with a generic syntax for adding origin inside inputs?

Thank you!

Regards,
RG.

[bug#40021] gnu: Add mm-common.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

(native-inputs `(
         ("foobar"
          ,(origin
             (method git-fetch)
             (uri (git-reference
                   (url "https://foo/bar")
                   (commit (string-append "v" version))))
             (file-name (git-file-name "foo" version))
             (sha256
              (base32 "0i7gh99w4mi0hdv16261jcdiqyv1nkjdcwy9prw32s0lvplx8fdy")))))

then in a phase:

  (copy-recursively (assoc-ref native-inputs "foobar") target)

  (if it's from git)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40021] gnu: Add mm-common.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

Hi Danny!

> I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
> the result using diffoscope there's no functional difference.
> 
> Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
> doesn't do anything.

You are right, it is not required for this package.

> This package contains unpatched references to perl, git, ln and other
> programs, which means that those programs are looked up in $PATH and
> most probably will not be found.
> 
> It also contains patched references to python.
> 
> That's not consistent.
> 
> Please research what the package is supposed to do. If perl, git and
> ln are internally required modules, let's patch them.
> 
> If they are external "composing" modules, let's leave them as-is.

I have checked and they are not internally required. Only python is required which is already patched. :-)

Please find the revised patch, attached with this email.

Regards,
RG.

[-- Attachment #2: 0018-gnu-Add-mm-common.patch --]
[-- Type: application/octet-stream, Size: 1799 bytes --]

From 88c9917dff5c5d5a589c0c0daedaed8c6a478103 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 5 Apr 2020 00:01:52 -0400
Subject: [PATCH 18/18] gnu: Add mm-common

* gnu/packages/gnome.scm (mm-common): New variable.
---
 gnu/packages/gnome.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6178ee1010..a14502f940 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -249,6 +249,32 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public mm-common
+  (package
+    (name "mm-common")
+    (version "1.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1m4w33da9f4rx2d6kdj3ix3kl0gn16ml82v2mdn4hljr3q29nzdr"))))
+    (build-system meson-build-system)
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("python" ,python)))
+    (synopsis "Module of GNOME C++ bindings")
+    (description "The mm-common module provides the build infrastructure
+and utilities shared among the GNOME C++ binding libraries.  Release
+archives of mm-common include the Doxygen tag file for the GNU C++
+Library reference documentation.")
+    (home-page "https://gitlab.gnome.org/GNOME/mm-common")
+    (license license:gpl2+)))
+
 (define-public phodav
   (package
    (name "phodav")
-- 
2.26.0

bug#40021: gnu: Add mm-common.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

/gnu/store/cxlagy3f68pg1rxhx101c62jv76iss9k-mm-common-1.0.0/bin/mm-common-prepare
contains references to both cp and ln, without store path.

That means either they won't work or it will have some spooky dependency to
coreutils that is not declared.

I've pushed a variant to guix master as
commit 4e8bdbf853f1f7e01e18f50c95204c0f39e6edba.

Changes are:

* Make sure to refer to coreutils and sed explicitly (non-native input now... hmm).

Pushed follow-up moving coreutils and sed to regular inputs to guix master
as commit 74a658857345b564fe0eb8e38c64044b5432289c.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]