From: Marius Bakke <mbakke@fastmail.com>
To: Jean-Baptiste Note <jean-baptiste.note@m4x.org>
Cc: 41032-done@debbugs.gnu.org
Subject: bug#41032: [PATCH] Add makepasswd package
Date: Wed, 06 May 2020 22:29:58 +0200 [thread overview]
Message-ID: <877dxo4xix.fsf@devup.no> (raw)
In-Reply-To: <87zhamw75k.fsf@m4x.org>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
Jean-Baptiste Note <jean-baptiste.note@m4x.org> writes:
> Hi Marius,
>
> Thanks for your review and the heads up on the correct file.
> Please find an updated patch.
>
> I've used guix-devel-mode and ran indent-according-to-mode on the buffer
> before producing the patch; let me know if this is not sufficient to
> correctly indent the code :)
Thanks! My Emacs agrees, so LGTM.
[...]
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (delete 'configure))
> + #:make-flags (list "CC=gcc" (string-append "PREFIX=" (assoc-ref %outputs "out")))
I moved the second flag to its own line as 89 characters is a bit much.
> + #:tests? #f))
And added a comment about why tests are disabled.
> + (synopsis "Generate (pseudo-)random passwords and hashes")
> + (description
> + "Makepasswd is a program that generates pseudo-random passwords of a
> +desired length. It can also generate their corresponding hashes for a given
> +encryption algorithm if so desired.")
> + (home-page "https://github.com/khorben/makepasswd")
> + (license license:gpl3))))
Indeed GPL3 only :-/
Applied!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2020-05-06 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 20:37 [bug#41032] [PATCH] Add makepasswd package Jean-Baptiste Note
2020-05-05 16:49 ` Marius Bakke
2020-05-05 18:47 ` Jean-Baptiste Note
2020-05-06 20:29 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dxo4xix.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=41032-done@debbugs.gnu.org \
--cc=jean-baptiste.note@m4x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).