From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id APT0FlgTzV5kVgAA0tVLHw (envelope-from ) for ; Tue, 26 May 2020 13:02:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +IbSElgTzV7fEwAA1q6Kng (envelope-from ) for ; Tue, 26 May 2020 13:02:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D882B940983 for ; Tue, 26 May 2020 13:02:15 +0000 (UTC) Received: from localhost ([::1]:34292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdZDi-000558-Mi for larch@yhetil.org; Tue, 26 May 2020 09:02:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdZDa-00054p-HO for guix-patches@gnu.org; Tue, 26 May 2020 09:02:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdZDW-0000gJ-Nd for guix-patches@gnu.org; Tue, 26 May 2020 09:02:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdZDW-0007ss-Lg for guix-patches@gnu.org; Tue, 26 May 2020 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41395] [PATCH 1/2] gnu: python-prompt-toolkit: Update to 3.0.5 Resent-From: Edouard Klein Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 May 2020 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41395 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41395@debbugs.gnu.org Received: via spool by 41395-submit@debbugs.gnu.org id=B41395.159049806730198 (code B ref 41395); Tue, 26 May 2020 13:02:02 +0000 Received: (at 41395) by debbugs.gnu.org; 26 May 2020 13:01:07 +0000 Received: from localhost ([127.0.0.1]:44394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdZCd-0007qu-8h for submit@debbugs.gnu.org; Tue, 26 May 2020 09:01:07 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdVtE-0000QS-Oy for 41395@debbugs.gnu.org; Tue, 26 May 2020 05:28:53 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1590485330; cv=none; d=zohomail.com; s=zohoarc; b=aOm9vfXEh2kNHqwDPHZrxEleRrs1AgcjccBq+VPjiTLFE4/9DbUchvGWQKbjgxMz/uRjTTm5niVbFEi9Y1T09vRTIuQRSGcRsTMPJj9OF+0WCl5gMpTBRSr406b6lgnmCB9kFsPINX1kgqdTmMenYusOX1NCGph5MS7Hc/Wsyec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590485330; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=nDaxxO/XCJLycbPE6iIlAYUUtFP4z1TytU1dpAUa4fQ=; b=Gy0i2L1v/OrCyiweuu5LdNQRda4WkFj9Ixl+UvSd8JNYJn0XpK4G0aLj+t7T+9eXRYaM/PkF+8+uKzAkZhdEm9xb8CYMYJHELAMS+irv4b9UYQlzv/NbC8SVGwvs3mC1G0Fn/u8Vf96OvNo0QbbRvwhNuIOmZDhYyFJG2/qFaJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1590485330; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=nDaxxO/XCJLycbPE6iIlAYUUtFP4z1TytU1dpAUa4fQ=; b=DmC7WgmYtw7b1jair+7noBWTcBZhQMTakaOQfcyaKOLh8o2XCg4/uGnYJhyKzbWa G6QeYzA3PcIAukolgdHxIgpSse43qSe+yoRA4wxCRNnFGwGkqSmkYfi/Pq5k0YZKnfG 2JQLzIrAuupzc1p9QiYCKvC2jXVFkt66Q0uTsMxI= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1590485327769727.3269771387086; Tue, 26 May 2020 02:28:47 -0700 (PDT) References: <87v9ksckt3.fsf@alice.lan> <87sgfwcklx.fsf@alice.lan> <87wo527b41.fsf@devup.no> <87pnasi8w7.fsf@alice.lan> <871rn77j0z.fsf@gnu.org> User-agent: mu4e 1.4.6; emacs 26.3 From: Edouard Klein In-reply-to: <871rn77j0z.fsf@gnu.org> Message-ID: <877dwzyri2.fsf@alice.lan> Date: Tue, 26 May 2020 11:28:37 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 26 May 2020 09:01:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=rdklein.fr header.s=zoho header.b=DmC7WgmY; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.99 X-TUID: Sy8hJjPMxWxy Marius Bakke writes: > Edouard Klein writes: > >>>> (synopsis "Interpretable Machine Learning (iML) package") >>>> (description "Interpretable ML (iML) is a set of data type objects, >>>> visualizations, and interfaces that can be used by any method designed to >>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >>>> index b8a51570c3..5fd7e274e9 100644 >>>> --- a/gnu/packages/python-xyz.scm >>>> +++ b/gnu/packages/python-xyz.scm >>>> @@ -8922,6 +8922,7 @@ interactive computing.") >>>> (build-system python-build-system) >>>> (propagated-inputs >>>> `(("python-ipykernel" ,python-ipykernel) >>>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>>> ("python-notebook" ,python-notebook))) >>>> (native-inputs >>>> `(("python-certifi" ,python-certifi) >>>> @@ -8950,6 +8951,7 @@ notebooks.") >>>> (propagated-inputs >>>> `(("python-ipython" ,python-ipython) >>>> ("python-traitlets" ,python-traitlets) >>>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>>> ("python-widgetsnbextension" ,python-widgetsnbextension))) >>>> (native-inputs >>>> `(("python-nose" ,python-nose) >>>> @@ -8980,7 +8982,7 @@ in the data.") >>>> (propagated-inputs >>>> `(("python-ipykernel" ,python-ipykernel) >>>> ("python-jupyter-client" ,python-jupyter-client) >>>> - ("python-prompt-toolkit" ,python-prompt-toolkit) >>>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>>> ("python-pygments" ,python-pygments))) >>>> (native-inputs >>>> `(("python-nose" ,python-nose))) >>>> @@ -12049,6 +12051,44 @@ collections of data.") >>>> (package-with-python2 python-backpack)) >>> >>> It would be great to update these packages instead of pinning to the old >>> version. I won't blame you if you don't feel like embarking on that >>> journey though. >>> >> >> In the new patches I'm about to send, I updated them. Alas even their >> latest versions still require python-prompt-toolkit <=2.1, so I had to >> pin the dependencies. I did it in a cleaner way, though. > > Oh too bad that updating did not work. Terrible that these are so tied > to the version of python-prompt-toolkit. Can you split those updates > out to separate patches, preceding the prompt-toolkit patch? Then they > can be reverted and tested individually without having to revert the > whole thing in case there are problems. > Of course :) I should have thought about it, sorry. >>>> +(define-public python-prompt-toolkit-2 >>>> (package >>>> (name "python-prompt-toolkit") >>>> (version "2.0.7") >>>> @@ -12077,7 +12117,7 @@ collections of data.") >>>> ("python-pygments" ,python-pygments))) >>>> (native-inputs >>>> `(("python-pytest" ,python-pytest))) >>>> - (home-page "https://github.com/jonathanslenders/python-prompt-toolkit") >>>> + (home-page "https://github.com/prompt-toolkit/python-prompt-toolkit") >>>> (synopsis "Library for building command line interfaces in Python") >>>> (description >>>> "Prompt-Toolkit is a library for building interactive command line >>>> @@ -12104,6 +12144,10 @@ characters, mouse support, and auto suggestions.") >>>> (define-public python2-prompt-toolkit-1 >>>> (package-with-python2 python-prompt-toolkit-1)) >>>> >>>> +(define-public prompt-toolkit-2-instead-of-prompt-toolkit >>>> + (package-input-rewriting/spec >>>> + `(("python-prompt-toolkit" . ,(const python-prompt-toolkit-2))))) >>> >>> Is this actually necessary? Just changing the inputs as you did above >>> should be sufficient I think. >> >> If one dependency is OK with python-prompt-toolkit in version 3, but a >> package has an implicit dependency on python-prompt-toolkit in version >> 2, then we either have to pin them all to version 2, and the OK >> dependency does not get to envoy the update, or we have to resort to this. >> >> I did it because python-ipython (19 dependents) is OK with >> the update, and I did not want to pin it (and all its dependents) to python-prompt-toolkit-2. >> >> This is my first time making such an involved update, so I'm open to >> suggestions as to alternative ways of doing this. > > Oh I see, makes sense. The new patch is much clearer. I will send a > separate reply with further comments.