* [bug#40753] gnu: spacefm: Add missing dependencies.
@ 2020-04-21 21:28 Raghav Gururajan
2020-04-22 0:15 ` [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2) Raghav Gururajan
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-21 21:28 UTC (permalink / raw)
To: 40753
[-- Attachment #1: Type: text/plain, Size: 29 bytes --]
BLOCKERS: #40630 and #40752.
[-- Attachment #2: 0003-gnu-spacefm-Add-missing-dependencies.patch --]
[-- Type: text/x-patch, Size: 3910 bytes --]
From fac881e2820c08e09c8f3e42699ba25b8b9f4004 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 21 Apr 2020 17:23:21 -0400
Subject: [PATCH 3/3] gnu: spacefm: Add missing dependencies.
* gnu/packages/lxde.scm (spacefm): Add missing dependencies.
---
gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------
1 file changed, 36 insertions(+), 14 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index f5dc027e03..eeb9feb745 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -29,13 +29,16 @@
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages disk)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages file-systems)
#:use-module (gnu packages freedesktop)
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image-viewers)
+ #:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
#:use-module (gnu packages lsof)
#:use-module (gnu packages openbox)
@@ -43,9 +46,12 @@
#:use-module (gnu packages polkit)
#:use-module (gnu packages text-editors)
#:use-module (gnu packages video)
+ #:use-module (gnu packages wget)
#:use-module (gnu packages wm)
#:use-module (gnu packages xml)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system trivial)
#:use-module (guix download)
@@ -249,8 +255,8 @@ with freedesktop.org standard.")
"https://github.com/IgnorantGuru/spacefm/archive/"
version ".tar.gz"))
(sha256
- (base32
- "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
+ (base32
+ "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
(modules '((guix build utils)))
(snippet
'(begin
@@ -262,18 +268,34 @@ with freedesktop.org standard.")
"#include <sys/sysmacros.h>\n")))
#t))
(file-name (string-append name "-" version ".tar.gz"))))
- (build-system gnu-build-system)
- (native-inputs `(("pkg-config" ,pkg-config)
- ("desktop-file-utils" ,desktop-file-utils)
- ("intltool" ,intltool)))
- (inputs `(("bash" ,bash)
- ("gtk+" ,gtk+)
- ("eudev" ,eudev)
- ("shared-mime-info" ,shared-mime-info)
- ("ffmpegthumbnailer" ,ffmpegthumbnailer)
- ("jmtpfs" ,jmtpfs)
- ("lsof" ,lsof)
- ("udisks" ,udisks)))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("desktop-file-utils" ,desktop-file-utils)
+ ("glib:bin" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
+ ("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("bash" ,bash)
+ ("cairo" ,cairo)
+ ("curlftpfs" ,curlftpfs)
+ ("dbus" ,dbus)
+ ("eject" ,eject)
+ ("eudev" ,eudev)
+ ("fakeroot" ,fakeroot)
+ ("ffmpegthumbnailer" ,ffmpegthumbnailer)
+ ("fuseiso" ,fuseiso)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("ifuse" ,ifuse)
+ ("jmtpfs" ,jmtpfs)
+ ("libx11" ,libx11)
+ ("lsof" ,lsof)
+ ("pango" ,pango)
+ ("shared-mime-info" ,shared-mime-info)
+ ("startup-notification" ,startup-notification)
+ ("udevil" ,udevil)
+ ("wget" ,wget)))
(arguments
`(#:configure-flags (list (string-append "--with-bash-path="
(assoc-ref %build-inputs "bash")
--
2.26.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2)
2020-04-21 21:28 [bug#40753] gnu: spacefm: Add missing dependencies Raghav Gururajan
@ 2020-04-22 0:15 ` Raghav Gururajan
2020-04-22 6:46 ` [bug#40753] gnu: spacefm: Add missing dependencies Jan Nieuwenhuizen
2020-04-24 19:35 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) Raghav Gururajan
2 siblings, 0 replies; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-22 0:15 UTC (permalink / raw)
To: 40753
[-- Attachment #1: Type: text/plain, Size: 37 bytes --]
BLOCKERS: #40630, #40752 and #40756.
[-- Attachment #2: 0004-gnu-spacefm-Add-and-configure-missing-dependencies.patch --]
[-- Type: text/x-patch, Size: 5610 bytes --]
From 43cd81fdbe7522cd5ed7f638e49438bfd1a2ccff Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 21 Apr 2020 20:10:50 -0400
Subject: [PATCH 4/4] gnu: spacefm: Add and configure missing dependencies.
* gnu/packages/lxde.scm (spacefm): Add and configure missing dependencies.
---
gnu/packages/lxde.scm | 81 ++++++++++++++++++++++++++++++++-----------
1 file changed, 61 insertions(+), 20 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index f5dc027e03..e6fc5b14c8 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -27,15 +27,19 @@
(define-module (gnu packages lxde)
#:use-module (gnu packages)
+ #:use-module (gnu packages admin)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages disk)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages file-systems)
#:use-module (gnu packages freedesktop)
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image-viewers)
+ #:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
#:use-module (gnu packages lsof)
#:use-module (gnu packages openbox)
@@ -43,9 +47,12 @@
#:use-module (gnu packages polkit)
#:use-module (gnu packages text-editors)
#:use-module (gnu packages video)
+ #:use-module (gnu packages wget)
#:use-module (gnu packages wm)
#:use-module (gnu packages xml)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system trivial)
#:use-module (guix download)
@@ -249,8 +256,8 @@ with freedesktop.org standard.")
"https://github.com/IgnorantGuru/spacefm/archive/"
version ".tar.gz"))
(sha256
- (base32
- "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
+ (base32
+ "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
(modules '((guix build utils)))
(snippet
'(begin
@@ -262,25 +269,59 @@ with freedesktop.org standard.")
"#include <sys/sysmacros.h>\n")))
#t))
(file-name (string-append name "-" version ".tar.gz"))))
- (build-system gnu-build-system)
- (native-inputs `(("pkg-config" ,pkg-config)
- ("desktop-file-utils" ,desktop-file-utils)
- ("intltool" ,intltool)))
- (inputs `(("bash" ,bash)
- ("gtk+" ,gtk+)
- ("eudev" ,eudev)
- ("shared-mime-info" ,shared-mime-info)
- ("ffmpegthumbnailer" ,ffmpegthumbnailer)
- ("jmtpfs" ,jmtpfs)
- ("lsof" ,lsof)
- ("udisks" ,udisks)))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("desktop-file-utils" ,desktop-file-utils)
+ ("glib:bin" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
+ ("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("bash" ,bash)
+ ("cairo" ,cairo)
+ ("curlftpfs" ,curlftpfs)
+ ("dbus" ,dbus)
+ ("eject" ,eject)
+ ("eudev" ,eudev)
+ ("fakeroot" ,fakeroot)
+ ("ffmpegthumbnailer" ,ffmpegthumbnailer)
+ ("fuseiso" ,fuseiso)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("ifuse" ,ifuse)
+ ("jmtpfs" ,jmtpfs)
+ ("ktsuss" ,ktsuss)
+ ("libx11" ,libx11)
+ ("lsof" ,lsof)
+ ("pango" ,pango)
+ ("shared-mime-info" ,shared-mime-info)
+ ("startup-notification" ,startup-notification)
+ ("sudo" ,sudo)
+ ("udevil" ,udevil)
+ ("wget" ,wget)))
(arguments
- `(#:configure-flags (list (string-append "--with-bash-path="
- (assoc-ref %build-inputs "bash")
- "/bin/bash")
- (string-append "--sysconfdir="
- (assoc-ref %outputs "out")
- "/etc"))))
+ `(#:configure-flags (list
+ (string-append "--with-bash-path="
+ (assoc-ref %build-inputs "bash")
+ "/bin/bash")
+ (string-append "--sysconfdir="
+ (assoc-ref %outputs "out")
+ "/etc"))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda _
+ (substitute* "etc/spacefm.conf"
+ (("#terminal_su=/bin/su")
+ (string-append "terminal_su="
+ (string-append (assoc-ref %build-inputs "sudo")
+ "/bin/sudo"))))
+ (substitute* "etc/spacefm.conf"
+ (("#graphical_su=/usr/bin/gksu")
+ (string-append "graphical_su="
+ (string-append (assoc-ref %build-inputs "ktsuss")
+ "/bin/ktsuss"))))
+ #t)))))
(home-page "https://ignorantguru.github.io/spacefm/")
(synopsis "Multi-panel tabbed file manager")
(description "SpaceFM is a graphical, multi-panel, tabbed file manager
--
2.26.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add missing dependencies.
2020-04-21 21:28 [bug#40753] gnu: spacefm: Add missing dependencies Raghav Gururajan
2020-04-22 0:15 ` [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2) Raghav Gururajan
@ 2020-04-22 6:46 ` Jan Nieuwenhuizen
2020-04-22 16:28 ` Raghav Gururajan
2020-04-24 19:35 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) Raghav Gururajan
2 siblings, 1 reply; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-22 6:46 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753
Raghav Gururajan writes:
Hello!
> BLOCKERS: #40630 and #40752.
...what does this mean?
>>From fac881e2820c08e09c8f3e42699ba25b8b9f4004 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Tue, 21 Apr 2020 17:23:21 -0400
> Subject: [PATCH 3/3] gnu: spacefm: Add missing dependencies.
> * gnu/packages/lxde.scm (spacefm): Add missing dependencies.
It builds OK without this patch; it does not seem that any dependencies
are missing. Could it be that these dependencies change or amend its
behaviour?
After applying this patch, spacefm does not build for me, I get
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build spacefm
ice-9/eval.scm:223:20: In procedure proc:
error: eject: unbound variable
hint: Did you forget a `use-modules' form?
--8<---------------cut here---------------end--------------->8---
I am feeling a bit uncomfortable about the fact that you pinged me to
"push" this patch, it seems it needs a bit more attention than that.
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add missing dependencies.
2020-04-22 6:46 ` [bug#40753] gnu: spacefm: Add missing dependencies Jan Nieuwenhuizen
@ 2020-04-22 16:28 ` Raghav Gururajan
2020-04-22 17:59 ` Jan Nieuwenhuizen
0 siblings, 1 reply; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-22 16:28 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753
Hi Jan!
> > BLOCKERS: #40630 and #40752.
>
> ...what does this mean?
They are dependencies of this patch, that needs to be pushed before this patch.
> It builds OK without this patch; it does not seem that any dependencies
> are missing. Could it be that these dependencies change or amend its
> behaviour?
It is to change and amend the behaviour. It adds missing features and fixes
icons+privilege-management+disk-management.
> After applying this patch, spacefm does not build for me, I get
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build spacefm
> ice-9/eval.scm:223:20: In procedure proc:
> error: eject: unbound variable
> hint: Did you forget a `use-modules' form?
> --8<---------------cut here---------------end--------------->8---
That's correct. Eject is provided by one of the blockers.
> I am feeling a bit uncomfortable about the fact that you pinged me to
> "push" this patch, it seems it needs a bit more attention than that.
I apologize. I spent whole day to create these patches and throughly testing
them. If I missed anything, please understand it would not have been
intentional. Also, there is a v2 patch in #40753 thread that has 3 blockers.
Thank you for considering my request.
Regards,
RG.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add missing dependencies.
2020-04-22 16:28 ` Raghav Gururajan
@ 2020-04-22 17:59 ` Jan Nieuwenhuizen
2020-04-22 20:22 ` [bug#40753] gnu: spacefm: Add missing dependencies. (v3) Raghav Gururajan
0 siblings, 1 reply; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-22 17:59 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753
Raghav Gururajan writes:
Hello Raghav,
>> > BLOCKERS: #40630 and #40752.
>>
>> ...what does this mean?
>
> They are dependencies of this patch, that needs to be pushed before
> this patch.
Right. So we'll have to wait for those then, right?
>> It builds OK without this patch; it does not seem that any dependencies
>> are missing. Could it be that these dependencies change or amend its
>> behaviour?
>
> It is to change and amend the behaviour. It adds missing features and fixes
> icons+privilege-management+disk-management.
Okay, it would be nice to say something about that in the commit
message. What about
gnu: spacefm: Add dependencies for extra functionality.
Adding these inputs provides adds icons, privilege-management and
disk-management.
Other than that, LGTM (assuming that it builds). I'm not really able
to test it, I assume it works for you as you expected?
>> I am feeling a bit uncomfortable about the fact that you pinged me to
>> "push" this patch, it seems it needs a bit more attention than that.
>
> I apologize. I spent whole day to create these patches and throughly testing
> them. If I missed anything, please understand it would not have been
> intentional. Also, there is a v2 patch in #40753 thread that has 3 blockers.
>
> Thank you for considering my request.
No worries! I did not have much time this morning and from your ping
assumed a trivial task. Teaches me not to assume things.
I would suggest that when you get an OK on the last dependency for this
one, you mention this patch again.
Please consider sending patches that depend on eachother in one bug
report if that makes sense.
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add missing dependencies. (v3)
2020-04-22 17:59 ` Jan Nieuwenhuizen
@ 2020-04-22 20:22 ` Raghav Gururajan
0 siblings, 0 replies; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-22 20:22 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
Hi Jan!
> Right. So we'll have to wait for those then, right?
Pardon me, I should have communicated better. I was asking to push including
the blockers. Would you be able to please? If not, that's okay.
> Okay, it would be nice to say something about that in the commit
> message. What about
>
> gnu: spacefm: Add dependencies for extra functionality.
>
> Adding these inputs provides adds icons, privilege-management and
> disk-management.
Thanks. Please find the revised patch attached with this email.
> Other than that, LGTM (assuming that it builds). I'm not really able
> to test it, I assume it works for you as you expected?
Yes, all works good. :-)
> No worries! I did not have much time this morning and from your ping
> assumed a trivial task. Teaches me not to assume things.
No, you did not do anything wrong. I should have communicated better.
> I would suggest that when you get an OK on the last dependency for this
> one, you mention this patch again.
Sure. But let me know if you would be able to process the blockers as well.
> Please consider sending patches that depend on eachother in one bug
> report if that makes sense.
Sorry, I did not plan on fixing spacefm. I came across the issues with spacefm
after sending those other patches.
Regards,
RG.
[-- Attachment #2: 0004-gnu-spacefm-Add-dependencies-for-extra-functionality.patch --]
[-- Type: text/x-patch, Size: 4076 bytes --]
From b4f659e7c43eebb4f27f5c1d208a0326d7f2e6a6 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Wed, 22 Apr 2020 16:15:34 -0400
Subject: [PATCH 4/4] gnu: spacefm: Add dependencies for extra functionality.
* gnu/packages/lxde.scm (spacefm): Add dependencies for extra functionality.
Adding these inputs and making required changes to build-system+arguments;
provides icons, privilege-management and disk-management.
---
gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------
1 file changed, 36 insertions(+), 14 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index f5dc027e03..eeb9feb745 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -29,13 +29,16 @@
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages disk)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages file-systems)
#:use-module (gnu packages freedesktop)
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image-viewers)
+ #:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
#:use-module (gnu packages lsof)
#:use-module (gnu packages openbox)
@@ -43,9 +46,12 @@
#:use-module (gnu packages polkit)
#:use-module (gnu packages text-editors)
#:use-module (gnu packages video)
+ #:use-module (gnu packages wget)
#:use-module (gnu packages wm)
#:use-module (gnu packages xml)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system trivial)
#:use-module (guix download)
@@ -249,8 +255,8 @@ with freedesktop.org standard.")
"https://github.com/IgnorantGuru/spacefm/archive/"
version ".tar.gz"))
(sha256
- (base32
- "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
+ (base32
+ "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
(modules '((guix build utils)))
(snippet
'(begin
@@ -262,18 +268,34 @@ with freedesktop.org standard.")
"#include <sys/sysmacros.h>\n")))
#t))
(file-name (string-append name "-" version ".tar.gz"))))
- (build-system gnu-build-system)
- (native-inputs `(("pkg-config" ,pkg-config)
- ("desktop-file-utils" ,desktop-file-utils)
- ("intltool" ,intltool)))
- (inputs `(("bash" ,bash)
- ("gtk+" ,gtk+)
- ("eudev" ,eudev)
- ("shared-mime-info" ,shared-mime-info)
- ("ffmpegthumbnailer" ,ffmpegthumbnailer)
- ("jmtpfs" ,jmtpfs)
- ("lsof" ,lsof)
- ("udisks" ,udisks)))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("desktop-file-utils" ,desktop-file-utils)
+ ("glib:bin" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
+ ("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("bash" ,bash)
+ ("cairo" ,cairo)
+ ("curlftpfs" ,curlftpfs)
+ ("dbus" ,dbus)
+ ("eject" ,eject)
+ ("eudev" ,eudev)
+ ("fakeroot" ,fakeroot)
+ ("ffmpegthumbnailer" ,ffmpegthumbnailer)
+ ("fuseiso" ,fuseiso)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("ifuse" ,ifuse)
+ ("jmtpfs" ,jmtpfs)
+ ("libx11" ,libx11)
+ ("lsof" ,lsof)
+ ("pango" ,pango)
+ ("shared-mime-info" ,shared-mime-info)
+ ("startup-notification" ,startup-notification)
+ ("udevil" ,udevil)
+ ("wget" ,wget)))
(arguments
`(#:configure-flags (list (string-append "--with-bash-path="
(assoc-ref %build-inputs "bash")
--
2.26.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3)
2020-04-21 21:28 [bug#40753] gnu: spacefm: Add missing dependencies Raghav Gururajan
2020-04-22 0:15 ` [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2) Raghav Gururajan
2020-04-22 6:46 ` [bug#40753] gnu: spacefm: Add missing dependencies Jan Nieuwenhuizen
@ 2020-04-24 19:35 ` Raghav Gururajan
2020-04-24 20:09 ` Jan Nieuwenhuizen
2 siblings, 1 reply; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-24 19:35 UTC (permalink / raw)
To: 40753
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 0002-gnu-spacefm-Add-dependencies-for-extra-functionality.patch --]
[-- Type: text/x-patch, Size: 4086 bytes --]
From c8ffa0953bd26a4ce22cae17b55d0392908b0f71 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Fri, 24 Apr 2020 15:33:15 -0400
Subject: [PATCH 2/2] gnu: spacefm: Add dependencies for extra functionality.
* gnu/packages/lxde.scm (spacefm): Add dependencies for extra functionality.
Adding these inputs and making required changes to build-system+arguments;
provides icons, privilege-management and disk-management.
---
gnu/packages/lxde.scm | 50 +++++++++++++++++++++++++++++++------------
1 file changed, 36 insertions(+), 14 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index f5dc027e03..1ddac97dee 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -29,13 +29,16 @@
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages disk)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages file-systems)
#:use-module (gnu packages freedesktop)
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image-viewers)
+ #:use-module (gnu packages libusb)
#:use-module (gnu packages linux)
#:use-module (gnu packages lsof)
#:use-module (gnu packages openbox)
@@ -43,9 +46,12 @@
#:use-module (gnu packages polkit)
#:use-module (gnu packages text-editors)
#:use-module (gnu packages video)
+ #:use-module (gnu packages wget)
#:use-module (gnu packages wm)
#:use-module (gnu packages xml)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system trivial)
#:use-module (guix download)
@@ -249,8 +255,8 @@ with freedesktop.org standard.")
"https://github.com/IgnorantGuru/spacefm/archive/"
version ".tar.gz"))
(sha256
- (base32
- "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
+ (base32
+ "1jg7xfyr7kihjnalxp8wxyb9qjk8hqf5l36rp3s0lvkpmpyakppy"))
(modules '((guix build utils)))
(snippet
'(begin
@@ -262,18 +268,34 @@ with freedesktop.org standard.")
"#include <sys/sysmacros.h>\n")))
#t))
(file-name (string-append name "-" version ".tar.gz"))))
- (build-system gnu-build-system)
- (native-inputs `(("pkg-config" ,pkg-config)
- ("desktop-file-utils" ,desktop-file-utils)
- ("intltool" ,intltool)))
- (inputs `(("bash" ,bash)
- ("gtk+" ,gtk+)
- ("eudev" ,eudev)
- ("shared-mime-info" ,shared-mime-info)
- ("ffmpegthumbnailer" ,ffmpegthumbnailer)
- ("jmtpfs" ,jmtpfs)
- ("lsof" ,lsof)
- ("udisks" ,udisks)))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("desktop-file-utils" ,desktop-file-utils)
+ ("glib:bin" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
+ ("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("bash" ,bash)
+ ("cairo" ,cairo)
+ ("curlftpfs" ,curlftpfs)
+ ("dbus" ,dbus)
+ ("eudev" ,eudev)
+ ("fakeroot" ,fakeroot)
+ ("ffmpegthumbnailer" ,ffmpegthumbnailer)
+ ("fuseiso" ,fuseiso)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("ifuse" ,ifuse)
+ ("jmtpfs" ,jmtpfs)
+ ("libx11" ,libx11)
+ ("lsof" ,lsof)
+ ("pango" ,pango)
+ ("shared-mime-info" ,shared-mime-info)
+ ("startup-notification" ,startup-notification)
+ ("udevil" ,udevil)
+ ("util-linux" ,util-linux)
+ ("wget" ,wget)))
(arguments
`(#:configure-flags (list (string-append "--with-bash-path="
(assoc-ref %build-inputs "bash")
--
2.26.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3)
2020-04-24 19:35 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) Raghav Gururajan
@ 2020-04-24 20:09 ` Jan Nieuwenhuizen
2020-04-26 2:11 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality Raghav Gururajan
0 siblings, 1 reply; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-24 20:09 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753
Raghav Gururajan writes:
Hi Raghav,
Pushed to master with small cosmetic change below.
Thanks for the patch!
janneke
>>From c8ffa0953bd26a4ce22cae17b55d0392908b0f71 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Fri, 24 Apr 2020 15:33:15 -0400
> Subject: [PATCH 2/2] gnu: spacefm: Add dependencies for extra functionality.
> #:use-module (gnu packages wm)
> #:use-module (gnu packages xml)
> + #:use-module (gnu packages xdisorg)
> #:use-module (gnu packages xorg)
Changed this to
#:use-module (gnu packages wm)
#:use-module (gnu packages xdisorg)
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-24 20:09 ` Jan Nieuwenhuizen
@ 2020-04-26 2:11 ` Raghav Gururajan
2020-04-26 14:00 ` Jan Nieuwenhuizen
0 siblings, 1 reply; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-26 2:11 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
Hi Jan!
> Pushed to master with small cosmetic change below.
>
> Thanks for the patch!
I accidentally sent the wrong patch that missed some things. So sorry. I have
attached a patch with this email to append the previous. Could you please push
it as new commit. Thanks!
Regards,
RG.
[-- Attachment #2: 0001-gnu-spacefm-Fix-privilege-management-and-icons.patch --]
[-- Type: text/x-patch, Size: 3656 bytes --]
From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 25 Apr 2020 21:43:25 -0400
Subject: [PATCH] gnu: spacefm: Fix privilege management and icons.
* gnu/packages/lxde.scm (spacefm): Fix privilege management and icons.
This commit contains changes that were accidentally left out in
commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8.
---
gnu/packages/lxde.scm | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index 9de96a21cb..3fd2eaff69 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -27,6 +27,7 @@
(define-module (gnu packages lxde)
#:use-module (gnu packages)
+ #:use-module (gnu packages admin)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
#:use-module (gnu packages disk)
@@ -276,7 +277,8 @@ with freedesktop.org standard.")
("intltool" ,intltool)
("pkg-config" ,pkg-config)))
(inputs
- `(("bash" ,bash)
+ `(("adwaita-icon-theme" ,adwaita-icon-theme) ; Hard-coded theme
+ ("bash" ,bash)
("cairo" ,cairo)
("curlftpfs" ,curlftpfs)
("dbus" ,dbus)
@@ -288,21 +290,42 @@ with freedesktop.org standard.")
("gtk+" ,gtk+)
("ifuse" ,ifuse)
("jmtpfs" ,jmtpfs)
+ ("ktsuss" ,ktsuss)
("libx11" ,libx11)
("lsof" ,lsof)
("pango" ,pango)
("shared-mime-info" ,shared-mime-info)
("startup-notification" ,startup-notification)
+ ("sudo" ,sudo)
("udevil" ,udevil)
("util-linux" ,util-linux)
("wget" ,wget)))
(arguments
- `(#:configure-flags (list (string-append "--with-bash-path="
- (assoc-ref %build-inputs "bash")
- "/bin/bash")
- (string-append "--sysconfdir="
- (assoc-ref %outputs "out")
- "/etc"))))
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-spacefm-conf
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "etc/spacefm.conf"
+ (("#terminal_su=/bin/su")
+ (string-append "terminal_su="
+ (string-append (assoc-ref inputs "sudo")
+ "/bin/sudo"))))
+ (substitute* "etc/spacefm.conf"
+ (("#graphical_su=/usr/bin/gksu")
+ (string-append "graphical_su="
+ (string-append (assoc-ref inputs "ktsuss")
+ "/bin/ktsuss"))))
+ #t)))
+ #:configure-flags (list
+ (string-append "--with-preferable-sudo="
+ (assoc-ref %build-inputs "ktsuss")
+ "/bin/ktsuss")
+ (string-append "--with-bash-path="
+ (assoc-ref %build-inputs "bash")
+ "/bin/bash")
+ (string-append "--sysconfdir="
+ (assoc-ref %outputs "out")
+ "/etc"))))
(home-page "https://ignorantguru.github.io/spacefm/")
(synopsis "Multi-panel tabbed file manager")
(description "SpaceFM is a graphical, multi-panel, tabbed file manager
--
2.26.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-26 2:11 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality Raghav Gururajan
@ 2020-04-26 14:00 ` Jan Nieuwenhuizen
2020-04-27 6:29 ` Raghav Gururajan
0 siblings, 1 reply; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-26 14:00 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753
Raghav Gururajan writes:
Hello Raghav,
>> Pushed to master with small cosmetic change below.
>>
>> Thanks for the patch!
>
> I accidentally sent the wrong patch that missed some things. So sorry. I have
> attached a patch with this email to append the previous. Could you please push
> it as new commit. Thanks!
Don't worry, we all make mistakes.
> From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sat, 25 Apr 2020 21:43:25 -0400
> Subject: [PATCH] gnu: spacefm: Fix privilege management and icons.
>>>HERE<<<
> * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons.
Please move this remark:
> This commit contains changes that were accidentally left out in
> commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8.
beteen subject and "* gnu/packages/lxde", so to >>>HERE<<<
> (arguments
> - `(#:configure-flags (list (string-append "--with-bash-path="
> - (assoc-ref %build-inputs "bash")
> - "/bin/bash")
> - (string-append "--sysconfdir="
> - (assoc-ref %outputs "out")
> - "/etc"))))
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-spacefm-conf
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "etc/spacefm.conf"
> + (("#terminal_su=/bin/su")
> + (string-append "terminal_su="
> + (string-append (assoc-ref inputs "sudo")
> + "/bin/sudo"))))
Does this work; SU is not SUDO? Also, I don't see how <sudo>/bin/sudo
would work. When I run this
$(guix build sudo)/bin/sudo
I get
sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sudo must be owned by uid 0 and have the setuid bit set
Am I missing something?
> + (substitute* "etc/spacefm.conf"
> + (("#graphical_su=/usr/bin/gksu")
> + (string-append "graphical_su="
> + (string-append (assoc-ref inputs "ktsuss")
> + "/bin/ktsuss"))))
> + #t)))
Changing the default configurations does not seem to work for me. When
I select
/File/Root Window
there is a pop-up that says: Please configure a valid Terminal SU
command. Does it work for You?
> + #:configure-flags (list
^
Trailing space.
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-26 14:00 ` Jan Nieuwenhuizen
@ 2020-04-27 6:29 ` Raghav Gururajan
2020-04-27 6:38 ` Efraim Flashner
2020-04-27 8:37 ` [bug#40753] " Jan Nieuwenhuizen
0 siblings, 2 replies; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-27 6:29 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753
[-- Attachment #1: Type: text/plain, Size: 2732 bytes --]
Hi Jan!
> >>>HERE<<<
>
> > * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons.
>
> Please move this remark:
>
> > This commit contains changes that were accidentally left out in
> > commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8.
>
> beteen subject and "* gnu/packages/lxde", so to >>>HERE<<<
Sure.
> > (arguments
> > - `(#:configure-flags (list (string-append "--with-bash-path="
> > - (assoc-ref %build-inputs
> > "bash")
> > - "/bin/bash")
> > - (string-append "--sysconfdir="
> > - (assoc-ref %outputs "out")
> > - "/etc"))))
> > + `(#:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'patch-spacefm-conf
> > + (lambda* (#:key inputs #:allow-other-keys)
> > + (substitute* "etc/spacefm.conf"
> > + (("#terminal_su=/bin/su")
> > + (string-append "terminal_su="
> > + (string-append (assoc-ref inputs "sudo")
> > + "/bin/sudo"))))
>
> Does this work; SU is not SUDO? Also, I don't see how <sudo>/bin/sudo
> would work. When I run this
>
> $(guix build sudo)/bin/sudo
>
> I get
>
> sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sudo
> must be owned by uid 0 and have the setuid bit set
>
> Am I missing something?
The option just has the name "su". It can be sudo too. I wouldn't worry about
this terminal_su option. This is just has to be set, so that spacefm doesn't
throw "no valid program found" error, now and then, because of default FHS path.
SpaceFM primarily uses graphical_su, which has been set to 'ktsuss'.
> > + (substitute* "etc/spacefm.conf"
> > + (("#graphical_su=/usr/bin/gksu")
> > + (string-append "graphical_su="
> > + (string-append (assoc-ref inputs "ktsuss")
> > + "/bin/ktsuss"))))
> > + #t)))
>
> Changing the default configurations does not seem to work for me. When
> I select
>
> /File/Root Window
>
> there is a pop-up that says: Please configure a valid Terminal SU
> command. Does it work for You?
This is exactly the error I was talking about above. Once we apply this patch,
the error appearing stops and ktsuss will pop right up.
>
> > + #:configure-flags (list
> ^
> Trailing space.
Thanks! I have attached revised patch with this email.
Regards,
RG.
[-- Attachment #2: 0001-gnu-spacefm-Fix-privilege-management.patch --]
[-- Type: text/x-patch, Size: 3187 bytes --]
From 636d358dc3290433b929ebd72ad087dbfa50c8a5 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Mon, 27 Apr 2020 02:27:16 -0400
Subject: [PATCH] gnu: spacefm: Fix privilege management.
* gnu/packages/lxde.scm (spacefm): Fix privilege management.
---
gnu/packages/lxde.scm | 34 ++++++++++++++++++++++++++++------
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index 9de96a21cb..8b9759bc9c 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -27,6 +27,7 @@
(define-module (gnu packages lxde)
#:use-module (gnu packages)
+ #:use-module (gnu packages admin)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
#:use-module (gnu packages disk)
@@ -288,21 +289,42 @@ with freedesktop.org standard.")
("gtk+" ,gtk+)
("ifuse" ,ifuse)
("jmtpfs" ,jmtpfs)
+ ("ktsuss" ,ktsuss)
("libx11" ,libx11)
("lsof" ,lsof)
("pango" ,pango)
("shared-mime-info" ,shared-mime-info)
("startup-notification" ,startup-notification)
+ ("sudo" ,sudo)
("udevil" ,udevil)
("util-linux" ,util-linux)
("wget" ,wget)))
(arguments
- `(#:configure-flags (list (string-append "--with-bash-path="
- (assoc-ref %build-inputs "bash")
- "/bin/bash")
- (string-append "--sysconfdir="
- (assoc-ref %outputs "out")
- "/etc"))))
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-spacefm-conf
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "etc/spacefm.conf"
+ (("#terminal_su=/bin/su")
+ (string-append "terminal_su="
+ (string-append (assoc-ref inputs "sudo")
+ "/bin/sudo"))))
+ (substitute* "etc/spacefm.conf"
+ (("#graphical_su=/usr/bin/gksu")
+ (string-append "graphical_su="
+ (string-append (assoc-ref inputs "ktsuss")
+ "/bin/ktsuss"))))
+ #t)))
+ #:configure-flags (list
+ (string-append "--with-preferable-sudo="
+ (assoc-ref %build-inputs "ktsuss")
+ "/bin/ktsuss")
+ (string-append "--with-bash-path="
+ (assoc-ref %build-inputs "bash")
+ "/bin/bash")
+ (string-append "--sysconfdir="
+ (assoc-ref %outputs "out")
+ "/etc"))))
(home-page "https://ignorantguru.github.io/spacefm/")
(synopsis "Multi-panel tabbed file manager")
(description "SpaceFM is a graphical, multi-panel, tabbed file manager
--
2.26.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-27 6:29 ` Raghav Gururajan
@ 2020-04-27 6:38 ` Efraim Flashner
2020-04-27 8:42 ` Jan Nieuwenhuizen
2020-04-27 8:37 ` [bug#40753] " Jan Nieuwenhuizen
1 sibling, 1 reply; 17+ messages in thread
From: Efraim Flashner @ 2020-04-27 6:38 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753, Jan Nieuwenhuizen
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
On Guix System $(guix build sudo)/bin/sudo isn't setuid, we'd need the
one from /run/setuid-programs.
(ins)efraim@E5400 ~$ which sudo
/run/setuid-programs/sudo
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-27 6:29 ` Raghav Gururajan
2020-04-27 6:38 ` Efraim Flashner
@ 2020-04-27 8:37 ` Jan Nieuwenhuizen
1 sibling, 0 replies; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-27 8:37 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753
Raghav Gururajan writes:
Hello Raghav,
>> Does this work; SU is not SUDO? Also, I don't see how <sudo>/bin/sudo
>> would work. When I run this
>>
>> $(guix build sudo)/bin/sudo
>>
>> I get
>>
>> sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sudo
>> must be owned by uid 0 and have the setuid bit set
>>
>> Am I missing something?
>
> The option just has the name "su". It can be sudo too. I wouldn't worry about
> this terminal_su option.
That's okay, I'm not really worried :-)
When I read a patch, and I cannot imagine how that would work, I would
like to learn more to understand it beter, or remove it. I do not like
adding code that I do not understand, and also does not work.
> This is just has to be set, so that spacefm doesn't throw "no valid
> program found" error, now and then, because of default FHS path.
> SpaceFM primarily uses graphical_su, which has been set to 'ktsuss'.
Okay, that would explain something. So, TERMINAL_SU just needs to be
set to "some" existing executable, but is not used? What about
`(#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-spacefm-conf
(lambda _
;; If terminal_su is unset, users get a popup:
;; "Please configure a valid Terminal SU command."
(substitute* "etc/spacefm.conf"
(("#terminal_su=/bin/su")
"terminal_su=/run/current-system/profile/bin/false"))
#t)))
I tested this, and it hase the same, partially functional result, as
using sudo and setting #graphical_su. WDYT?
>> > + (substitute* "etc/spacefm.conf"
>> > + (("#graphical_su=/usr/bin/gksu")
>> > + (string-append "graphical_su="
>> > + (string-append (assoc-ref inputs "ktsuss")
>> > + "/bin/ktsuss"))))
>> > + #t)))
>>
>> Changing the default configurations does not seem to work for me. When
>> I select
>>
>> /File/Root Window
>>
>> there is a pop-up that says: Please configure a valid Terminal SU
>> command. Does it work for You?
>
> This is exactly the error I was talking about above. Once we apply this patch,
> the error appearing stops and ktsuss will pop right up.
Hmm. Can you double check? I tested your patch again today it (still)
does not work. I get
Please configure a valid Terminal SU command.
Only when I manually point spacefm to it's configuration file, like so
/gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/bin/spacefm -c /gnu/store/y24705ci3dcjiqdig3k3x18pc6aymnzc-spacefm-1.0.6/etc/spacefm/
then the popup disappears. So now I am wondering, is the problem with
your setup or with mine? What do you think?
By the way, the KTSUSS popup (when I see it) does not work for me. Have
you tested KTSUSS?
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-27 6:38 ` Efraim Flashner
@ 2020-04-27 8:42 ` Jan Nieuwenhuizen
2020-04-28 9:11 ` Raghav Gururajan
0 siblings, 1 reply; 17+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-27 8:42 UTC (permalink / raw)
To: Efraim Flashner; +Cc: 40753, Raghav Gururajan
Efraim Flashner writes:
> On Guix System $(guix build sudo)/bin/sudo isn't setuid, we'd need the
> one from /run/setuid-programs.
>
> (ins)efraim@E5400 ~$ which sudo
> /run/setuid-programs/sudo
Yes, that's what I wanted to suggest...but then I saw that the setting
is called TERMINAL_SU (not SUDO). That got me thinking: this is
possibly not used at all...could be dead code?
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-27 8:42 ` Jan Nieuwenhuizen
@ 2020-04-28 9:11 ` Raghav Gururajan
2020-04-30 13:57 ` Raghav Gururajan
0 siblings, 1 reply; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-28 9:11 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753, Efraim Flashner
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Hi Jan!
Sorry again for messing this up. I have attached revised patch with this email.
This, along with #40922 and new patch at #40901, makes SpaceFM to work
perfectly. :-)
Regards,
RG.
[-- Attachment #2: 0003-gnu-spacefm-Fix-privilege-and-disk-management.patch --]
[-- Type: text/x-patch, Size: 3394 bytes --]
From b623508a4e673e53e63336ee5d97c39e85b52b75 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 28 Apr 2020 05:02:06 -0400
Subject: [PATCH 3/3] gnu: spacefm: Fix privilege and disk management.
* gnu/packages/lxde.scm (spacefm): Fix privilege and disk management.
Patched references to su, ktsuss and udevil; to load them correctly.
---
gnu/packages/lxde.scm | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index 9de96a21cb..d152f6f79d 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -27,6 +27,7 @@
(define-module (gnu packages lxde)
#:use-module (gnu packages)
+ #:use-module (gnu packages admin)
#:use-module (gnu packages autotools)
#:use-module (gnu packages bash)
#:use-module (gnu packages disk)
@@ -279,7 +280,6 @@ with freedesktop.org standard.")
`(("bash" ,bash)
("cairo" ,cairo)
("curlftpfs" ,curlftpfs)
- ("dbus" ,dbus)
("eudev" ,eudev)
("fakeroot" ,fakeroot)
("ffmpegthumbnailer" ,ffmpegthumbnailer)
@@ -288,6 +288,7 @@ with freedesktop.org standard.")
("gtk+" ,gtk+)
("ifuse" ,ifuse)
("jmtpfs" ,jmtpfs)
+ ("ktsuss" ,ktsuss)
("libx11" ,libx11)
("lsof" ,lsof)
("pango" ,pango)
@@ -297,12 +298,31 @@ with freedesktop.org standard.")
("util-linux" ,util-linux)
("wget" ,wget)))
(arguments
- `(#:configure-flags (list (string-append "--with-bash-path="
- (assoc-ref %build-inputs "bash")
- "/bin/bash")
- (string-append "--sysconfdir="
- (assoc-ref %outputs "out")
- "/etc"))))
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-source-files
+ (lambda* (#:key inputs #:allow-other-keys)
+ ;; Patch config file to load programs correctly.
+ (substitute* "etc/spacefm.conf"
+ (("#terminal_su=/bin/su")
+ "terminal_su=/run/setuid-programs/su")
+ (("#graphical_su=/usr/bin/gksu")
+ (string-append "graphical_su="
+ (string-append (assoc-ref inputs "ktsuss")
+ "/bin/ktsuss"))))
+ ;; SpaceFM expects udevil to have uid set to root.
+ ;; User has to manually add udevil to setuid-programs.
+ (substitute* "src/settings.c"
+ (("/usr/bin/udevil")
+ "/run/setuid-programs/udevil"))
+ #t)))
+ #:configure-flags (list
+ (string-append "--with-bash-path="
+ (assoc-ref %build-inputs "bash")
+ "/bin/bash")
+ (string-append "--sysconfdir="
+ (assoc-ref %outputs "out")
+ "/etc"))))
(home-page "https://ignorantguru.github.io/spacefm/")
(synopsis "Multi-panel tabbed file manager")
(description "SpaceFM is a graphical, multi-panel, tabbed file manager
--
2.26.2
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [bug#40753] gnu: spacefm: Add dependencies for extra functionality.
2020-04-28 9:11 ` Raghav Gururajan
@ 2020-04-30 13:57 ` Raghav Gururajan
2020-05-30 5:08 ` bug#40753: " Maxim Cournoyer
0 siblings, 1 reply; 17+ messages in thread
From: Raghav Gururajan @ 2020-04-30 13:57 UTC (permalink / raw)
To: Jan Nieuwenhuizen; +Cc: 40753, Efraim Flashner
Hi Jan!
Since #40753 is already closed. I have sent revised patch as #40982.
So #40982 and #40922, should fix current spacefm disk issues.
Regards,
RG.
^ permalink raw reply [flat|nested] 17+ messages in thread
* bug#40753: gnu: spacefm: Add dependencies for extra functionality.
2020-04-30 13:57 ` Raghav Gururajan
@ 2020-05-30 5:08 ` Maxim Cournoyer
0 siblings, 0 replies; 17+ messages in thread
From: Maxim Cournoyer @ 2020-05-30 5:08 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40753-done, Efraim Flashner, Jan Nieuwenhuizen
Raghav Gururajan <raghavgururajan@disroot.org> writes:
> Hi Jan!
>
> Since #40753 is already closed. I have sent revised patch as #40982.
>
> So #40982 and #40922, should fix current spacefm disk issues.
>
> Regards,
> RG.
Alright, I'm closing this one then, by sending a reply to
40753-done@debbugs.gnu.org (that is, simply add the '-done' suffix to
the bug number in the debbugs email).
Thank you,
Maxim
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-05-30 5:09 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 21:28 [bug#40753] gnu: spacefm: Add missing dependencies Raghav Gururajan
2020-04-22 0:15 ` [bug#40753] gnu: spacefm: Add and configure missing dependencies. (v2) Raghav Gururajan
2020-04-22 6:46 ` [bug#40753] gnu: spacefm: Add missing dependencies Jan Nieuwenhuizen
2020-04-22 16:28 ` Raghav Gururajan
2020-04-22 17:59 ` Jan Nieuwenhuizen
2020-04-22 20:22 ` [bug#40753] gnu: spacefm: Add missing dependencies. (v3) Raghav Gururajan
2020-04-24 19:35 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality. (v3) Raghav Gururajan
2020-04-24 20:09 ` Jan Nieuwenhuizen
2020-04-26 2:11 ` [bug#40753] gnu: spacefm: Add dependencies for extra functionality Raghav Gururajan
2020-04-26 14:00 ` Jan Nieuwenhuizen
2020-04-27 6:29 ` Raghav Gururajan
2020-04-27 6:38 ` Efraim Flashner
2020-04-27 8:42 ` Jan Nieuwenhuizen
2020-04-28 9:11 ` Raghav Gururajan
2020-04-30 13:57 ` Raghav Gururajan
2020-05-30 5:08 ` bug#40753: " Maxim Cournoyer
2020-04-27 8:37 ` [bug#40753] " Jan Nieuwenhuizen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).